RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-21 Thread Jun Li
t; ; Heikki Krogerus ; > Suzuki K Poulose ; Chunfeng Yun > ; Hans de Goede ; Andy > Shevchenko > ; Valentin Schneider ; > Jack Pham ; Linux USB List ; > open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; > Peter Chen > Subject: Re: [PATCH v4 3/9] usb: dwc3

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-21 Thread Jun Li
ki K Poulose ; Chunfeng Yun > ; Hans de Goede ; Andy > Shevchenko > ; Valentin Schneider ; > Jack Pham ; Linux USB List ; > open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; > Peter Chen > Subject: Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for C

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-21 Thread Felipe Balbi
Hi Jun, Felipe Balbi writes: >> In any case, increasing the timeout should be fine with me. It maybe >> difficult to determine the max timeout base on the slowest clock rate >> and number of cycles. Different controller and controller versions >> behave differently and may have different

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-21 Thread Felipe Balbi
Hi, Thinh Nguyen writes: "Power Down Scale (PwrDnScale) The USB3 suspend_clk input replaces pipe3_rx_pclk as a clock source to a small part of the USB3 controller that operates when the SS PHY is in its lowest power (P3) state, and therefore does not provide

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-20 Thread Thinh Nguyen
nh Nguyen >>>>>> ; Jun Li >>>>>> Cc: John Stultz ; lkml >>>>>> ; Yu Chen ; Greg >>>>>> Kroah-Hartman ; Rob Herring >>>>>> ; Mark Rutland ; ShuFan >>>>>> Lee ; Heikki Krogerus >>>>

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-20 Thread Thinh Nguyen
>> ; Mark Rutland ; ShuFan >>>>> Lee ; Heikki Krogerus >>>>> ; >>>>> Suzuki K Poulose ; Chunfeng Yun >>>>> ; Hans de Goede ; >>>>> Andy Shevchenko ; Valentin Schneider >>>>> ; Jack Pham ; >>>

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-19 Thread Jun Li
K Poulose ; Chunfeng Yun > ; Hans de Goede ; Andy > Shevchenko > ; Valentin Schneider ; > Jack Pham ; Linux USB List ; > open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; > Peter Chen > Subject: Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cle

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-19 Thread Thinh Nguyen
n Schneider >>> ; >>> Jack Pham ; Linux USB List >>> ; open >>> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS >>> ; >>> Peter Chen ; Thinh Nguyen >>> Subject: RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared >

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-19 Thread Thinh Nguyen
gt; Herring ; Mark Rutland ; ShuFan Lee >> ; Heikki Krogerus ; >> Suzuki K Poulose ; Chunfeng Yun >> ; Hans de Goede ; Andy >> Shevchenko >> ; Valentin Schneider ; >> Jack Pham ; Linux USB List >> ; open >> list:OPEN FIRMWARE AND FLATTENED DEVICE

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-18 Thread Jun Li
kki Krogerus ; > Suzuki K Poulose ; Chunfeng Yun > ; Hans de Goede ; Andy > Shevchenko > ; Valentin Schneider ; > Jack Pham ; Linux USB List ; > open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; > Peter Chen ; Thinh Nguyen > Subject: RE: [PATCH v4 3

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-16 Thread Felipe Balbi
Hi, Jun Li writes: >> >> Hi Thinh, could you comment this? >> > >> > You only need to wake up the usb2 phy when issuing the command while >> > running in highspeed or below. If you're running in SS or higher, >> > internally the controller does it for you for usb3 phy. In Jun's case, >> > it

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-16 Thread Jun Li
hunfeng Yun > >>> ; Hans de Goede ; > >>> Andy Shevchenko ; Valentin Schneider > >>> ; Jack Pham ; > >>> Linux USB List ; open list:OPEN FIRMWARE > >>> AND FLATTENED DEVICE TREE BINDINGS ; > >>> Peter Chen

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-16 Thread Felipe Balbi
am ; Linux USB List >>> ; open >>> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS >>> ; >>> Peter Chen ; Jun Li ; Thinh Nguyen >>> >>> Subject: Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared >>> by device >&g

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-15 Thread Thinh Nguyen
ShuFan Lee >> ; Heikki Krogerus ; >> Suzuki K Poulose ; Chunfeng Yun >> ; Hans de Goede ; Andy >> Shevchenko >> ; Valentin Schneider ; >> Jack Pham ; Linux USB List >> ; open >> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS >> ; >

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-15 Thread Felipe Balbi
Hi, Jun Li writes: >> Jun Li writes: >> >> @@ -397,12 +407,18 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, >> >> unsigned >> cmd, >> >> dwc3_gadget_ep_get_transfer_index(dep); >> >> } >> >> >> >> - if (saved_config) { >> >> + if

RE: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-15 Thread Jun Li
oulose ; Chunfeng Yun > ; Hans de Goede ; Andy > Shevchenko > ; Valentin Schneider ; > Jack Pham ; Linux USB List ; > open > list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > ; > Peter Chen ; Jun Li ; Thinh Nguyen > > Subject: Re: [PATCH v4 3/9] usb: dwc3

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-15 Thread Felipe Balbi
Hi, Jun Li writes: >> @@ -397,12 +407,18 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, >> unsigned cmd, >> dwc3_gadget_ep_get_transfer_index(dep); >> } >> >> - if (saved_config) { >> + if (saved_hs_config) { >> reg =

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-09 Thread Jun Li
Felipe Balbi 于2020年5月8日周五 下午8:35写道: > > > Hi, > > Jun Li writes: > > Jun Li 于2020年5月7日周四 上午11:08写道: > >> > >> John Stultz 于2020年5月7日周四 上午6:27写道: > >> > > >> > On Wed, May 6, 2020 at 2:00 AM Jun Li wrote: > >> > > John Stultz 于2019年10月30日周三 上午5:18写道: > >> > > > On Tue, Oct 29, 2019 at 2:11 AM

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-09 Thread Jun Li
Hi, Felipe Balbi 于2020年5月8日周五 下午8:33写道: > > > Hi, > > Jun Li writes: > > John Stultz 于2019年10月30日周三 上午5:18写道: > >> > >> On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: > >> > John Stultz writes: > >> > > From: Yu Chen > >> > > > >> > > It needs more time for the device controller to

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-08 Thread Felipe Balbi
Hi, Jun Li writes: > Jun Li 于2020年5月7日周四 上午11:08写道: >> >> John Stultz 于2020年5月7日周四 上午6:27写道: >> > >> > On Wed, May 6, 2020 at 2:00 AM Jun Li wrote: >> > > John Stultz 于2019年10月30日周三 上午5:18写道: >> > > > On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: >> > > > > John Stultz writes: >> >

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-08 Thread Felipe Balbi
Hi, Jun Li writes: > John Stultz 于2019年10月30日周三 上午5:18写道: >> >> On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: >> > John Stultz writes: >> > > From: Yu Chen >> > > >> > > It needs more time for the device controller to clear the CmdAct of >> > > DEPCMD on Hisilicon Kirin Soc. >> > >> >

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-08 Thread Jun Li
Jun Li 于2020年5月7日周四 上午11:08写道: > > John Stultz 于2020年5月7日周四 上午6:27写道: > > > > On Wed, May 6, 2020 at 2:00 AM Jun Li wrote: > > > John Stultz 于2019年10月30日周三 上午5:18写道: > > > > On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: > > > > > John Stultz writes: > > > > > > From: Yu Chen > > > > >

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-06 Thread Jun Li
John Stultz 于2020年5月7日周四 上午6:27写道: > > On Wed, May 6, 2020 at 2:00 AM Jun Li wrote: > > John Stultz 于2019年10月30日周三 上午5:18写道: > > > On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: > > > > John Stultz writes: > > > > > From: Yu Chen > > > > > > > > > > It needs more time for the device

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-06 Thread John Stultz
On Wed, May 6, 2020 at 2:00 AM Jun Li wrote: > John Stultz 于2019年10月30日周三 上午5:18写道: > > On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: > > > John Stultz writes: > > > > From: Yu Chen > > > > > > > > It needs more time for the device controller to clear the CmdAct of > > > > DEPCMD on

Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

2020-05-06 Thread Jun Li
John Stultz 于2019年10月30日周三 上午5:18写道: > > On Tue, Oct 29, 2019 at 2:11 AM Felipe Balbi wrote: > > John Stultz writes: > > > From: Yu Chen > > > > > > It needs more time for the device controller to clear the CmdAct of > > > DEPCMD on Hisilicon Kirin Soc. > > > > Why does it need more time? Why