Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Tue, Dec 13, 2016 at 12:00:32PM -0800, Doug Anderson wrote: > On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown wrote: > > No, not unless the prior descriptions of the hardware have been wildly > > inaccurate - my understanding had been that the DCDC was a normal DCDC > > with

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Tue, Dec 13, 2016 at 12:00:32PM -0800, Doug Anderson wrote: > On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown wrote: > > No, not unless the prior descriptions of the hardware have been wildly > > inaccurate - my understanding had been that the DCDC was a normal DCDC > > with an analogue input

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, El Tue, Dec 13, 2016 at 12:00:32PM -0800 Doug Anderson ha dit: > On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown wrote: > > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: > >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > >> > On Mon, Sep

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, El Tue, Dec 13, 2016 at 12:00:32PM -0800 Doug Anderson ha dit: > On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown wrote: > > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: > >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > >> > On Mon, Sep 26, 2016 at

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown wrote: > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: >> > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > >> > What you're

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, On Tue, Dec 13, 2016 at 9:19 AM, Mark Brown wrote: > On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: >> El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: >> > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > >> > What you're describing to me is a

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: > El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > > What you're describing to me is a discrete DCDC that has an input > > voltage that sets the

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Mon, Dec 12, 2016 at 01:15:02PM -0800, Matthias Kaehlcke wrote: > El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > > What you're describing to me is a discrete DCDC that has an input > > voltage that sets the

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > > > I guess I think of the whole network of components as the PWM > > regulator and not the individual discreet BUCK. I'm also not quite > > sure how you would model it

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

El Fri, Oct 28, 2016 at 07:15:21PM +0100 Mark Brown ha dit: > On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > > > I guess I think of the whole network of components as the PWM > > regulator and not the individual discreet BUCK. I'm also not quite > > sure how you would model it

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > I guess I think of the whole network of components as the PWM > regulator and not the individual discreet BUCK. I'm also not quite > sure how you would model it as you're asking. I suppose you could say > that all of the resistors

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Mon, Sep 26, 2016 at 10:41:59AM -0700, Doug Anderson wrote: > I guess I think of the whole network of components as the PWM > regulator and not the individual discreet BUCK. I'm also not quite > sure how you would model it as you're asking. I suppose you could say > that all of the resistors

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, On Sat, Sep 24, 2016 at 11:41 AM, Mark Brown wrote: > On Mon, Sep 19, 2016 at 11:39:24AM -0700, Doug Anderson wrote: >> On Fri, Sep 16, 2016 at 9:32 AM, Mark Brown wrote: > >> > So the PWM is just configuring this external regulator chip (which >> >

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, On Sat, Sep 24, 2016 at 11:41 AM, Mark Brown wrote: > On Mon, Sep 19, 2016 at 11:39:24AM -0700, Doug Anderson wrote: >> On Fri, Sep 16, 2016 at 9:32 AM, Mark Brown wrote: > >> > So the PWM is just configuring this external regulator chip (which >> > doesn't seem to be described in DT...)

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Mon, Sep 19, 2016 at 11:39:24AM -0700, Doug Anderson wrote: > On Fri, Sep 16, 2016 at 9:32 AM, Mark Brown wrote: > > So the PWM is just configuring this external regulator chip (which > > doesn't seem to be described in DT...) and that's just incredibly bad at > > coping

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Mon, Sep 19, 2016 at 11:39:24AM -0700, Doug Anderson wrote: > On Fri, Sep 16, 2016 at 9:32 AM, Mark Brown wrote: > > So the PWM is just configuring this external regulator chip (which > > doesn't seem to be described in DT...) and that's just incredibly bad at > > coping with voltage changes?

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, On Fri, Sep 16, 2016 at 9:32 AM, Mark Brown wrote: > On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: >> El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > >> > The obvious question here is how the OVP hardware knows about the new >> > voltage

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi, On Fri, Sep 16, 2016 at 9:32 AM, Mark Brown wrote: > On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: >> El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > >> > The obvious question here is how the OVP hardware knows about the new >> > voltage and why we're

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Fri, Sep 16, 2016 at 11:31:45AM -0700, Matthias Kaehlcke wrote: > El Fri, Sep 16, 2016 at 05:32:53PM +0100 Mark Brown ha dit: > > It does sound rather like we ought to be representing this chip > > directly in case it needs other workarounds. > Ok, we'll consider this. It seems we can drop

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Fri, Sep 16, 2016 at 11:31:45AM -0700, Matthias Kaehlcke wrote: > El Fri, Sep 16, 2016 at 05:32:53PM +0100 Mark Brown ha dit: > > It does sound rather like we ought to be representing this chip > > directly in case it needs other workarounds. > Ok, we'll consider this. It seems we can drop

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

El Fri, Sep 16, 2016 at 05:32:53PM +0100 Mark Brown ha dit: > On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: > > El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > > > > The obvious question here is how the OVP hardware knows about the new > > > voltage and why

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

El Fri, Sep 16, 2016 at 05:32:53PM +0100 Mark Brown ha dit: > On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: > > El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > > > > The obvious question here is how the OVP hardware knows about the new > > > voltage and why

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: > El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > > The obvious question here is how the OVP hardware knows about the new > > voltage and why we're bodging this in the regulator core rather than in > > the OVP

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Thu, Sep 15, 2016 at 11:02:23AM -0700, Matthias Kaehlcke wrote: > El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > > The obvious question here is how the OVP hardware knows about the new > > voltage and why we're bodging this in the regulator core rather than in > > the OVP

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi Mark, El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > On Tue, Sep 13, 2016 at 10:21:40AM -0700, Matthias Kaehlcke wrote: > > > Optimizing the delay time depends on the SoC; we have not measured > > this across a wide variety of devices and thus have very conservative > >

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi Mark, El Thu, Sep 15, 2016 at 03:39:45PM +0100 Mark Brown ha dit: > On Tue, Sep 13, 2016 at 10:21:40AM -0700, Matthias Kaehlcke wrote: > > > Optimizing the delay time depends on the SoC; we have not measured > > this across a wide variety of devices and thus have very conservative > >

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Tue, Sep 13, 2016 at 10:21:40AM -0700, Matthias Kaehlcke wrote: > Optimizing the delay time depends on the SoC; we have not measured > this across a wide variety of devices and thus have very conservative > numbers. The percentage is based on the trigger for OVP on the > regulator. In this

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Tue, Sep 13, 2016 at 10:21:40AM -0700, Matthias Kaehlcke wrote: > Optimizing the delay time depends on the SoC; we have not measured > this across a wide variety of devices and thus have very conservative > numbers. The percentage is based on the trigger for OVP on the > regulator. In this

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi Mark, thanks for your review, please find my comments (including info from our EE) below. El Mon, Sep 12, 2016 at 07:56:33PM +0100 Mark Brown ha dit: > On Tue, Sep 06, 2016 at 12:05:24PM -0700, Matthias Kaehlcke wrote: > > > On some boards it's possible that transitioning the PWM regulator

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

Hi Mark, thanks for your review, please find my comments (including info from our EE) below. El Mon, Sep 12, 2016 at 07:56:33PM +0100 Mark Brown ha dit: > On Tue, Sep 06, 2016 at 12:05:24PM -0700, Matthias Kaehlcke wrote: > > > On some boards it's possible that transitioning the PWM regulator

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Tue, Sep 06, 2016 at 12:05:24PM -0700, Matthias Kaehlcke wrote: > On some boards it's possible that transitioning the PWM regulator > downwards too fast will trigger the over voltage protection (OVP) on the > regulator. This is because until the voltage actually falls there is a > time when

Re: [PATCH v4 4/4] regulator: Prevent falling too fast

On Tue, Sep 06, 2016 at 12:05:24PM -0700, Matthias Kaehlcke wrote: > On some boards it's possible that transitioning the PWM regulator > downwards too fast will trigger the over voltage protection (OVP) on the > regulator. This is because until the voltage actually falls there is a > time when