Re: [PATCH v4 7/8] hugetlb: make free_huge_page irq safe

2021-04-07 Thread Oscar Salvador
On Wed, Apr 07, 2021 at 11:33:18AM +0200, Michal Hocko wrote: > Yes. spin_unlock_irq will enable interrupts unconditionally which is > certainly not what we want if the path is called with IRQ disabled by > the caller. I see, thanks for confirming. -- Oscar Salvador SUSE L3

Re: [PATCH v4 7/8] hugetlb: make free_huge_page irq safe

2021-04-07 Thread Michal Hocko
On Wed 07-04-21 11:12:37, Oscar Salvador wrote: > On Mon, Apr 05, 2021 at 04:00:42PM -0700, Mike Kravetz wrote: > > Commit c77c0a8ac4c5 ("mm/hugetlb: defer freeing of huge pages if in > > non-task context") was added to address the issue of free_huge_page > > being called from irq context. That

Re: [PATCH v4 7/8] hugetlb: make free_huge_page irq safe

2021-04-07 Thread Oscar Salvador
On Mon, Apr 05, 2021 at 04:00:42PM -0700, Mike Kravetz wrote: > Commit c77c0a8ac4c5 ("mm/hugetlb: defer freeing of huge pages if in > non-task context") was added to address the issue of free_huge_page > being called from irq context. That commit hands off free_huge_page > processing to a