Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-13 Thread Steven Eckhoff
On Wed, Dec 13, 2017 at 10:47:32AM +, Mark Brown wrote: > The things the driver is doing automatically to mute the DACs and ADCs > should be moved to user control if they're not suitable for doing > automatically. > The mutes can work normally without the PLL stuff. I have removed the PLL

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-13 Thread Steven Eckhoff
On Wed, Dec 13, 2017 at 10:47:32AM +, Mark Brown wrote: > The things the driver is doing automatically to mute the DACs and ADCs > should be moved to user control if they're not suitable for doing > automatically. > The mutes can work normally without the PLL stuff. I have removed the PLL

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-13 Thread Mark Brown
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote: > Also I am not sure what you mean with the mute controls. Could you > elaborate more on this? The things the driver is doing automatically to mute the DACs and ADCs should be moved to user control if they're not suitable for doing

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-13 Thread Mark Brown
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote: > Also I am not sure what you mean with the mute controls. Could you > elaborate more on this? The things the driver is doing automatically to mute the DACs and ADCs should be moved to user control if they're not suitable for doing

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote: > > > > +static int tscs42xx_mute_stream(struct snd_soc_dai *dai, int mute, int > > > > stream) > > > > +{ > > > > + struct snd_soc_codec *codec = dai->codec; > > > > + int ret; > > > > + > > > > + if (mute) > > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:51:35PM -0600, Steven Eckhoff wrote: > > > > +static int tscs42xx_mute_stream(struct snd_soc_dai *dai, int mute, int > > > > stream) > > > > +{ > > > > + struct snd_soc_codec *codec = dai->codec; > > > > + int ret; > > > > + > > > > + if (mute) > > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 03:31:16PM -0600, Steven Eckhoff wrote: > On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODEC. > > > > > > Add support for it. > > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 03:31:16PM -0600, Steven Eckhoff wrote: > On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODEC. > > > > > > Add support for it. > > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issues raised in the previous reviews. > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 04:32:54PM +, Mark Brown wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issues raised in the previous reviews. > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 02:10:09PM +0100, Takashi Iwai wrote: > On Tue, 12 Dec 2017 14:04:01 +0100, > Charles Keepax wrote: > > > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODEC. > > > > > > Add support for it. >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 02:10:09PM +0100, Takashi Iwai wrote: > On Tue, 12 Dec 2017 14:04:01 +0100, > Charles Keepax wrote: > > > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > > Currently there is no support for the TSCS42xx audio CODEC. > > > > > > Add support for it. >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 01:04:01PM +, Charles Keepax wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issues raised in the previous reviews.

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Steven Eckhoff
On Tue, Dec 12, 2017 at 01:04:01PM +, Charles Keepax wrote: > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issues raised in the previous reviews.

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Mark Brown
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > Currently there is no support for the TSCS42xx audio CODEC. > > Add support for it. > > v5 attempts to address all issues raised in the previous reviews. > > Thank you to everyone who has invested their time reviewing these >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Mark Brown
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > Currently there is no support for the TSCS42xx audio CODEC. > > Add support for it. > > v5 attempts to address all issues raised in the previous reviews. > > Thank you to everyone who has invested their time reviewing these >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Takashi Iwai
On Tue, 12 Dec 2017 14:04:01 +0100, Charles Keepax wrote: > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issues raised in the previous reviews. > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Takashi Iwai
On Tue, 12 Dec 2017 14:04:01 +0100, Charles Keepax wrote: > > On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > > Currently there is no support for the TSCS42xx audio CODEC. > > > > Add support for it. > > > > v5 attempts to address all issues raised in the previous reviews. > >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Charles Keepax
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > Currently there is no support for the TSCS42xx audio CODEC. > > Add support for it. > > v5 attempts to address all issues raised in the previous reviews. > > Thank you to everyone who has invested their time reviewing these >

Re: [PATCH v5] ASoC: TSCS42xx: Add support for Tempo Semiconductor's TSCS42xx audio CODEC

2017-12-12 Thread Charles Keepax
On Mon, Dec 11, 2017 at 01:54:25PM -0600, Steven Eckhoff wrote: > Currently there is no support for the TSCS42xx audio CODEC. > > Add support for it. > > v5 attempts to address all issues raised in the previous reviews. > > Thank you to everyone who has invested their time reviewing these >