Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-08-18 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Jun 12, 2020 at 5:51 PM Laurent Pinchart wrote: > On Fri, Jun 12, 2020 at 05:36:07PM +0200, Eugeniu Rosca wrote: > > On Fri, Jun 12, 2020 at 06:10:05PM +0300, Laurent Pinchart wrote: > > > On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote: > > > > On Tue, Jun 09,

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-07-17 Thread Jacopo Mondi
Hello Eugeniu, On Mon, Jun 15, 2020 at 04:17:23PM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > On Fri, Jun 12, 2020 at 05:12:09PM +0200, Jacopo Mondi wrote: > > On Mon, Jun 08, 2020 at 11:44:32AM +0200, Eugeniu Rosca wrote: > > > FWIW, I seem to hit pre-existing issues in vanilla rcar-du, > > >

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-15 Thread Eugeniu Rosca
Hi Jacopo, On Fri, Jun 12, 2020 at 05:12:09PM +0200, Jacopo Mondi wrote: > On Mon, Jun 08, 2020 at 11:44:32AM +0200, Eugeniu Rosca wrote: > > FWIW, I seem to hit pre-existing issues in vanilla rcar-du, > > while unplugging HDMI cable during a cyclic suspend-resume: > > > > HW: H3 ES2.0 Salvator-X

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-12 Thread Laurent Pinchart
Hi Eugeniu, On Fri, Jun 12, 2020 at 05:36:07PM +0200, Eugeniu Rosca wrote: > On Fri, Jun 12, 2020 at 06:10:05PM +0300, Laurent Pinchart wrote: > > On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote: > > > On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote: > > > > On Sun, Jun

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-12 Thread Eugeniu Rosca
Hi, On Fri, Jun 12, 2020 at 06:10:05PM +0300, Laurent Pinchart wrote: > On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote: > > On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote: > > > On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > > > > Note that the

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-12 Thread Laurent Pinchart
Hi Jacopo, On Fri, Jun 12, 2020 at 05:00:32PM +0200, Jacopo Mondi wrote: > On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote: > > On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > > > Note that the CMM driver is controlled by the DU driver. As the DU > > > driver

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-12 Thread Jacopo Mondi
Hi Eugeniu On Mon, Jun 08, 2020 at 11:44:32AM +0200, Eugeniu Rosca wrote: > Hello, > > Many thanks for your comments and involvement. > > On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > > On Fri, Jun 05, 2020 at 03:53:15PM +0200, Jacopo Mondi wrote: > > > On Fri, Jun 05, 2020

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-12 Thread Jacopo Mondi
Hi Eugeniu, On Tue, Jun 09, 2020 at 04:29:59PM +0200, Eugeniu Rosca wrote: > Hi Laurent, > > On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > > Note that the CMM driver is controlled by the DU driver. As the DU > > driver will reenable the display during resume, it will call >

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-09 Thread Eugeniu Rosca
Hi Laurent, On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > Note that the CMM driver is controlled by the DU driver. As the DU > driver will reenable the display during resume, it will call > rcar_du_cmm_setup() at resume time, which will reprogram the CMM. There > should thus

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-08 Thread Eugeniu Rosca
Hello, Many thanks for your comments and involvement. On Sun, Jun 07, 2020 at 05:41:58AM +0300, Laurent Pinchart wrote: > On Fri, Jun 05, 2020 at 03:53:15PM +0200, Jacopo Mondi wrote: > > On Fri, Jun 05, 2020 at 03:41:24PM +0200, Eugeniu Rosca wrote: > > > On Fri, Jun 05, 2020 at 03:29:00PM

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-06 Thread Laurent Pinchart
Hello, On Fri, Jun 05, 2020 at 03:53:15PM +0200, Jacopo Mondi wrote: > On Fri, Jun 05, 2020 at 03:41:24PM +0200, Eugeniu Rosca wrote: > > On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > >> On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > >>> Could you kindly share

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Laurent Pinchart
On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > Hello Eugeniu, >sorry for the late reply > > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > > Hi Jacopo, > > > > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > 8<--- > > > > > * Testing >

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Jacopo Mondi
Hi Eugeniu On Fri, Jun 05, 2020 at 03:41:24PM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > > > Could you kindly share the cross compilation steps for your kmsxx fork?

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Eugeniu Rosca
Hi Jacopo, On Fri, Jun 05, 2020 at 03:29:00PM +0200, Jacopo Mondi wrote: > On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > > Could you kindly share the cross compilation steps for your kmsxx fork? > > I usually build it on the target :) Interesting approach. With ARM getting

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-06-05 Thread Jacopo Mondi
Hello Eugeniu, sorry for the late reply On Wed, May 27, 2020 at 09:15:55AM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > 8<--- > > > * Testing > > I have tested by injecting a color inversion LUT table and > >

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-05-27 Thread Eugeniu Rosca
Hi Geert, On Wed, May 27, 2020 at 09:34:30AM +0200, Geert Uytterhoeven wrote: > On Wed, May 27, 2020 at 9:16 AM Eugeniu Rosca wrote: > > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > > CMM functionalities are retained between suspend/resume cycles (tested > > > with > > >

RE: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-05-27 Thread Gotthard Voellmeke
...@in.bosch.com; Eugeniu Rosca Subject: Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM) Hi Eugeniu, On Wed, May 27, 2020 at 9:16 AM Eugeniu Rosca wrote: > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > CMM functionalities are retained between suspe

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-05-27 Thread Geert Uytterhoeven
Hi Eugeniu, On Wed, May 27, 2020 at 9:16 AM Eugeniu Rosca wrote: > On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: > > CMM functionalities are retained between suspend/resume cycles (tested with > > suspend-to-idle) without requiring a re-programming of the LUT tables. > > Hmm. Is

Re: [PATCH v5 0/8] drm: rcar-du: Add Color Management Module (CMM)

2020-05-27 Thread Eugeniu Rosca
Hi Jacopo, On Tue, Oct 15, 2019 at 12:46:13PM +0200, Jacopo Mondi wrote: 8<--- > * Testing > I have tested by injecting a color inversion LUT table and enabling/disabling > it > every 50 displayed frames: > https://jmondi.org/cgit/kmsxx/log/?h=gamma_lut Could you kindly share the cross