Re: [PATCH v5 07/14] qcom: spmi-gpio: add support for hierarchical IRQ chip

2019-01-18 Thread Marc Zyngier
On 18/01/2019 12:42, Brian Masney wrote: > Hi Marc, > > On Thu, Jan 17, 2019 at 11:32:01AM +, Marc Zyngier wrote: >>> static int pmic_gpio_to_irq(struct gpio_chip *chip, unsigned pin) >>> { >>> struct pmic_gpio_state *state = gpiochip_get_data(chip); >>> - struct pmic_gpio_pad *pad;

Re: [PATCH v5 07/14] qcom: spmi-gpio: add support for hierarchical IRQ chip

2019-01-18 Thread Brian Masney
Hi Marc, On Thu, Jan 17, 2019 at 11:32:01AM +, Marc Zyngier wrote: > > static int pmic_gpio_to_irq(struct gpio_chip *chip, unsigned pin) > > { > > struct pmic_gpio_state *state = gpiochip_get_data(chip); > > - struct pmic_gpio_pad *pad; > > + struct irq_fwspec fwspec; > > > > -

Re: [PATCH v5 07/14] qcom: spmi-gpio: add support for hierarchical IRQ chip

2019-01-17 Thread Marc Zyngier
On 17/01/2019 00:32, Brian Masney wrote: > spmi-gpio did not have any irqchip support so consumers of this in > device tree would need to call gpio[d]_to_irq() in order to get the > proper IRQ on the underlying PMIC. IRQ chips in device tree should > be usable from the start without the consumer