Thanks for giving feedback.
On 20 August 2014 19:10, Eric Dumazet wrote:
> Wouldnt it be faster to not use readl() at all here ?
On 22 August 2014 06:39, David Miller wrote:
> Like others I wonder why the existing descriptor value is being read
> at all.
It makes sense and I have verified,
Thanks for giving feedback.
On 20 August 2014 19:10, Eric Dumazet eric.duma...@gmail.com wrote:
Wouldnt it be faster to not use readl() at all here ?
On 22 August 2014 06:39, David Miller da...@davemloft.net wrote:
Like others I wonder why the existing descriptor value is being read
at all.
From: Jonas Jensen
Date: Wed, 20 Aug 2014 16:18:42 +0200
> @@ -348,7 +348,8 @@ static int moxart_mac_start_xmit(struct sk_buff *skb,
> struct net_device *ndev)
>
> txdes1 = readl(desc + TX_REG_OFFSET_DESC1);
> txdes1 |= TX_DESC1_LTS | TX_DESC1_FTS;
> - txdes1 &=
From: Jonas Jensen jonas.jen...@gmail.com
Date: Wed, 20 Aug 2014 16:18:42 +0200
@@ -348,7 +348,8 @@ static int moxart_mac_start_xmit(struct sk_buff *skb,
struct net_device *ndev)
txdes1 = readl(desc + TX_REG_OFFSET_DESC1);
txdes1 |= TX_DESC1_LTS | TX_DESC1_FTS;
- txdes1 =
On Wed, 2014-08-20 at 16:18 +0200, Jonas Jensen wrote:
> TX buffer length is not cleared on ndo_start_xmit().
> Failing to do so can bug/hang the controller and
> cause TX interrupts to stop altogether.
>
> diff --git a/drivers/net/ethernet/moxa/moxart_ether.c
>
On Wed, 2014-08-20 at 16:18 +0200, Jonas Jensen wrote:
TX buffer length is not cleared on ndo_start_xmit().
Failing to do so can bug/hang the controller and
cause TX interrupts to stop altogether.
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c
6 matches
Mail list logo
