Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi, Sorry, I hit another couple of bugs that originated from my hastebin patch - see below. On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan Support DRM out-fences by creating a sync_file with a fence for each CRTC that

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi, Sorry, I hit another couple of bugs that originated from my hastebin patch - see below. On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan Support DRM out-fences by creating a sync_file with a fence for each CRTC that sets the OUT_FENCE_PTR property.

Re: [PATCH v5 4/4] drm/fence: add out-fences support

2016-10-21 Daniel Vetter : > On Thu, Oct 20, 2016 at 10:15:20PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 20, 2016 at 07:34:44PM +0300, Ville Syrjälä wrote: > > > On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > > > > 2016-10-20 Ville Syrjälä

Re: [PATCH v5 4/4] drm/fence: add out-fences support

2016-10-21 Daniel Vetter : > On Thu, Oct 20, 2016 at 10:15:20PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 20, 2016 at 07:34:44PM +0300, Ville Syrjälä wrote: > > > On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > > > > 2016-10-20 Ville Syrjälä : > > > > > > > > > On Thu, Oct

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Fri, Oct 21, 2016 at 11:55:52AM +0100, Brian Starkey wrote: > On Thu, Oct 20, 2016 at 06:30:17PM -0200, Gustavo Padovan wrote: > > 2016-10-20 Brian Starkey : > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > > > index 657a33a..b898604 100644 > > > >

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Fri, Oct 21, 2016 at 11:55:52AM +0100, Brian Starkey wrote: > On Thu, Oct 20, 2016 at 06:30:17PM -0200, Gustavo Padovan wrote: > > 2016-10-20 Brian Starkey : > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > > > index 657a33a..b898604 100644 > > > > ---

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 10:15:20PM +0300, Ville Syrjälä wrote: > On Thu, Oct 20, 2016 at 07:34:44PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > > > 2016-10-20 Ville Syrjälä : > > > > > > > On Thu, Oct 20, 2016

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 10:15:20PM +0300, Ville Syrjälä wrote: > On Thu, Oct 20, 2016 at 07:34:44PM +0300, Ville Syrjälä wrote: > > On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > > > 2016-10-20 Ville Syrjälä : > > > > > > > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi Gustavo, On Thu, Oct 20, 2016 at 06:30:17PM -0200, Gustavo Padovan wrote: Hi Brian, 2016-10-20 Brian Starkey : Hi Gustavo, I notice your branch has the sync_file refcount change in, but this doesn't seem to take account for that. Will you be dropping that change to

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi Gustavo, On Thu, Oct 20, 2016 at 06:30:17PM -0200, Gustavo Padovan wrote: Hi Brian, 2016-10-20 Brian Starkey : Hi Gustavo, I notice your branch has the sync_file refcount change in, but this doesn't seem to take account for that. Will you be dropping that change to match the semantics of

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi Brian, 2016-10-20 Brian Starkey : > Hi Gustavo, > > I notice your branch has the sync_file refcount change in, but this > doesn't seem to take account for that. Will you be dropping that > change to match the semantics of fence_array? I will drop the fence_get() in

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi Brian, 2016-10-20 Brian Starkey : > Hi Gustavo, > > I notice your branch has the sync_file refcount change in, but this > doesn't seem to take account for that. Will you be dropping that > change to match the semantics of fence_array? I will drop the fence_get() in the out-fence patch

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 07:34:44PM +0300, Ville Syrjälä wrote: > On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > > 2016-10-20 Ville Syrjälä : > > > > > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > > > > From: Gustavo Padovan

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 07:34:44PM +0300, Ville Syrjälä wrote: > On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > > 2016-10-20 Ville Syrjälä : > > > > > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > > > > From: Gustavo Padovan > > > > > > > > Support DRM

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi Gustavo, I notice your branch has the sync_file refcount change in, but this doesn't seem to take account for that. Will you be dropping that change to match the semantics of fence_array? Couple more comments below. On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: From:

Re: [PATCH v5 4/4] drm/fence: add out-fences support

Hi Gustavo, I notice your branch has the sync_file refcount change in, but this doesn't seem to take account for that. Will you be dropping that change to match the semantics of fence_array? Couple more comments below. On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: From:

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > 2016-10-20 Ville Syrjälä : > > > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Support DRM out-fences by

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 01:55:38PM -0200, Gustavo Padovan wrote: > 2016-10-20 Ville Syrjälä : > > > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > > > that sets

Re: [PATCH v5 4/4] drm/fence: add out-fences support

2016-10-20 Ville Syrjälä : > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > > that sets the

Re: [PATCH v5 4/4] drm/fence: add out-fences support

2016-10-20 Ville Syrjälä : > On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > > that sets the OUT_FENCE_PTR property. > > I still maintain the out fence should also be

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > that sets the OUT_FENCE_PTR property. I still maintain the out fence should also be per fb

Re: [PATCH v5 4/4] drm/fence: add out-fences support

On Thu, Oct 20, 2016 at 12:50:05PM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > Support DRM out-fences by creating a sync_file with a fence for each CRTC > that sets the OUT_FENCE_PTR property. I still maintain the out fence should also be per fb (well, per plane since we can't add