Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread Felipe Balbi
On Mon, Aug 06, 2012 at 03:14:42PM +0530, ABRAHAM, KISHON VIJAY wrote: > >> >> +static int omap_usb2_runtime_resume(struct device *dev) > >> >> +{ > >> >> + u32 ret = 0; > >> >> + struct platform_device *pdev = to_platform_device(dev); > >> >> + struct omap_usb *phy =

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread ABRAHAM, KISHON VIJAY
Hi Felipe, On Mon, Aug 6, 2012 at 2:19 PM, Felipe Balbi wrote: > Hi, > > On Fri, Aug 03, 2012 at 08:01:44PM +0530, ABRAHAM, KISHON VIJAY wrote: >> >> + return 0; >> >> +} >> >> + >> >> +#ifdef CONFIG_PM_RUNTIME >> >> + >> >> +static int omap_usb2_runtime_suspend(struct device *dev) >> >> +{

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread Felipe Balbi
Hi, On Fri, Aug 03, 2012 at 08:01:44PM +0530, ABRAHAM, KISHON VIJAY wrote: > >> + return 0; > >> +} > >> + > >> +#ifdef CONFIG_PM_RUNTIME > >> + > >> +static int omap_usb2_runtime_suspend(struct device *dev) > >> +{ > >> + struct platform_device *pdev = to_platform_device(dev); > >> +

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread Felipe Balbi
Hi, On Fri, Aug 03, 2012 at 08:01:44PM +0530, ABRAHAM, KISHON VIJAY wrote: + return 0; +} + +#ifdef CONFIG_PM_RUNTIME + +static int omap_usb2_runtime_suspend(struct device *dev) +{ + struct platform_device *pdev = to_platform_device(dev); + struct omap_usb *phy =

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread ABRAHAM, KISHON VIJAY
Hi Felipe, On Mon, Aug 6, 2012 at 2:19 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Fri, Aug 03, 2012 at 08:01:44PM +0530, ABRAHAM, KISHON VIJAY wrote: + return 0; +} + +#ifdef CONFIG_PM_RUNTIME + +static int omap_usb2_runtime_suspend(struct device *dev) +{ + struct

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-06 Thread Felipe Balbi
On Mon, Aug 06, 2012 at 03:14:42PM +0530, ABRAHAM, KISHON VIJAY wrote: +static int omap_usb2_runtime_resume(struct device *dev) +{ + u32 ret = 0; + struct platform_device *pdev = to_platform_device(dev); + struct omap_usb *phy = platform_get_drvdata(pdev); + +

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:57 PM, Felipe Balbi wrote: > On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: >> All phy related programming like enabling/disabling the clocks, powering >> on/off the phy is taken care of by this driver. It is also used for OTG >> related

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread Felipe Balbi
On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: > All phy related programming like enabling/disabling the clocks, powering > on/off the phy is taken care of by this driver. It is also used for OTG > related functionality like srp. > > This also includes device tree support

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread Felipe Balbi
On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:57 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 03:16 PM, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: >> On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >>> + writel(~PHY_PD, phy->control_dev); >>> + /* XXX: add proper

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: > On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >> + writel(~PHY_PD, phy->control_dev); >> + /* XXX: add proper documentation for this delay */ >> + mdelay(200);

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: > + writel(~PHY_PD, phy->control_dev); > + /* XXX: add proper documentation for this delay */ > + mdelay(200); Do you need this to be busy? -- To unsubscribe from this list:

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: + writel(~PHY_PD, phy-control_dev); + /* XXX: add proper documentation for this delay */ + mdelay(200); Do you need this to be busy? -- To unsubscribe from this list: send

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti shubhrajy...@ti.com wrote: On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: + writel(~PHY_PD, phy-control_dev); + /* XXX: add proper documentation for this delay */ +

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 03:16 PM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti shubhrajy...@ti.com wrote: On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: + writel(~PHY_PD, phy-control_dev); + /* XXX: add