Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 5:17 AM Al Viro wrote: > > On Tue, Oct 22, 2019 at 12:26:09PM +0200, Arnd Bergmann wrote: > > On Tue, Oct 22, 2019 at 6:34 AM Al Viro wrote: > > > > > > On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > > > > Each of these drivers has a copy of the same

Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

2019-10-22 Thread Al Viro
On Tue, Oct 22, 2019 at 12:26:09PM +0200, Arnd Bergmann wrote: > On Tue, Oct 22, 2019 at 6:34 AM Al Viro wrote: > > > > On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > > > Each of these drivers has a copy of the same trivial helper function to > > > convert the pointer argument

Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

2019-10-22 Thread Arnd Bergmann
On Tue, Oct 22, 2019 at 6:34 AM Al Viro wrote: > > On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > > Each of these drivers has a copy of the same trivial helper function to > > convert the pointer argument and then call the native ioctl handler. > > > > We now have a generic

Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

2019-10-21 Thread Al Viro
On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. I'd rather flipped your #7

Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

2019-10-14 Thread Jarkko Sakkinen
On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > Each of these drivers has a copy of the same trivial helper function to > convert the pointer argument and then call the native ioctl handler. > > We now have a generic implementation of that, so use it. > > Acked-by: Greg