Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-30 Thread Hemant Kumar
Hi Loic, On 9/22/20 4:10 AM, Loic Poulain wrote: Hi Hemant, See comments inline, but globally, the locking and ref counting is more complicated than it should be. On Wed, 16 Sep 2020 at 21:57, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-23 Thread Hemant Kumar
Hi Jeff, On 9/18/20 1:08 PM, Jeffrey Hugo wrote: On 9/16/2020 1:56 PM, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Device file node is created with format /dev/mhi__ Currently it supports

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-22 Thread Loic Poulain
Hi Hemant, See comments inline, but globally, the locking and ref counting is more complicated than it should be. On Wed, 16 Sep 2020 at 21:57, Hemant Kumar wrote: > > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-19 Thread Greg KH
On Fri, Sep 18, 2020 at 11:14:08AM -0700, Hemant Kumar wrote: > Hi Greg, > > On 9/17/20 9:44 AM, Greg KH wrote: > > On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote: > ... > ... > > > + > > > +static int mhi_uci_open(struct inode *inode, struct file *filp) > > > +{ > > > + struct

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-18 Thread Jeffrey Hugo
On 9/16/2020 1:56 PM, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Device file node is created with format /dev/mhi__ Currently it supports LOOPBACK channel. Signed-off-by: Hemant Kumar

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-18 Thread Hemant Kumar
Hi Greg, On 9/17/20 9:44 AM, Greg KH wrote: On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote: ... ... + +static int mhi_uci_open(struct inode *inode, struct file *filp) +{ + struct uci_dev *udev = NULL; + unsigned int minor = iminor(inode); + int ret = -EIO; +

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-18 Thread Hemant Kumar
Hi Greg, On 9/17/20 9:40 AM, Greg KH wrote: On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote: +/** + * struct uci_dev - MHI uci device + * @minor: uci device node minor number + * @mhi_dev: associated mhi device object + * @chan: MHI channel name + * @lock: mutex lock + * @ul_chan:

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-17 Thread Greg KH
On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote: > This MHI client driver allows userspace clients to transfer > raw data between MHI device and host using standard file operations. > Device file node is created with format > > /dev/mhi__ > > Currently it supports LOOPBACK channel.

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-17 Thread Greg KH
On Wed, Sep 16, 2020 at 12:56:07PM -0700, Hemant Kumar wrote: > +/** > + * struct uci_dev - MHI uci device > + * @minor: uci device node minor number > + * @mhi_dev: associated mhi device object > + * @chan: MHI channel name > + * @lock: mutex lock > + * @ul_chan: uplink uci channel object > + *

Re: [PATCH v6 4/4] bus: mhi: Add userspace client interface driver

2020-09-16 Thread Randy Dunlap
On 9/16/20 12:56 PM, Hemant Kumar wrote: > diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig > index 6a217ff..8aebe8b 100644 > --- a/drivers/bus/mhi/Kconfig > +++ b/drivers/bus/mhi/Kconfig > @@ -20,3 +20,16 @@ config MHI_BUS_DEBUG >Enable debugfs support for use with the MHI