Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-08 Thread Pavel Tatashin
> > IMO, we already have a message by > > mark_tsc_unstable("boot parameter notsc"); > > and we will use 'notsc' in case of CONFIG_X86_TSC = no > > So, I guess there is no need to print this msg. > OK, removed the warning.

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-08 Thread Pavel Tatashin
> > IMO, we already have a message by > > mark_tsc_unstable("boot parameter notsc"); > > and we will use 'notsc' in case of CONFIG_X86_TSC = no > > So, I guess there is no need to print this msg. > OK, removed the warning.

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-08 Thread Dou Liyang
Hi Pavel, At 11/03/2017 10:23 PM, Pavel Tatashin wrote: Hi Dou, Sure, I can remove the warning, but I think we should print something that is indicating that notsc is not a good parameter anymore: i.e tsc=unstable is better. Perhaps something like: "Kernel parameter \'notsc\' is deprecated,

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-08 Thread Dou Liyang
Hi Pavel, At 11/03/2017 10:23 PM, Pavel Tatashin wrote: Hi Dou, Sure, I can remove the warning, but I think we should print something that is indicating that notsc is not a good parameter anymore: i.e tsc=unstable is better. Perhaps something like: "Kernel parameter \'notsc\' is deprecated,

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-03 Thread Pavel Tatashin
Hi Dou, Sure, I can remove the warning, but I think we should print something that is indicating that notsc is not a good parameter anymore: i.e tsc=unstable is better. Perhaps something like: "Kernel parameter \'notsc\' is deprecated, please use \'tsc=unstable\' instead" ? Pasha On Thu, Nov

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-03 Thread Pavel Tatashin
Hi Dou, Sure, I can remove the warning, but I think we should print something that is indicating that notsc is not a good parameter anymore: i.e tsc=unstable is better. Perhaps something like: "Kernel parameter \'notsc\' is deprecated, please use \'tsc=unstable\' instead" ? Pasha On Thu, Nov

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-02 Thread Dou Liyang
Hi Pavel, At 11/03/2017 01:26 AM, Pavel Tatashin wrote: tsc_disabled is set when notsc is passed as kernel parameter. The reason we have notsc is to avoid timing problems on multi-preccors systems. However, we already have a mechanism to detect and resolve these issues by invoking tsc unstable

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-02 Thread Dou Liyang
Hi Pavel, At 11/03/2017 01:26 AM, Pavel Tatashin wrote: tsc_disabled is set when notsc is passed as kernel parameter. The reason we have notsc is to avoid timing problems on multi-preccors systems. However, we already have a mechanism to detect and resolve these issues by invoking tsc unstable