Re: [PATCH v8 02/13] iommu/amd: add several helper functions

2017-07-31 Thread Joerg Roedel
Hi Baoquan, On Mon, Jul 31, 2017 at 06:01:11PM +0800, Baoquan He wrote: > I found the event log related handling functions all take > xxx_event_buffer names, like: > alloc_event_buffer() > iommu_enable_event_buffer() > free_event_buffer() > > So for consistency, I plan to still use iommu_disable_

Re: [PATCH v8 02/13] iommu/amd: add several helper functions

2017-07-31 Thread Baoquan He
Hi Joerg, On 07/27/17 at 05:06pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:00PM +0800, Baoquan He wrote: > > Move single iommu enabling codes into a wrapper function > > early_enable_iommu(). > > This can make later kdump change easier. > > > > And also add iommu_disable_command_buffe

Re: [PATCH v8 02/13] iommu/amd: add several helper functions

2017-07-27 Thread Baoquan He
On 07/27/17 at 05:06pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:00PM +0800, Baoquan He wrote: > > Move single iommu enabling codes into a wrapper function > > early_enable_iommu(). > > This can make later kdump change easier. > > > > And also add iommu_disable_command_buffer and iommu

Re: [PATCH v8 02/13] iommu/amd: add several helper functions

2017-07-27 Thread Joerg Roedel
On Fri, Jul 21, 2017 at 04:59:00PM +0800, Baoquan He wrote: > Move single iommu enabling codes into a wrapper function early_enable_iommu(). > This can make later kdump change easier. > > And also add iommu_disable_command_buffer and iommu_disable_event_buffer > for later usage. > > Signed-off-by