Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Waiman Long
On 01/21/2014 10:41 AM, Peter Zijlstra wrote: On Tue, Jan 21, 2014 at 10:02:06AM -0500, Waiman Long wrote: My latest v9 series of qrwlock patch will automatically adapt to the lack of atomic byte access by using an atomic integer instruction instead. So the new series should work for pre-EV56

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Peter Zijlstra
On Tue, Jan 21, 2014 at 10:02:06AM -0500, Waiman Long wrote: > My latest v9 series of qrwlock patch will automatically adapt to the lack of > atomic byte access by using an atomic integer instruction instead. So the > new series should work for pre-EV56 Alpha, it is just a bit less efficient > in

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Waiman Long
On 01/19/2014 03:04 AM, Paul E. McKenney wrote: On Sat, Jan 18, 2014 at 04:57:05PM -0800, Linus Torvalds wrote: On Sat, Jan 18, 2014 at 1:22 PM, Paul E. McKenney wrote: Yes, this requires that -all- updates to the fields in the machine word in question use atomic rmw. Which would not be

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Waiman Long
On 01/19/2014 03:04 AM, Paul E. McKenney wrote: On Sat, Jan 18, 2014 at 04:57:05PM -0800, Linus Torvalds wrote: On Sat, Jan 18, 2014 at 1:22 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Yes, this requires that -all- updates to the fields in the machine word in question use atomic

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Peter Zijlstra
On Tue, Jan 21, 2014 at 10:02:06AM -0500, Waiman Long wrote: My latest v9 series of qrwlock patch will automatically adapt to the lack of atomic byte access by using an atomic integer instruction instead. So the new series should work for pre-EV56 Alpha, it is just a bit less efficient in this

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-21 Thread Waiman Long
On 01/21/2014 10:41 AM, Peter Zijlstra wrote: On Tue, Jan 21, 2014 at 10:02:06AM -0500, Waiman Long wrote: My latest v9 series of qrwlock patch will automatically adapt to the lack of atomic byte access by using an atomic integer instruction instead. So the new series should work for pre-EV56

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Paul E. McKenney
On Sun, Jan 19, 2014 at 11:56:02AM -0800, Linus Torvalds wrote: > On Sun, Jan 19, 2014 at 12:04 AM, Paul E. McKenney > wrote: > > > > OK, another approach would be to never add "select ARCH_USE_QUEUE_RWLOCK" > > on Alpha, at least if the queued rwlocks really do want to atomically > > manipulate

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Linus Torvalds
On Sun, Jan 19, 2014 at 12:04 AM, Paul E. McKenney wrote: > > OK, another approach would be to never add "select ARCH_USE_QUEUE_RWLOCK" > on Alpha, at least if the queued rwlocks really do want to atomically > manipulate bytes. After all, the Alpha systems that I know about don't > have enough

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Paul E. McKenney
On Sat, Jan 18, 2014 at 04:57:05PM -0800, Linus Torvalds wrote: > On Sat, Jan 18, 2014 at 1:22 PM, Paul E. McKenney > wrote: > > > > Yes, this requires that -all- updates to the fields in the machine word > > in question use atomic rmw. Which would not be pretty from a core-code > > perspective.

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Paul E. McKenney
On Sat, Jan 18, 2014 at 04:57:05PM -0800, Linus Torvalds wrote: On Sat, Jan 18, 2014 at 1:22 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Yes, this requires that -all- updates to the fields in the machine word in question use atomic rmw. Which would not be pretty from a

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Linus Torvalds
On Sun, Jan 19, 2014 at 12:04 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: OK, another approach would be to never add select ARCH_USE_QUEUE_RWLOCK on Alpha, at least if the queued rwlocks really do want to atomically manipulate bytes. After all, the Alpha systems that I know about

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-19 Thread Paul E. McKenney
On Sun, Jan 19, 2014 at 11:56:02AM -0800, Linus Torvalds wrote: On Sun, Jan 19, 2014 at 12:04 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: OK, another approach would be to never add select ARCH_USE_QUEUE_RWLOCK on Alpha, at least if the queued rwlocks really do want to atomically

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Linus Torvalds
On Sat, Jan 18, 2014 at 1:22 PM, Paul E. McKenney wrote: > > Yes, this requires that -all- updates to the fields in the machine word > in question use atomic rmw. Which would not be pretty from a core-code > perspective. Hence my suggestion of ceasing Linux-kernel support for > DEC Alpha CPUs

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Paul E. McKenney
On Sat, Jan 18, 2014 at 01:41:36PM +0100, Peter Zijlstra wrote: > On Sat, Jan 18, 2014 at 04:25:48AM -0800, Paul E. McKenney wrote: > > On Sat, Jan 18, 2014 at 12:34:06PM +0100, Peter Zijlstra wrote: > > > On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: > > > > OK, I will bite...

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Peter Zijlstra
On Sat, Jan 18, 2014 at 04:25:48AM -0800, Paul E. McKenney wrote: > On Sat, Jan 18, 2014 at 12:34:06PM +0100, Peter Zijlstra wrote: > > On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: > > > OK, I will bite... Aside from fine-grained code timing, what code could > > > you write

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Paul E. McKenney
On Sat, Jan 18, 2014 at 12:34:06PM +0100, Peter Zijlstra wrote: > On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: > > OK, I will bite... Aside from fine-grained code timing, what code could > > you write to tell the difference between a real one-byte store and an > > RMW

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Peter Zijlstra
On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: > OK, I will bite... Aside from fine-grained code timing, what code could > you write to tell the difference between a real one-byte store and an > RMW emulating that store? Why isn't fine-grained code timing an issue? I'm sure

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Paul E. McKenney
On Thu, Jan 16, 2014 at 11:36:59AM +0100, Peter Zijlstra wrote: > On Thu, Jan 16, 2014 at 06:39:23AM +0700, Linus Torvalds wrote: > > On Jan 16, 2014 6:22 AM, "Peter Zijlstra" wrote: > > > > > > So while the primitive is called smp_store_release() the !SMP variant > > > still does: > > > > > >

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Paul E. McKenney
On Thu, Jan 16, 2014 at 11:36:59AM +0100, Peter Zijlstra wrote: On Thu, Jan 16, 2014 at 06:39:23AM +0700, Linus Torvalds wrote: On Jan 16, 2014 6:22 AM, Peter Zijlstra pet...@infradead.org wrote: So while the primitive is called smp_store_release() the !SMP variant still does:

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Peter Zijlstra
On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: OK, I will bite... Aside from fine-grained code timing, what code could you write to tell the difference between a real one-byte store and an RMW emulating that store? Why isn't fine-grained code timing an issue? I'm sure Alpha

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Paul E. McKenney
On Sat, Jan 18, 2014 at 12:34:06PM +0100, Peter Zijlstra wrote: On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: OK, I will bite... Aside from fine-grained code timing, what code could you write to tell the difference between a real one-byte store and an RMW emulating that

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Peter Zijlstra
On Sat, Jan 18, 2014 at 04:25:48AM -0800, Paul E. McKenney wrote: On Sat, Jan 18, 2014 at 12:34:06PM +0100, Peter Zijlstra wrote: On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: OK, I will bite... Aside from fine-grained code timing, what code could you write to tell

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Paul E. McKenney
On Sat, Jan 18, 2014 at 01:41:36PM +0100, Peter Zijlstra wrote: On Sat, Jan 18, 2014 at 04:25:48AM -0800, Paul E. McKenney wrote: On Sat, Jan 18, 2014 at 12:34:06PM +0100, Peter Zijlstra wrote: On Sat, Jan 18, 2014 at 02:01:05AM -0800, Paul E. McKenney wrote: OK, I will bite... Aside

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-18 Thread Linus Torvalds
On Sat, Jan 18, 2014 at 1:22 PM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Yes, this requires that -all- updates to the fields in the machine word in question use atomic rmw. Which would not be pretty from a core-code perspective. Hence my suggestion of ceasing Linux-kernel support

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-16 Thread Peter Zijlstra
On Thu, Jan 16, 2014 at 06:39:23AM +0700, Linus Torvalds wrote: > On Jan 16, 2014 6:22 AM, "Peter Zijlstra" wrote: > > > > So while the primitive is called smp_store_release() the !SMP variant > > still does: > > > > *(volatile __type *) = ptr; > > > > which should not compile on any Alpha pre

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-16 Thread Peter Zijlstra
On Thu, Jan 16, 2014 at 06:39:23AM +0700, Linus Torvalds wrote: On Jan 16, 2014 6:22 AM, Peter Zijlstra pet...@infradead.org wrote: So while the primitive is called smp_store_release() the !SMP variant still does: *(volatile __type *) = ptr; which should not compile on any Alpha

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-15 Thread Peter Zijlstra
On Wed, Jan 15, 2014 at 12:53:46PM -0800, Paul E. McKenney wrote: > But we did drop support for SMP i386 quite some time ago, so perhaps > it is time to drop support for SMP Alpha pre-EV56. So while the primitive is called smp_store_release() the !SMP variant still does: *(volatile __type *)

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-15 Thread Paul E. McKenney
On Wed, Jan 15, 2014 at 09:07:53AM +0100, Peter Zijlstra wrote: > On Tue, Jan 14, 2014 at 06:39:58PM -0800, Paul E. McKenney wrote: > > > If you just want to do a store release, on alpha you'd want to > > > implement that as a full memory barrier followed by a store. It > > > doesn't get the

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-15 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 06:39:58PM -0800, Paul E. McKenney wrote: > > If you just want to do a store release, on alpha you'd want to > > implement that as a full memory barrier followed by a store. It > > doesn't get the advantage of a real release consistency model, but at > > least it's not

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-15 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 06:39:58PM -0800, Paul E. McKenney wrote: If you just want to do a store release, on alpha you'd want to implement that as a full memory barrier followed by a store. It doesn't get the advantage of a real release consistency model, but at least it's not doing an

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-15 Thread Paul E. McKenney
On Wed, Jan 15, 2014 at 09:07:53AM +0100, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 06:39:58PM -0800, Paul E. McKenney wrote: If you just want to do a store release, on alpha you'd want to implement that as a full memory barrier followed by a store. It doesn't get the advantage of a

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-15 Thread Peter Zijlstra
On Wed, Jan 15, 2014 at 12:53:46PM -0800, Paul E. McKenney wrote: But we did drop support for SMP i386 quite some time ago, so perhaps it is time to drop support for SMP Alpha pre-EV56. So while the primitive is called smp_store_release() the !SMP variant still does: *(volatile __type *) =

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Daniel J Blueman
On 01/15/2014 07:44 AM, Paul E. McKenney wrote: On Tue, Jan 14, 2014 at 10:01:04AM -0800, Richard Henderson wrote: On 01/14/2014 09:08 AM, Matt Turner wrote: On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Paul E. McKenney
On Wed, Jan 15, 2014 at 07:25:04AM +0700, Linus Torvalds wrote: > On Wed, Jan 15, 2014 at 6:44 AM, Paul E. McKenney > wrote: > > > > Which means that Alpha should be able to similarly emulate 1-byte and > > 2-byte atomics, correct? > > Not reasonably, no. > > The ldl/stc implementation on early

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Linus Torvalds
On Wed, Jan 15, 2014 at 6:44 AM, Paul E. McKenney wrote: > > Which means that Alpha should be able to similarly emulate 1-byte and > 2-byte atomics, correct? Not reasonably, no. The ldl/stc implementation on early alpha was so broken as to be unusable. It's not actually done in the cache, it

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Paul E. McKenney
On Tue, Jan 14, 2014 at 10:01:04AM -0800, Richard Henderson wrote: > On 01/14/2014 09:08 AM, Matt Turner wrote: > > On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra > > wrote: > >> On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: > Peter, > > I found out that the

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 02:09:30PM -0500, Waiman Long wrote: > I would like to know if the action of writing out a byte (e.g. *byte = 0) is > atomic in those architectures or is emulated by a compiler-generated > software read-modify-write. So on Alpha pre ev56 something like: *(volatile u8

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Waiman Long
On 01/14/2014 01:01 PM, Richard Henderson wrote: On 01/14/2014 09:08 AM, Matt Turner wrote: On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Richard Henderson
On 01/14/2014 09:08 AM, Matt Turner wrote: > On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra wrote: >> On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the __native_word() macro (used

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Matt Turner
On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra wrote: > On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: >> >Peter, >> > >> >I found out that the build failure was caused by the fact that the >> >__native_word() macro (used internally by compiletime_assert_atomic()) >> >allows

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Waiman Long
On 01/14/2014 06:03 AM, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the __native_word() macro (used internally by compiletime_assert_atomic()) allows only a size of 4 or 8 for

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: > >Peter, > > > >I found out that the build failure was caused by the fact that the > >__native_word() macro (used internally by compiletime_assert_atomic()) > >allows only a size of 4 or 8 for x86-64. The data type that I used is a

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the __native_word() macro (used internally by compiletime_assert_atomic()) allows only a size of 4 or 8 for x86-64. The data type that I used is a byte. Is

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Waiman Long
On 01/14/2014 06:03 AM, Peter Zijlstra wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the __native_word() macro (used internally by compiletime_assert_atomic()) allows only a size of 4 or 8 for

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Matt Turner
On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the __native_word() macro (used internally by compiletime_assert_atomic())

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Richard Henderson
On 01/14/2014 09:08 AM, Matt Turner wrote: On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by the fact that the __native_word() macro (used

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Waiman Long
On 01/14/2014 01:01 PM, Richard Henderson wrote: On 01/14/2014 09:08 AM, Matt Turner wrote: On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstrapet...@infradead.org wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the build failure was caused by

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Peter Zijlstra
On Tue, Jan 14, 2014 at 02:09:30PM -0500, Waiman Long wrote: I would like to know if the action of writing out a byte (e.g. *byte = 0) is atomic in those architectures or is emulated by a compiler-generated software read-modify-write. So on Alpha pre ev56 something like: *(volatile u8 *)foo

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Paul E. McKenney
On Tue, Jan 14, 2014 at 10:01:04AM -0800, Richard Henderson wrote: On 01/14/2014 09:08 AM, Matt Turner wrote: On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman wrote: Peter, I found out that the

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Linus Torvalds
On Wed, Jan 15, 2014 at 6:44 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Which means that Alpha should be able to similarly emulate 1-byte and 2-byte atomics, correct? Not reasonably, no. The ldl/stc implementation on early alpha was so broken as to be unusable. It's not actually

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Paul E. McKenney
On Wed, Jan 15, 2014 at 07:25:04AM +0700, Linus Torvalds wrote: On Wed, Jan 15, 2014 at 6:44 AM, Paul E. McKenney paul...@linux.vnet.ibm.com wrote: Which means that Alpha should be able to similarly emulate 1-byte and 2-byte atomics, correct? Not reasonably, no. The ldl/stc

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-14 Thread Daniel J Blueman
On 01/15/2014 07:44 AM, Paul E. McKenney wrote: On Tue, Jan 14, 2014 at 10:01:04AM -0800, Richard Henderson wrote: On 01/14/2014 09:08 AM, Matt Turner wrote: On Tue, Jan 14, 2014 at 3:03 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Jan 14, 2014 at 10:28:23AM +0800, Daniel J Blueman

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-13 Thread Daniel J Blueman
On 14/01/2014 00:41, Waiman Long wrote: On 01/12/2014 09:47 PM, Daniel J Blueman wrote: On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: > This patch modifies the queue_write_unlock() function to use the > new smp_store_release() function in another pending patch. It also >

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-13 Thread Waiman Long
On 01/12/2014 09:47 PM, Daniel J Blueman wrote: On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: > This patch modifies the queue_write_unlock() function to use the > new smp_store_release() function in another pending patch. It also > removes the temporary implementation of

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-13 Thread Waiman Long
On 01/12/2014 09:47 PM, Daniel J Blueman wrote: On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function in another pending patch. It also removes the temporary implementation of

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-13 Thread Daniel J Blueman
On 14/01/2014 00:41, Waiman Long wrote: On 01/12/2014 09:47 PM, Daniel J Blueman wrote: On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function in another pending patch. It also removes

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-12 Thread Paul E. McKenney
On Mon, Jan 13, 2014 at 10:47:36AM +0800, Daniel J Blueman wrote: > On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: > > This patch modifies the queue_write_unlock() function to use the > > new smp_store_release() function in another pending patch. It also > > removes the temporary

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-12 Thread Daniel J Blueman
On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: > This patch modifies the queue_write_unlock() function to use the > new smp_store_release() function in another pending patch. It also > removes the temporary implementation of smp_load_acquire() and > smp_store_release() function

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-12 Thread Daniel J Blueman
On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function in another pending patch. It also removes the temporary implementation of smp_load_acquire() and smp_store_release() function in

Re: [PATCH v8 4/4] qrwlock: Use smp_store_release() in write_unlock()

2014-01-12 Thread Paul E. McKenney
On Mon, Jan 13, 2014 at 10:47:36AM +0800, Daniel J Blueman wrote: On Thursday, 9 January 2014 01:10:03 UTC+8, Waiman Long wrote: This patch modifies the queue_write_unlock() function to use the new smp_store_release() function in another pending patch. It also removes the temporary