Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-11 Thread Eric Auger
On 03/11/2015 03:24 PM, Christoffer Dall wrote: > On Thu, Mar 05, 2015 at 12:27:42PM +0100, Paolo Bonzini wrote: >> >> >> On 05/03/2015 11:53, Marc Zyngier wrote: +#ifdef CONFIG_HAVE_KVM_IRQFD + case KVM_CAP_IRQFD: + r = vgic_present; + break; +#endif

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-11 Thread Christoffer Dall
On Thu, Mar 05, 2015 at 12:27:42PM +0100, Paolo Bonzini wrote: > > > On 05/03/2015 11:53, Marc Zyngier wrote: > > > +#ifdef CONFIG_HAVE_KVM_IRQFD > > > + case KVM_CAP_IRQFD: > > > + r = vgic_present; > > > + break; > > > +#endif > > > > Nitpick: we have "select HAVE_KVM_IRQFD",

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-11 Thread Eric Auger
On 03/11/2015 03:24 PM, Christoffer Dall wrote: On Thu, Mar 05, 2015 at 12:27:42PM +0100, Paolo Bonzini wrote: On 05/03/2015 11:53, Marc Zyngier wrote: +#ifdef CONFIG_HAVE_KVM_IRQFD + case KVM_CAP_IRQFD: + r = vgic_present; + break; +#endif Nitpick: we have select

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-11 Thread Christoffer Dall
On Thu, Mar 05, 2015 at 12:27:42PM +0100, Paolo Bonzini wrote: On 05/03/2015 11:53, Marc Zyngier wrote: +#ifdef CONFIG_HAVE_KVM_IRQFD + case KVM_CAP_IRQFD: + r = vgic_present; + break; +#endif Nitpick: we have select HAVE_KVM_IRQFD, so we can lose the

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 05/03/15 14:26, Eric Auger wrote: > On 03/05/2015 03:20 PM, Marc Zyngier wrote: >> On 05/03/15 14:04, Eric Auger wrote: >>> Hi Marc, >>> On 03/05/2015 11:53 AM, Marc Zyngier wrote: On 04/03/15 10:14, Eric Auger wrote: > This patch enables irqfd on arm/arm64. > > Both irqfd and

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Eric Auger
On 03/05/2015 03:20 PM, Marc Zyngier wrote: > On 05/03/15 14:04, Eric Auger wrote: >> Hi Marc, >> On 03/05/2015 11:53 AM, Marc Zyngier wrote: >>> On 04/03/15 10:14, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 05/03/15 14:04, Eric Auger wrote: > Hi Marc, > On 03/05/2015 11:53 AM, Marc Zyngier wrote: >> On 04/03/15 10:14, Eric Auger wrote: >>> This patch enables irqfd on arm/arm64. >>> >>> Both irqfd and resamplefd are supported. Injection is implemented >>> in vgic.c without routing. >>> >>> This

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Eric Auger
Hi Marc, On 03/05/2015 11:53 AM, Marc Zyngier wrote: > On 04/03/15 10:14, Eric Auger wrote: >> This patch enables irqfd on arm/arm64. >> >> Both irqfd and resamplefd are supported. Injection is implemented >> in vgic.c without routing. >> >> This patch enables CONFIG_HAVE_KVM_EVENTFD and

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 05/03/15 11:27, Paolo Bonzini wrote: > > > On 05/03/2015 11:53, Marc Zyngier wrote: >>> +#ifdef CONFIG_HAVE_KVM_IRQFD >>> + case KVM_CAP_IRQFD: >>> + r = vgic_present; >>> + break; >>> +#endif >> >> Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery.

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Paolo Bonzini
On 05/03/2015 11:53, Marc Zyngier wrote: > > +#ifdef CONFIG_HAVE_KVM_IRQFD > > + case KVM_CAP_IRQFD: > > + r = vgic_present; > > + break; > > +#endif > > Nitpick: we have "select HAVE_KVM_IRQFD", so we can lose the #ifdef-ery. Alternatively, I've just posted a patch to

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 04/03/15 10:14, Eric Auger wrote: > This patch enables irqfd on arm/arm64. > > Both irqfd and resamplefd are supported. Injection is implemented > in vgic.c without routing. > > This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD. > > KVM_CAP_IRQFD is now advertised.

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Eric Auger
Hi Marc, On 03/05/2015 11:53 AM, Marc Zyngier wrote: On 04/03/15 10:14, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD.

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Paolo Bonzini
On 05/03/2015 11:53, Marc Zyngier wrote: +#ifdef CONFIG_HAVE_KVM_IRQFD + case KVM_CAP_IRQFD: + r = vgic_present; + break; +#endif Nitpick: we have select HAVE_KVM_IRQFD, so we can lose the #ifdef-ery. Alternatively, I've just posted a patch to move the

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 04/03/15 10:14, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD. KVM_CAP_IRQFD is now advertised.

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 05/03/15 14:04, Eric Auger wrote: Hi Marc, On 03/05/2015 11:53 AM, Marc Zyngier wrote: On 04/03/15 10:14, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 05/03/15 14:26, Eric Auger wrote: On 03/05/2015 03:20 PM, Marc Zyngier wrote: On 05/03/15 14:04, Eric Auger wrote: Hi Marc, On 03/05/2015 11:53 AM, Marc Zyngier wrote: On 04/03/15 10:14, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported.

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Eric Auger
On 03/05/2015 03:20 PM, Marc Zyngier wrote: On 05/03/15 14:04, Eric Auger wrote: Hi Marc, On 03/05/2015 11:53 AM, Marc Zyngier wrote: On 04/03/15 10:14, Eric Auger wrote: This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c

Re: [PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-05 Thread Marc Zyngier
On 05/03/15 11:27, Paolo Bonzini wrote: On 05/03/2015 11:53, Marc Zyngier wrote: +#ifdef CONFIG_HAVE_KVM_IRQFD + case KVM_CAP_IRQFD: + r = vgic_present; + break; +#endif Nitpick: we have select HAVE_KVM_IRQFD, so we can lose the #ifdef-ery. Alternatively, I've