Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-18 Thread Parav Pandit
Hi Doug, Leon has finished review as well in [7]. Christoph Acked too in [8]. Can you please advise whether (1) I should rebase and resend PatchV12? (2) If so for which branch - master/4.9 or? Tejun and Christoph mentioned that it might be late for 4.9. Can we atleast merge to linux-rdma tree,

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-18 Thread Parav Pandit
Hi Doug, Leon has finished review as well in [7]. Christoph Acked too in [8]. Can you please advise whether (1) I should rebase and resend PatchV12? (2) If so for which branch - master/4.9 or? Tejun and Christoph mentioned that it might be late for 4.9. Can we atleast merge to linux-rdma tree,

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-06 Thread Parav Pandit
Hi Christoph, On Wed, Oct 5, 2016 at 12:07 PM, Christoph Hellwig wrote: > FYI, the patches look fine to me: > > Acked-by: Christoph Hellwig > Thanks a lot for review. Parav

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-06 Thread Parav Pandit
Hi Christoph, On Wed, Oct 5, 2016 at 12:07 PM, Christoph Hellwig wrote: > FYI, the patches look fine to me: > > Acked-by: Christoph Hellwig > Thanks a lot for review. Parav

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-05 Thread Tejun Heo
Hello, On Wed, Oct 05, 2016 at 02:22:57PM +0300, Leon Romanovsky wrote: > On Wed, Oct 05, 2016 at 08:37:35AM +0200, Christoph Hellwig wrote: > > FYI, the patches look fine to me: > > > > Acked-by: Christoph Hellwig > > > > but we're past the merge window for 4.9 now unfortunately. >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-05 Thread Tejun Heo
Hello, On Wed, Oct 05, 2016 at 02:22:57PM +0300, Leon Romanovsky wrote: > On Wed, Oct 05, 2016 at 08:37:35AM +0200, Christoph Hellwig wrote: > > FYI, the patches look fine to me: > > > > Acked-by: Christoph Hellwig > > > > but we're past the merge window for 4.9 now unfortunately. > > IMHO, it

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-05 Thread Leon Romanovsky
On Wed, Oct 05, 2016 at 08:37:35AM +0200, Christoph Hellwig wrote: > FYI, the patches look fine to me: > > Acked-by: Christoph Hellwig > > but we're past the merge window for 4.9 now unfortunately. IMHO, it still can make it. Thanks signature.asc Description: PGP signature

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-05 Thread Leon Romanovsky
On Wed, Oct 05, 2016 at 08:37:35AM +0200, Christoph Hellwig wrote: > FYI, the patches look fine to me: > > Acked-by: Christoph Hellwig > > but we're past the merge window for 4.9 now unfortunately. IMHO, it still can make it. Thanks signature.asc Description: PGP signature

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-05 Thread Christoph Hellwig
FYI, the patches look fine to me: Acked-by: Christoph Hellwig but we're past the merge window for 4.9 now unfortunately.

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-05 Thread Christoph Hellwig
FYI, the patches look fine to me: Acked-by: Christoph Hellwig but we're past the merge window for 4.9 now unfortunately.

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-04 Thread Parav Pandit
Hi Doug, I am still waiting for Leon to provide his comments if any on rdma cgroup. >From other email context, he was on vacation last week. While we wait for his comments, I wanted to know your view of this patchset in 4.9 merge window. To summarize the discussion that happened in two threads.

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-10-04 Thread Parav Pandit
Hi Doug, I am still waiting for Leon to provide his comments if any on rdma cgroup. >From other email context, he was on vacation last week. While we wait for his comments, I wanted to know your view of this patchset in 4.9 merge window. To summarize the discussion that happened in two threads.

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-21 Thread Parav Pandit
Hi Tejun, On Wed, Sep 21, 2016 at 7:56 PM, Tejun Heo wrote: > Hello, Parav. > > On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote: >> We have completed review from Tejun, Christoph. >> HFI driver folks also provided feedback for Intel drivers. >> Matan's also doesn't

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-21 Thread Parav Pandit
Hi Tejun, On Wed, Sep 21, 2016 at 7:56 PM, Tejun Heo wrote: > Hello, Parav. > > On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote: >> We have completed review from Tejun, Christoph. >> HFI driver folks also provided feedback for Intel drivers. >> Matan's also doesn't have any more

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-21 Thread Tejun Heo
Hello, Parav. On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote: > We have completed review from Tejun, Christoph. > HFI driver folks also provided feedback for Intel drivers. > Matan's also doesn't have any more comments. > > If possible, if you can also review, it will be helpful. >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-21 Thread Tejun Heo
Hello, Parav. On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote: > We have completed review from Tejun, Christoph. > HFI driver folks also provided feedback for Intel drivers. > Matan's also doesn't have any more comments. > > If possible, if you can also review, it will be helpful. >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-20 Thread Parav Pandit
Hi Leon, On Fri, Sep 16, 2016 at 12:26 AM, Leon Romanovsky wrote: > On Wed, Sep 14, 2016 at 12:36:19PM +0530, Parav Pandit wrote: >> Hi Dennis, >> >> Do you know how would HFI1 driver would work along with rdma cgroup? >> >> Hi Matan, Leon, Jason, >> Apart from HFI1, is there

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-20 Thread Parav Pandit
Hi Leon, On Fri, Sep 16, 2016 at 12:26 AM, Leon Romanovsky wrote: > On Wed, Sep 14, 2016 at 12:36:19PM +0530, Parav Pandit wrote: >> Hi Dennis, >> >> Do you know how would HFI1 driver would work along with rdma cgroup? >> >> Hi Matan, Leon, Jason, >> Apart from HFI1, is there any other concern?

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-19 Thread Parav Pandit
Hi Denny, On Mon, Sep 19, 2016 at 6:40 PM, Dalessandro, Dennis wrote: > On Wed, 2016-09-14 at 12:36 +0530, Parav Pandit wrote: >> Hi Dennis, >> >> Do you know how would HFI1 driver would work along with rdma cgroup? > > Keep in mind HFI1 driver has two "modes" of

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-19 Thread Parav Pandit
Hi Denny, On Mon, Sep 19, 2016 at 6:40 PM, Dalessandro, Dennis wrote: > On Wed, 2016-09-14 at 12:36 +0530, Parav Pandit wrote: >> Hi Dennis, >> >> Do you know how would HFI1 driver would work along with rdma cgroup? > > Keep in mind HFI1 driver has two "modes" of operation. We support > verbs,

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-19 Thread Dalessandro, Dennis
On Wed, 2016-09-14 at 12:36 +0530, Parav Pandit wrote: > Hi Dennis, > > Do you know how would HFI1 driver would work along with rdma cgroup? Keep in mind HFI1 driver has two "modes" of operation. We support verbs, and would surely fall in line with whatever cgroups do for IB core. For our psm

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-19 Thread Dalessandro, Dennis
On Wed, 2016-09-14 at 12:36 +0530, Parav Pandit wrote: > Hi Dennis, > > Do you know how would HFI1 driver would work along with rdma cgroup? Keep in mind HFI1 driver has two "modes" of operation. We support verbs, and would surely fall in line with whatever cgroups do for IB core. For our psm

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-15 Thread Leon Romanovsky
On Wed, Sep 14, 2016 at 12:36:19PM +0530, Parav Pandit wrote: > Hi Dennis, > > Do you know how would HFI1 driver would work along with rdma cgroup? > > Hi Matan, Leon, Jason, > Apart from HFI1, is there any other concern? > Or Patch is good to go? I didn't review it yet :(. Sorry > > 4.8 dates

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-15 Thread Leon Romanovsky
On Wed, Sep 14, 2016 at 12:36:19PM +0530, Parav Pandit wrote: > Hi Dennis, > > Do you know how would HFI1 driver would work along with rdma cgroup? > > Hi Matan, Leon, Jason, > Apart from HFI1, is there any other concern? > Or Patch is good to go? I didn't review it yet :(. Sorry > > 4.8 dates

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-14 Thread Parav Pandit
Hi Matan, On Wed, Sep 14, 2016 at 1:44 PM, Matan Barak wrote: > On 14/09/2016 10:06, Parav Pandit wrote: >> >> Hi Dennis, >> >> Do you know how would HFI1 driver would work along with rdma cgroup? >> >> Hi Matan, Leon, Jason, >> Apart from HFI1, is there any other concern? >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-14 Thread Parav Pandit
Hi Matan, On Wed, Sep 14, 2016 at 1:44 PM, Matan Barak wrote: > On 14/09/2016 10:06, Parav Pandit wrote: >> >> Hi Dennis, >> >> Do you know how would HFI1 driver would work along with rdma cgroup? >> >> Hi Matan, Leon, Jason, >> Apart from HFI1, is there any other concern? > > > I just wonder

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-14 Thread Matan Barak
On 14/09/2016 10:06, Parav Pandit wrote: Hi Dennis, Do you know how would HFI1 driver would work along with rdma cgroup? Hi Matan, Leon, Jason, Apart from HFI1, is there any other concern? I just wonder how things like RSS will work. For example, a RSS QP doesn't really have a queue (if I

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-14 Thread Matan Barak
On 14/09/2016 10:06, Parav Pandit wrote: Hi Dennis, Do you know how would HFI1 driver would work along with rdma cgroup? Hi Matan, Leon, Jason, Apart from HFI1, is there any other concern? I just wonder how things like RSS will work. For example, a RSS QP doesn't really have a queue (if I

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-14 Thread Parav Pandit
Hi Dennis, Do you know how would HFI1 driver would work along with rdma cgroup? Hi Matan, Leon, Jason, Apart from HFI1, is there any other concern? Or Patch is good to go? 4.8 dates are close by (2 weeks) and there are two git trees involved (that might cause merge error to Linus) so if there

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-14 Thread Parav Pandit
Hi Dennis, Do you know how would HFI1 driver would work along with rdma cgroup? Hi Matan, Leon, Jason, Apart from HFI1, is there any other concern? Or Patch is good to go? 4.8 dates are close by (2 weeks) and there are two git trees involved (that might cause merge error to Linus) so if there

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Leon Romanovsky
On Sun, Sep 11, 2016 at 11:52:35AM -0600, Jason Gunthorpe wrote: > On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote: > > > > > I've posted some initial work toward a) a while ago, and once we > > > > > > Did it get merged? Do you have a pointer? > > > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Leon Romanovsky
On Sun, Sep 11, 2016 at 11:52:35AM -0600, Jason Gunthorpe wrote: > On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote: > > > > > I've posted some initial work toward a) a while ago, and once we > > > > > > Did it get merged? Do you have a pointer? > > > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Jason Gunthorpe
On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote: > > > > I've posted some initial work toward a) a while ago, and once we > > > > Did it get merged? Do you have a pointer? > > http://www.spinics.net/lists/linux-rdma/msg31958.html Right, I remember that. Certainly the right

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Jason Gunthorpe
On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote: > > > > I've posted some initial work toward a) a while ago, and once we > > > > Did it get merged? Do you have a pointer? > > http://www.spinics.net/lists/linux-rdma/msg31958.html Right, I remember that. Certainly the right

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Christoph Hellwig
On Sun, Sep 11, 2016 at 11:14:09AM -0600, Jason Gunthorpe wrote: > > > We stil always have the common structure first. And at least for > > > cgroups supports that's what matters. > > > > > > Re the actual structures - we'll really need to make sure we > > > > > > a) expose proper userspace abi

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Christoph Hellwig
On Sun, Sep 11, 2016 at 11:14:09AM -0600, Jason Gunthorpe wrote: > > > We stil always have the common structure first. And at least for > > > cgroups supports that's what matters. > > > > > > Re the actual structures - we'll really need to make sure we > > > > > > a) expose proper userspace abi

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Jason Gunthorpe
On Sun, Sep 11, 2016 at 05:35:22PM +0300, Leon Romanovsky wrote: > > We stil always have the common structure first. And at least for > > cgroups supports that's what matters. > > > > Re the actual structures - we'll really need to make sure we > > > > a) expose proper userspace abi headers in

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Jason Gunthorpe
On Sun, Sep 11, 2016 at 05:35:22PM +0300, Leon Romanovsky wrote: > > We stil always have the common structure first. And at least for > > cgroups supports that's what matters. > > > > Re the actual structures - we'll really need to make sure we > > > > a) expose proper userspace abi headers in

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Leon Romanovsky
On Sun, Sep 11, 2016 at 03:34:21PM +0200, Christoph Hellwig wrote: > On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > > Sadly, it isn't a step backwards, it is status quo - at least as far > > as the uapi is concerned. > > Sort of, see below: > > > struct mlx5_create_cq { > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Leon Romanovsky
On Sun, Sep 11, 2016 at 03:34:21PM +0200, Christoph Hellwig wrote: > On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > > Sadly, it isn't a step backwards, it is status quo - at least as far > > as the uapi is concerned. > > Sort of, see below: > > > struct mlx5_create_cq { > >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Christoph Hellwig
On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > Sadly, it isn't a step backwards, it is status quo - at least as far > as the uapi is concerned. Sort of, see below: > struct mlx5_create_cq { > struct ibv_create_cqibv_cmd; > __u64

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Christoph Hellwig
On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote: > Sadly, it isn't a step backwards, it is status quo - at least as far > as the uapi is concerned. Sort of, see below: > struct mlx5_create_cq { > struct ibv_create_cqibv_cmd; > __u64

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Matan Barak
On 10/09/2016 20:01, Jason Gunthorpe wrote: On Sat, Sep 10, 2016 at 06:14:42PM +0200, Christoph Hellwig wrote: OFVWG meetings have absolutely zero relevance for Linux development. Well, to be fair there are a fair number of kernel developers on that particular call.. More "flexibility" for

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Matan Barak
On 10/09/2016 20:01, Jason Gunthorpe wrote: On Sat, Sep 10, 2016 at 06:14:42PM +0200, Christoph Hellwig wrote: OFVWG meetings have absolutely zero relevance for Linux development. Well, to be fair there are a fair number of kernel developers on that particular call.. More "flexibility" for

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Matan Barak
On 10/09/2016 19:12, Christoph Hellwig wrote: On Wed, Sep 07, 2016 at 01:25:13PM +0530, Parav Pandit wrote: a) delay cgroups support until the grand rewrite is done b) add it now and deal with the consequences later Can we do (b) now and differ adding any HW resources to cgroup until they

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-11 Thread Matan Barak
On 10/09/2016 19:12, Christoph Hellwig wrote: On Wed, Sep 07, 2016 at 01:25:13PM +0530, Parav Pandit wrote: a) delay cgroups support until the grand rewrite is done b) add it now and deal with the consequences later Can we do (b) now and differ adding any HW resources to cgroup until they

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Jason Gunthorpe
On Sat, Sep 10, 2016 at 06:14:42PM +0200, Christoph Hellwig wrote: > OFVWG meetings have absolutely zero relevance for Linux development. Well, to be fair there are a fair number of kernel developers on that particular call.. > More "flexibility" for drivers just means giving up on designing a >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Jason Gunthorpe
On Sat, Sep 10, 2016 at 06:14:42PM +0200, Christoph Hellwig wrote: > OFVWG meetings have absolutely zero relevance for Linux development. Well, to be fair there are a fair number of kernel developers on that particular call.. > More "flexibility" for drivers just means giving up on designing a >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Christoph Hellwig
On Wed, Sep 07, 2016 at 11:51:42AM +0300, Matan Barak wrote: > All recent proposals of the new ABI schema deals with extending the > flexibility of the current schema by letting drivers define their specific > types, actions, attributes, etc. Even more than that, the dispatching > starts from

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Christoph Hellwig
On Wed, Sep 07, 2016 at 11:51:42AM +0300, Matan Barak wrote: > All recent proposals of the new ABI schema deals with extending the > flexibility of the current schema by letting drivers define their specific > types, actions, attributes, etc. Even more than that, the dispatching > starts from

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Christoph Hellwig
On Wed, Sep 07, 2016 at 01:25:13PM +0530, Parav Pandit wrote: > > a) delay cgroups support until the grand rewrite is done > > b) add it now and deal with the consequences later > > > Can we do (b) now and differ adding any HW resources to cgroup until > they are clearly called out. >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-10 Thread Christoph Hellwig
On Wed, Sep 07, 2016 at 01:25:13PM +0530, Parav Pandit wrote: > > a) delay cgroups support until the grand rewrite is done > > b) add it now and deal with the consequences later > > > Can we do (b) now and differ adding any HW resources to cgroup until > they are clearly called out. >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-08 Thread Parav Pandit
On Thu, Sep 8, 2016 at 11:42 AM, Leon Romanovsky wrote: > On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote: >> Did you get a chance to review the series? > > We need to decide on fundamental question before reviewing it, which is > "how to fit rdmacg to new ABI

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-08 Thread Parav Pandit
On Thu, Sep 8, 2016 at 11:42 AM, Leon Romanovsky wrote: > On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote: >> Did you get a chance to review the series? > > We need to decide on fundamental question before reviewing it, which is > "how to fit rdmacg to new ABI model". >From last

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-08 Thread Leon Romanovsky
On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote: > Hi Leon, > > >> Signed-off-by: Parav Pandit > >> +static struct rdmacg_resource_pool * > >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device) > >> +{ > >> + struct

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-08 Thread Leon Romanovsky
On Wed, Sep 07, 2016 at 08:37:23PM +0530, Parav Pandit wrote: > Hi Leon, > > >> Signed-off-by: Parav Pandit > >> +static struct rdmacg_resource_pool * > >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device) > >> +{ > >> + struct rdmacg_resource_pool *rpool; > >> + > >>

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Matan Barak
On 07/09/2016 10:55, Parav Pandit wrote: Hi Matan, On Thu, Sep 1, 2016 at 2:14 PM, Christoph Hellwig wrote: On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: Well, if I recall, the reason doing so last time was in order to allow flexible updating of ib_core

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Matan Barak
On 07/09/2016 10:55, Parav Pandit wrote: Hi Matan, On Thu, Sep 1, 2016 at 2:14 PM, Christoph Hellwig wrote: On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: Well, if I recall, the reason doing so last time was in order to allow flexible updating of ib_core independently, which is

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Parav Pandit
Hi Leon, >> Signed-off-by: Parav Pandit >> +static struct rdmacg_resource_pool * >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device) >> +{ >> + struct rdmacg_resource_pool *rpool; >> + >> + rpool = find_cg_rpool_locked(cg, device); >> +

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Parav Pandit
Hi Leon, >> Signed-off-by: Parav Pandit >> +static struct rdmacg_resource_pool * >> +get_cg_rpool_locked(struct rdma_cgroup *cg, struct rdmacg_device *device) >> +{ >> + struct rdmacg_resource_pool *rpool; >> + >> + rpool = find_cg_rpool_locked(cg, device); >> + if (rpool) >> +

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Parav Pandit
On Wed, Sep 7, 2016 at 2:21 PM, Matan Barak wrote: > On 07/09/2016 10:55, Parav Pandit wrote: >> >> Hi Matan, >> >> On Thu, Sep 1, 2016 at 2:14 PM, Christoph Hellwig wrote: >>> >>> On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: Well, if I

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Parav Pandit
On Wed, Sep 7, 2016 at 2:21 PM, Matan Barak wrote: > On 07/09/2016 10:55, Parav Pandit wrote: >> >> Hi Matan, >> >> On Thu, Sep 1, 2016 at 2:14 PM, Christoph Hellwig wrote: >>> >>> On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: Well, if I recall, the reason doing so last

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Parav Pandit
Hi Matan, On Thu, Sep 1, 2016 at 2:14 PM, Christoph Hellwig wrote: > On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: >> Well, if I recall, the reason doing so last time was in order to allow >> flexible updating of ib_core independently, which is obviously not a good >>

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-07 Thread Parav Pandit
Hi Matan, On Thu, Sep 1, 2016 at 2:14 PM, Christoph Hellwig wrote: > On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: >> Well, if I recall, the reason doing so last time was in order to allow >> flexible updating of ib_core independently, which is obviously not a good >> reason (to

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-01 Thread Matan Barak
On 01/09/2016 00:16, Tejun Heo wrote: Hello, On Wed, Aug 31, 2016 at 06:07:30PM +0300, Matan Barak wrote: Currently, there are some discussions regarding the RDMA ABI. The current proposed approach (after a lot of discussions in the OFVWG) is to have driver dependent object types rather than

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-01 Thread Matan Barak
On 01/09/2016 00:16, Tejun Heo wrote: Hello, On Wed, Aug 31, 2016 at 06:07:30PM +0300, Matan Barak wrote: Currently, there are some discussions regarding the RDMA ABI. The current proposed approach (after a lot of discussions in the OFVWG) is to have driver dependent object types rather than

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-01 Thread Christoph Hellwig
On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: > Well, if I recall, the reason doing so last time was in order to allow > flexible updating of ib_core independently, which is obviously not a good > reason (to say the least). > > Since the new ABI will probably define new object

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-09-01 Thread Christoph Hellwig
On Thu, Sep 01, 2016 at 10:25:40AM +0300, Matan Barak wrote: > Well, if I recall, the reason doing so last time was in order to allow > flexible updating of ib_core independently, which is obviously not a good > reason (to say the least). > > Since the new ABI will probably define new object

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-08-31 Thread Matan Barak
On 31/08/2016 11:37, Parav Pandit wrote: Added rdma cgroup controller that does accounting, limit enforcement on rdma/IB verbs and hw resources. Added rdma cgroup header file which defines its APIs to perform charing/uncharing functionality. It also defined APIs for RDMA/IB stack for device

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-08-31 Thread Matan Barak
On 31/08/2016 11:37, Parav Pandit wrote: Added rdma cgroup controller that does accounting, limit enforcement on rdma/IB verbs and hw resources. Added rdma cgroup header file which defines its APIs to perform charing/uncharing functionality. It also defined APIs for RDMA/IB stack for device

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-08-31 Thread Tejun Heo
Hello, On Wed, Aug 31, 2016 at 06:07:30PM +0300, Matan Barak wrote: > Currently, there are some discussions regarding the RDMA ABI. The current > proposed approach (after a lot of discussions in the OFVWG) is to have > driver dependent object types rather than the fixed set of IB object types >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-08-31 Thread Tejun Heo
Hello, On Wed, Aug 31, 2016 at 06:07:30PM +0300, Matan Barak wrote: > Currently, there are some discussions regarding the RDMA ABI. The current > proposed approach (after a lot of discussions in the OFVWG) is to have > driver dependent object types rather than the fixed set of IB object types >

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-08-31 Thread Leon Romanovsky
On Wed, Aug 31, 2016 at 02:07:25PM +0530, Parav Pandit wrote: > Added rdma cgroup controller that does accounting, limit enforcement > on rdma/IB verbs and hw resources. > > Added rdma cgroup header file which defines its APIs to perform > charing/uncharing functionality. It also defined APIs for

Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

2016-08-31 Thread Leon Romanovsky
On Wed, Aug 31, 2016 at 02:07:25PM +0530, Parav Pandit wrote: > Added rdma cgroup controller that does accounting, limit enforcement > on rdma/IB verbs and hw resources. > > Added rdma cgroup header file which defines its APIs to perform > charing/uncharing functionality. It also defined APIs for