Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Mike Turquette
Quoting Tomasz Figa (2014-07-31 15:17:29) > Humberto, > > [dropping few addresses from Cc as this topic is rather irrelevant for > them and adding Mike and Sylwester] > > On 31.07.2014 23:19, Humberto Naves wrote: > > Hi, > > > > On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa wrote: > >> > >>

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
Humberto, [dropping few addresses from Cc as this topic is rather irrelevant for them and adding Mike and Sylwester] On 31.07.2014 23:19, Humberto Naves wrote: > Hi, > > On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa wrote: >> >> I'm not sure I get the idea of the field you're suggesting. If I

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Humberto Naves
Hi, On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa wrote: > > I'm not sure I get the idea of the field you're suggesting. If I > understand correctly, your intention would be to provide a default > frequency if there is no table provided. I don't think there is a need > for it, because current

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
On 31.07.2014 15:37, Humberto Naves wrote: > Hi Tomasz, > > I remember checking these rates on my calculator. You might notice the > odd frequency of 45158401Hz (no pun intended) in the EPLL clock. This > particular clock frequency was giving me a big headache in a previous > project, since it

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Humberto Naves
Hi Tomasz, I remember checking these rates on my calculator. You might notice the odd frequency of 45158401Hz (no pun intended) in the EPLL clock. This particular clock frequency was giving me a big headache in a previous project, since it was wrongly listed as 45158400. At first it seems

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
Hi Humberto, You can find my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: > Added the remaining PLL clocks, and also added the configuration > tables with the PLL coefficients for the supported frequencies. > These frequency tables are only installed when a 24MHz clock is >

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
Hi Humberto, You can find my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: Added the remaining PLL clocks, and also added the configuration tables with the PLL coefficients for the supported frequencies. These frequency tables are only installed when a 24MHz clock is

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Humberto Naves
Hi Tomasz, I remember checking these rates on my calculator. You might notice the odd frequency of 45158401Hz (no pun intended) in the EPLL clock. This particular clock frequency was giving me a big headache in a previous project, since it was wrongly listed as 45158400. At first it seems

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
On 31.07.2014 15:37, Humberto Naves wrote: Hi Tomasz, I remember checking these rates on my calculator. You might notice the odd frequency of 45158401Hz (no pun intended) in the EPLL clock. This particular clock frequency was giving me a big headache in a previous project, since it was

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Humberto Naves
Hi, On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: I'm not sure I get the idea of the field you're suggesting. If I understand correctly, your intention would be to provide a default frequency if there is no table provided. I don't think there is a need for it,

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
Humberto, [dropping few addresses from Cc as this topic is rather irrelevant for them and adding Mike and Sylwester] On 31.07.2014 23:19, Humberto Naves wrote: Hi, On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: I'm not sure I get the idea of the field you're

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Mike Turquette
Quoting Tomasz Figa (2014-07-31 15:17:29) Humberto, [dropping few addresses from Cc as this topic is rather irrelevant for them and adding Mike and Sylwester] On 31.07.2014 23:19, Humberto Naves wrote: Hi, On Thu, Jul 31, 2014 at 5:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: