Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-13 Thread Pavel Machek
On Wed 2014-03-12 15:32:59, Linus Walleij wrote: > On Mon, Mar 10, 2014 at 5:33 AM, Jenny Tc wrote: > > On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: > > >> > + /* sort based on priority. 0 has the highest priority */ > >> > + for (i = 0; i < cnt; ++i) > >> > + for

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-13 Thread Pavel Machek
On Wed 2014-03-12 15:32:59, Linus Walleij wrote: On Mon, Mar 10, 2014 at 5:33 AM, Jenny Tc jenny...@intel.com wrote: On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: + /* sort based on priority. 0 has the highest priority */ + for (i = 0; i cnt; ++i) +

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
On Fri, Mar 7, 2014 at 6:29 AM, Jenny TC wrote: > +enum psy_charger_cable_type { > + PSY_CHARGER_CABLE_TYPE_NONE = 0, > + PSY_CHARGER_CABLE_TYPE_USB_SDP = 1 << 0, > + PSY_CHARGER_CABLE_TYPE_USB_DCP = 1 << 1, > + PSY_CHARGER_CABLE_TYPE_USB_CDP = 1 << 2, > +

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
On Mon, Mar 10, 2014 at 5:33 AM, Jenny Tc wrote: > On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: >> > + /* sort based on priority. 0 has the highest priority */ >> > + for (i = 0; i < cnt; ++i) >> > + for (j = 0; j < cnt; ++j) >> > + if

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
On Mon, Mar 10, 2014 at 5:33 AM, Jenny Tc jenny...@intel.com wrote: On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: + /* sort based on priority. 0 has the highest priority */ + for (i = 0; i cnt; ++i) + for (j = 0; j cnt; ++j) + if

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-12 Thread Linus Walleij
On Fri, Mar 7, 2014 at 6:29 AM, Jenny TC jenny...@intel.com wrote: +enum psy_charger_cable_type { + PSY_CHARGER_CABLE_TYPE_NONE = 0, + PSY_CHARGER_CABLE_TYPE_USB_SDP = 1 0, + PSY_CHARGER_CABLE_TYPE_USB_DCP = 1 1, + PSY_CHARGER_CABLE_TYPE_USB_CDP = 1 2, +

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-11 Thread Pavel Machek
Hi! > > You still miss some wovels here. Sometimes it imakes it unlear: > > chrg is charge? charger? > > chrgr means charger, chrg means charge. Isn't it used consistently?. Can fix > it if > it's really annoying. Please suggest. Well... with all the missing letters, it is not clear if

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-11 Thread Pavel Machek
Hi! You still miss some wovels here. Sometimes it imakes it unlear: chrg is charge? charger? chrgr means charger, chrg means charge. Isn't it used consistently?. Can fix it if it's really annoying. Please suggest. Well... with all the missing letters, it is not clear if letter is

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-09 Thread Jenny Tc
On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: Hi, > > The Power Supply charging driver connects multiple subsystems > > to do charging in a generic way. The subsystems involves power_supply, > > thermal and battery communication subsystems (1wire).With this the charging > > is >

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-09 Thread Jenny Tc
On Fri, Mar 07, 2014 at 09:25:20PM +0100, Pavel Machek wrote: Hi, The Power Supply charging driver connects multiple subsystems to do charging in a generic way. The subsystems involves power_supply, thermal and battery communication subsystems (1wire).With this the charging is handled

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-07 Thread Pavel Machek
Hi! > The Power Supply charging driver connects multiple subsystems > to do charging in a generic way. The subsystems involves power_supply, > thermal and battery communication subsystems (1wire).With this the charging is > handled in a generic way. " " after ".", please. > + > +The Power Supply

Re: [PATCHv8 2/4] power_supply: Introduce generic psy charging driver

2014-03-07 Thread Pavel Machek
Hi! The Power Supply charging driver connects multiple subsystems to do charging in a generic way. The subsystems involves power_supply, thermal and battery communication subsystems (1wire).With this the charging is handled in a generic way. after ., please. + +The Power Supply charging