Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Lucas Stach
Am Freitag, den 14.11.2014, 16:03 + schrieb Marc Zyngier: > On 14/11/14 15:25, Jiang Liu wrote: > > On 2014/11/14 23:16, Marc Zyngier wrote: > >> On 14/11/14 14:26, Jiang Liu wrote: > >>> On 2014/11/14 22:11, Yijing Wang wrote: > > >>> We have achieved 1 and 2. And seems we could also

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Marc Zyngier
On 14/11/14 15:54, Jiang Liu wrote: > On 2014/11/14 5:28, Marc Zyngier wrote: >> On 13/11/14 21:11, Thomas Gleixner wrote: >>> On Thu, 13 Nov 2014, Marc Zyngier wrote: With the new stacked irq domains, it becomes pretty tempting to allocate an MSI domain per PCI bus, which would remove

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Marc Zyngier
On 14/11/14 15:25, Jiang Liu wrote: > On 2014/11/14 23:16, Marc Zyngier wrote: >> On 14/11/14 14:26, Jiang Liu wrote: >>> On 2014/11/14 22:11, Yijing Wang wrote: >>> We have achieved 1 and 2. And seems we could also achieve 3 by >>> converting all arch specific PCI MSI code to use hierarchy

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Jiang Liu
On 2014/11/14 5:28, Marc Zyngier wrote: > On 13/11/14 21:11, Thomas Gleixner wrote: >> On Thu, 13 Nov 2014, Marc Zyngier wrote: >>> With the new stacked irq domains, it becomes pretty tempting >>> to allocate an MSI domain per PCI bus, which would remove >>> the requirement of either relying on

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Jiang Liu
On 2014/11/14 23:16, Marc Zyngier wrote: > On 14/11/14 14:26, Jiang Liu wrote: >> On 2014/11/14 22:11, Yijing Wang wrote: >>> >> We have achieved 1 and 2. And seems we could also achieve 3 by >> converting all arch specific PCI MSI code to use hierarchy >> irqdomain. But not sure whether we could

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Marc Zyngier
On 14/11/14 14:26, Jiang Liu wrote: > On 2014/11/14 22:11, Yijing Wang wrote: >> >> 在 2014/11/14 9:39, Jiang Liu 写道: >>> On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: >>> Hi Thomas, >>> So we need something like: >>> struct msi_chip

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Jiang Liu
On 2014/11/14 22:11, Yijing Wang wrote: > > 在 2014/11/14 9:39, Jiang Liu 写道: >> On 2014/11/14 9:31, Thomas Gleixner wrote: >>> On Fri, 14 Nov 2014, Yijing Wang wrote: >>> >> Hi Thomas, >> So we need something like: >> struct msi_chip *pci_get_msi_chip(struct pci_dev *); >> or: >> struct

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Yijing Wang
在 2014/11/14 9:39, Jiang Liu 写道: On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? Associate the irq domain and PCI bus is not necessary, because all PCI buses under

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Thomas Gleixner
On Fri, 14 Nov 2014, Jiang Liu wrote: > On 2014/11/14 9:31, Thomas Gleixner wrote: > > On Fri, 14 Nov 2014, Yijing Wang wrote: > > > > Could you please use a mail client which does proper line wraps or > > configure yours to do so? > > > >> Associate the irq domain and PCI bus is not necessary,

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Thomas Gleixner
On Fri, 14 Nov 2014, Jiang Liu wrote: On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? Associate the irq domain and PCI bus is not necessary, because all

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Yijing Wang
在 2014/11/14 9:39, Jiang Liu 写道: On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? Associate the irq domain and PCI bus is not necessary, because all PCI buses under

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Jiang Liu
On 2014/11/14 22:11, Yijing Wang wrote: 在 2014/11/14 9:39, Jiang Liu 写道: On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Hi Thomas, So we need something like: struct msi_chip *pci_get_msi_chip(struct pci_dev *); or: struct irq_domain

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Marc Zyngier
On 14/11/14 14:26, Jiang Liu wrote: On 2014/11/14 22:11, Yijing Wang wrote: 在 2014/11/14 9:39, Jiang Liu 写道: On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Hi Thomas, So we need something like: struct msi_chip *pci_get_msi_chip(struct pci_dev *);

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Jiang Liu
On 2014/11/14 23:16, Marc Zyngier wrote: On 14/11/14 14:26, Jiang Liu wrote: On 2014/11/14 22:11, Yijing Wang wrote: We have achieved 1 and 2. And seems we could also achieve 3 by converting all arch specific PCI MSI code to use hierarchy irqdomain. But not sure whether we could achieve 4,

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Jiang Liu
On 2014/11/14 5:28, Marc Zyngier wrote: On 13/11/14 21:11, Thomas Gleixner wrote: On Thu, 13 Nov 2014, Marc Zyngier wrote: With the new stacked irq domains, it becomes pretty tempting to allocate an MSI domain per PCI bus, which would remove the requirement of either relying on arch-specific

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Marc Zyngier
On 14/11/14 15:25, Jiang Liu wrote: On 2014/11/14 23:16, Marc Zyngier wrote: On 14/11/14 14:26, Jiang Liu wrote: On 2014/11/14 22:11, Yijing Wang wrote: We have achieved 1 and 2. And seems we could also achieve 3 by converting all arch specific PCI MSI code to use hierarchy irqdomain. But

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Marc Zyngier
On 14/11/14 15:54, Jiang Liu wrote: On 2014/11/14 5:28, Marc Zyngier wrote: On 13/11/14 21:11, Thomas Gleixner wrote: On Thu, 13 Nov 2014, Marc Zyngier wrote: With the new stacked irq domains, it becomes pretty tempting to allocate an MSI domain per PCI bus, which would remove the

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-14 Thread Lucas Stach
Am Freitag, den 14.11.2014, 16:03 + schrieb Marc Zyngier: On 14/11/14 15:25, Jiang Liu wrote: On 2014/11/14 23:16, Marc Zyngier wrote: On 14/11/14 14:26, Jiang Liu wrote: On 2014/11/14 22:11, Yijing Wang wrote: We have achieved 1 and 2. And seems we could also achieve 3 by

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/14 9:31, Thomas Gleixner wrote: > On Fri, 14 Nov 2014, Yijing Wang wrote: > > Could you please use a mail client which does proper line wraps or > configure yours to do so? > >> Associate the irq domain and PCI bus is not necessary, because all >> PCI buses under same host bridge

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/14 9:31, Thomas Gleixner wrote: > On Fri, 14 Nov 2014, Yijing Wang wrote: > > Could you please use a mail client which does proper line wraps or > configure yours to do so? > >> Associate the irq domain and PCI bus is not necessary, because all >> PCI buses under same host bridge

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Thomas Gleixner
On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? > Associate the irq domain and PCI bus is not necessary, because all > PCI buses under same host bridge always share same MSI chip/irq > domain, we only need

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/14 9:09, Yijing Wang wrote: > On 2014/11/14 8:25, Jiang Liu wrote: >> On 2014/11/14 5:00, Marc Zyngier wrote: >>> On 13/11/14 11:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI.

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/14 8:25, Jiang Liu wrote: > On 2014/11/14 5:00, Marc Zyngier wrote: >> On 13/11/14 11:43, Jiang Liu wrote: >>> This patch set is based on tip/irq/irqdomain and tries to refine >>> interfaces to support irqdomain for generic MSI and PCI MSI. >>> >>> With this patch set applied, the

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/14 5:00, Marc Zyngier wrote: > On 13/11/14 11:43, Jiang Liu wrote: >> This patch set is based on tip/irq/irqdomain and tries to refine >> interfaces to support irqdomain for generic MSI and PCI MSI. >> >> With this patch set applied, the generic MSI and PCI MSI interfaces >> are much

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Marc Zyngier
On 13/11/14 21:11, Thomas Gleixner wrote: > On Thu, 13 Nov 2014, Marc Zyngier wrote: >> With the new stacked irq domains, it becomes pretty tempting >> to allocate an MSI domain per PCI bus, which would remove >> the requirement of either relying on arch-specific code, or >> a default PCI MSI

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Thomas Gleixner
On Thu, 13 Nov 2014, Marc Zyngier wrote: > With the new stacked irq domains, it becomes pretty tempting > to allocate an MSI domain per PCI bus, which would remove > the requirement of either relying on arch-specific code, or > a default PCI MSI domain. Right. That's what I roughly had in mind.

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Marc Zyngier
On 13/11/14 11:43, Jiang Liu wrote: > This patch set is based on tip/irq/irqdomain and tries to refine > interfaces to support irqdomain for generic MSI and PCI MSI. > > Patch 1 is just minor fixes for tip/irq/irqdomain. > > Patch 2 introduces some helpers to hide struct msi_desc implementation

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/13 20:55, Yijing Wang wrote: > On 2014/11/13 20:39, Jiang Liu wrote: >> >> >> On 2014/11/13 20:28, Yijing Wang wrote: >>> On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/13 20:55, Yijing Wang wrote: > On 2014/11/13 20:39, Jiang Liu wrote: >> >> >> On 2014/11/13 20:28, Yijing Wang wrote: >>> On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/13 20:39, Jiang Liu wrote: > > > On 2014/11/13 20:28, Yijing Wang wrote: >> On 2014/11/13 19:43, Jiang Liu wrote: >>> This patch set is based on tip/irq/irqdomain and tries to refine >>> interfaces to support irqdomain for generic MSI and PCI MSI. >>> >>> Patch 1 is just minor fixes

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/13 20:28, Yijing Wang wrote: > On 2014/11/13 19:43, Jiang Liu wrote: >> This patch set is based on tip/irq/irqdomain and tries to refine >> interfaces to support irqdomain for generic MSI and PCI MSI. >> >> Patch 1 is just minor fixes for tip/irq/irqdomain. >> >> Patch 2 introduces

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/13 19:43, Jiang Liu wrote: > This patch set is based on tip/irq/irqdomain and tries to refine > interfaces to support irqdomain for generic MSI and PCI MSI. > > Patch 1 is just minor fixes for tip/irq/irqdomain. > > Patch 2 introduces some helpers to hide struct msi_desc

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. Patch 1 is just minor fixes for tip/irq/irqdomain. Patch 2 introduces some helpers to hide struct msi_desc implementation

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/13 20:28, Yijing Wang wrote: On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. Patch 1 is just minor fixes for tip/irq/irqdomain. Patch 2 introduces some helpers to

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/13 20:39, Jiang Liu wrote: On 2014/11/13 20:28, Yijing Wang wrote: On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. Patch 1 is just minor fixes for

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/13 20:55, Yijing Wang wrote: On 2014/11/13 20:39, Jiang Liu wrote: On 2014/11/13 20:28, Yijing Wang wrote: On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. Patch 1

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/13 20:55, Yijing Wang wrote: On 2014/11/13 20:39, Jiang Liu wrote: On 2014/11/13 20:28, Yijing Wang wrote: On 2014/11/13 19:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. Patch 1

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Marc Zyngier
On 13/11/14 11:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. Patch 1 is just minor fixes for tip/irq/irqdomain. Patch 2 introduces some helpers to hide struct msi_desc implementation

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Thomas Gleixner
On Thu, 13 Nov 2014, Marc Zyngier wrote: With the new stacked irq domains, it becomes pretty tempting to allocate an MSI domain per PCI bus, which would remove the requirement of either relying on arch-specific code, or a default PCI MSI domain. Right. That's what I roughly had in mind. And

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Marc Zyngier
On 13/11/14 21:11, Thomas Gleixner wrote: On Thu, 13 Nov 2014, Marc Zyngier wrote: With the new stacked irq domains, it becomes pretty tempting to allocate an MSI domain per PCI bus, which would remove the requirement of either relying on arch-specific code, or a default PCI MSI domain.

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/14 5:00, Marc Zyngier wrote: On 13/11/14 11:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. With this patch set applied, the generic MSI and PCI MSI interfaces are much easier to

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/14 8:25, Jiang Liu wrote: On 2014/11/14 5:00, Marc Zyngier wrote: On 13/11/14 11:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. With this patch set applied, the generic MSI and PCI

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/14 9:09, Yijing Wang wrote: On 2014/11/14 8:25, Jiang Liu wrote: On 2014/11/14 5:00, Marc Zyngier wrote: On 13/11/14 11:43, Jiang Liu wrote: This patch set is based on tip/irq/irqdomain and tries to refine interfaces to support irqdomain for generic MSI and PCI MSI. With this

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Thomas Gleixner
On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? Associate the irq domain and PCI bus is not necessary, because all PCI buses under same host bridge always share same MSI chip/irq domain, we only need

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Jiang Liu
On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? Associate the irq domain and PCI bus is not necessary, because all PCI buses under same host bridge always share

Re: [Patch V1 0/6] Refine generic/PCI MSI irqodmian interfaces

2014-11-13 Thread Yijing Wang
On 2014/11/14 9:31, Thomas Gleixner wrote: On Fri, 14 Nov 2014, Yijing Wang wrote: Could you please use a mail client which does proper line wraps or configure yours to do so? Associate the irq domain and PCI bus is not necessary, because all PCI buses under same host bridge always share