Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-23 Thread Stefan Metzmacher
> They're basically the same concept, it's a subtle difference. > > FRMR = Fast Register Memory Region > FRWR = Fast Register Work Request > > The memory region is the mr itself, this is created early on. > > The work request is built when actually binding the physical > pages to the region,

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-23 Thread Stefan Metzmacher
> They're basically the same concept, it's a subtle difference. > > FRMR = Fast Register Memory Region > FRWR = Fast Register Work Request > > The memory region is the mr itself, this is created early on. > > The work request is built when actually binding the physical > pages to the region,

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-23 Thread Tom Talpey
On 9/23/2018 2:24 PM, Stefan Metzmacher wrote: Hi Tom, I just tested that setting: mr->iova &= (PAGE_SIZE - 1); mr->iova |= 0x; after the ib_map_mr_sg() and before doing the IB_WR_REG_MR, seems to work. Good! As you know, we were concerned about it after seeing that the

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-23 Thread Tom Talpey
On 9/23/2018 2:24 PM, Stefan Metzmacher wrote: Hi Tom, I just tested that setting: mr->iova &= (PAGE_SIZE - 1); mr->iova |= 0x; after the ib_map_mr_sg() and before doing the IB_WR_REG_MR, seems to work. Good! As you know, we were concerned about it after seeing that the

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-23 Thread Stefan Metzmacher
Hi Tom, >> I just tested that setting: >> >> mr->iova &= (PAGE_SIZE - 1); >> mr->iova |= 0x; >> >> after the ib_map_mr_sg() and before doing the IB_WR_REG_MR, seems to >> work. > > Good! As you know, we were concerned about it after seeing that > the ib_dma_map_sg() code was

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-23 Thread Stefan Metzmacher
Hi Tom, >> I just tested that setting: >> >> mr->iova &= (PAGE_SIZE - 1); >> mr->iova |= 0x; >> >> after the ib_map_mr_sg() and before doing the IB_WR_REG_MR, seems to >> work. > > Good! As you know, we were concerned about it after seeing that > the ib_dma_map_sg() code was

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-22 Thread Tom Talpey
On 9/21/2018 8:56 PM, Stefan Metzmacher wrote: Hi, +    req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE; +    if (need_invalidate) +    req->Channel = SMB2_CHANNEL_RDMA_V1; +    req->ReadChannelInfoOffset = +    offsetof(struct smb2_read_plain_req, Buffer); +   

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-22 Thread Tom Talpey
On 9/21/2018 8:56 PM, Stefan Metzmacher wrote: Hi, +    req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE; +    if (need_invalidate) +    req->Channel = SMB2_CHANNEL_RDMA_V1; +    req->ReadChannelInfoOffset = +    offsetof(struct smb2_read_plain_req, Buffer); +   

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-21 Thread Stefan Metzmacher
Hi, >> +    req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE; >> +    if (need_invalidate) >> +    req->Channel = SMB2_CHANNEL_RDMA_V1; >> +    req->ReadChannelInfoOffset = >> +    offsetof(struct smb2_read_plain_req, Buffer); >> +    req->ReadChannelInfoLength = >>

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-21 Thread Stefan Metzmacher
Hi, >> +    req->Channel = SMB2_CHANNEL_RDMA_V1_INVALIDATE; >> +    if (need_invalidate) >> +    req->Channel = SMB2_CHANNEL_RDMA_V1; >> +    req->ReadChannelInfoOffset = >> +    offsetof(struct smb2_read_plain_req, Buffer); >> +    req->ReadChannelInfoLength = >>

RE: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-20 Thread Long Li
> Subject: Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via > RDMA write through memory registration > > Replying to a very old message, but it's something we discussed today at the > IOLab event so to capture it: > > On 11/7/2017 12:55 AM, Long Li wro

RE: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-20 Thread Long Li
> Subject: Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via > RDMA write through memory registration > > Replying to a very old message, but it's something we discussed today at the > IOLab event so to capture it: > > On 11/7/2017 12:55 AM, Long Li wro

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-19 Thread Tom Talpey
Replying to a very old message, but it's something we discussed today at the IOLab event so to capture it: On 11/7/2017 12:55 AM, Long Li wrote: From: Long Li --- fs/cifs/file.c| 17 +++-- fs/cifs/smb2pdu.c | 45 - 2 files

Re: [Patch v7 21/22] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2018-09-19 Thread Tom Talpey
Replying to a very old message, but it's something we discussed today at the IOLab event so to capture it: On 11/7/2017 12:55 AM, Long Li wrote: From: Long Li --- fs/cifs/file.c| 17 +++-- fs/cifs/smb2pdu.c | 45 - 2 files