Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-06-01 Thread Jacek Anaszewski
Dan, On 6/1/19 12:41 AM, Dan Murphy wrote: Jacek On 5/31/19 4:57 PM, Jacek Anaszewski wrote: Dan, On 5/31/19 11:07 PM, Dan Murphy wrote: Hello On 5/31/19 2:44 PM, Jacek Anaszewski wrote: On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Dan Murphy
Jacek On 5/31/19 4:57 PM, Jacek Anaszewski wrote: Dan, On 5/31/19 11:07 PM, Dan Murphy wrote: Hello On 5/31/19 2:44 PM, Jacek Anaszewski wrote: On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019,

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Jacek Anaszewski
Dan, On 5/31/19 11:07 PM, Dan Murphy wrote: Hello On 5/31/19 2:44 PM, Jacek Anaszewski wrote: On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019, Jacek Anaszewski wrote: On 5/29/19 3:58 PM, Lee Jones

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Dan Murphy
Hello On 5/31/19 2:44 PM, Jacek Anaszewski wrote: On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019, Jacek Anaszewski wrote: On 5/29/19 3:58 PM, Lee Jones wrote: On Fri, 24 May 2019, Jacek Anaszewski

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Jacek Anaszewski
On 5/31/19 8:23 AM, Lee Jones wrote: On Thu, 30 May 2019, Jacek Anaszewski wrote: On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019, Jacek Anaszewski wrote: On 5/29/19 3:58 PM, Lee Jones wrote: On Fri, 24 May 2019, Jacek Anaszewski wrote: Hi, On 5/23/19 9:09 PM, Dan Murphy wrote:

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-31 Thread Lee Jones
On Thu, 30 May 2019, Jacek Anaszewski wrote: > On 5/30/19 9:38 AM, Lee Jones wrote: > > On Wed, 29 May 2019, Jacek Anaszewski wrote: > > > > > On 5/29/19 3:58 PM, Lee Jones wrote: > > > > On Fri, 24 May 2019, Jacek Anaszewski wrote: > > > > > > > > > Hi, > > > > > > > > > > On 5/23/19 9:09 PM,

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-30 Thread Jacek Anaszewski
On 5/30/19 9:38 AM, Lee Jones wrote: On Wed, 29 May 2019, Jacek Anaszewski wrote: On 5/29/19 3:58 PM, Lee Jones wrote: On Fri, 24 May 2019, Jacek Anaszewski wrote: Hi, On 5/23/19 9:09 PM, Dan Murphy wrote: Pavel Thanks for the review On 5/23/19 7:50 AM, Pavel Machek wrote: Hi! +++

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-30 Thread Lee Jones
On Wed, 29 May 2019, Jacek Anaszewski wrote: > On 5/29/19 3:58 PM, Lee Jones wrote: > > On Fri, 24 May 2019, Jacek Anaszewski wrote: > > > > > Hi, > > > > > > On 5/23/19 9:09 PM, Dan Murphy wrote: > > > > Pavel > > > > > > > > Thanks for the review > > > > > > > > On 5/23/19 7:50 AM, Pavel

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-29 Thread Jacek Anaszewski
On 5/29/19 3:58 PM, Lee Jones wrote: On Fri, 24 May 2019, Jacek Anaszewski wrote: Hi, On 5/23/19 9:09 PM, Dan Murphy wrote: Pavel Thanks for the review On 5/23/19 7:50 AM, Pavel Machek wrote: Hi! +++ b/drivers/leds/leds-lm36274.c +static int lm36274_parse_dt(struct lm36274

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-29 Thread Lee Jones
On Fri, 24 May 2019, Jacek Anaszewski wrote: > Hi, > > On 5/23/19 9:09 PM, Dan Murphy wrote: > > Pavel > > > > Thanks for the review > > > > On 5/23/19 7:50 AM, Pavel Machek wrote: > > > Hi! > > > > > > > +++ b/drivers/leds/leds-lm36274.c > > > > > > > +static int lm36274_parse_dt(struct

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-24 Thread Jacek Anaszewski
Hi, On 5/23/19 9:09 PM, Dan Murphy wrote: Pavel Thanks for the review On 5/23/19 7:50 AM, Pavel Machek wrote: Hi! +++ b/drivers/leds/leds-lm36274.c +static int lm36274_parse_dt(struct lm36274 *lm36274_data) +{ + struct fwnode_handle *child = NULL; + char

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-23 Thread Dan Murphy
Pavel Thanks for the review On 5/23/19 7:50 AM, Pavel Machek wrote: > Hi! > >> +++ b/drivers/leds/leds-lm36274.c > >> +static int lm36274_parse_dt(struct lm36274 *lm36274_data) >> +{ >> +struct fwnode_handle *child = NULL; >> +char label[LED_MAX_NAME_SIZE]; >> +struct device *dev =

Re: [RESEND PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver

2019-05-23 Thread Pavel Machek
Hi! > +++ b/drivers/leds/leds-lm36274.c > +static int lm36274_parse_dt(struct lm36274 *lm36274_data) > +{ > + struct fwnode_handle *child = NULL; > + char label[LED_MAX_NAME_SIZE]; > + struct device *dev = _data->pdev->dev; > + const char *name; > + int child_cnt; > + int