Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-06 Thread Li, Aubrey
On 2018/3/6 16:45, Peter Zijlstra wrote: > On Tue, Mar 06, 2018 at 10:15:10AM +0800, Li, Aubrey wrote: >> On 2018/3/5 21:53, Peter Zijlstra wrote: >>> On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-06 Thread Li, Aubrey
On 2018/3/6 16:45, Peter Zijlstra wrote: > On Tue, Mar 06, 2018 at 10:15:10AM +0800, Li, Aubrey wrote: >> On 2018/3/5 21:53, Peter Zijlstra wrote: >>> On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: > On Mon,

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-06 Thread Peter Zijlstra
On Tue, Mar 06, 2018 at 10:15:10AM +0800, Li, Aubrey wrote: > On 2018/3/5 21:53, Peter Zijlstra wrote: > > On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: > >> On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra > >> wrote: > >>> On Mon, Mar 05, 2018 at

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-06 Thread Peter Zijlstra
On Tue, Mar 06, 2018 at 10:15:10AM +0800, Li, Aubrey wrote: > On 2018/3/5 21:53, Peter Zijlstra wrote: > > On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: > >> On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra > >> wrote: > >>> On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J.

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Li, Aubrey
On 2018/3/5 21:53, Peter Zijlstra wrote: > On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: >> On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: >>> On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: > IOW, the target residency of

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Li, Aubrey
On 2018/3/5 21:53, Peter Zijlstra wrote: > On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: >> On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: >>> On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: > IOW, the target residency of the selected state

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Peter Zijlstra
On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: > > On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: > >> IOW, the target residency of the selected state doesn't tell you how > >>

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Peter Zijlstra
On Mon, Mar 05, 2018 at 02:05:10PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: > > On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: > >> IOW, the target residency of the selected state doesn't tell you how > >> much time you should

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Rafael J. Wysocki
On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: > On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: >> On Mon, Mar 5, 2018 at 12:38 PM, Peter Zijlstra wrote: >> > We really should be predicting state not duration. Yes the

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Rafael J. Wysocki
On Mon, Mar 5, 2018 at 1:50 PM, Peter Zijlstra wrote: > On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: >> On Mon, Mar 5, 2018 at 12:38 PM, Peter Zijlstra wrote: >> > We really should be predicting state not duration. Yes the duration >> > thing is an intermediate value, but I

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Peter Zijlstra
On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 5, 2018 at 12:38 PM, Peter Zijlstra wrote: > > We really should be predicting state not duration. Yes the duration > > thing is an intermediate value, but I don't think it makes any sense > >

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Peter Zijlstra
On Mon, Mar 05, 2018 at 12:47:23PM +0100, Rafael J. Wysocki wrote: > On Mon, Mar 5, 2018 at 12:38 PM, Peter Zijlstra wrote: > > We really should be predicting state not duration. Yes the duration > > thing is an intermediate value, but I don't think it makes any sense > > what so ever to preserve

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Rafael J. Wysocki
On Mon, Mar 5, 2018 at 12:38 PM, Peter Zijlstra wrote: > On Sun, Mar 04, 2018 at 11:26:24PM +0100, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> In order to address the issue with short idle duration predictions >> by the idle

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Rafael J. Wysocki
On Mon, Mar 5, 2018 at 12:38 PM, Peter Zijlstra wrote: > On Sun, Mar 04, 2018 at 11:26:24PM +0100, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> In order to address the issue with short idle duration predictions >> by the idle governor after the tick has been stopped, prepare the >>

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Peter Zijlstra
On Sun, Mar 04, 2018 at 11:26:24PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > In order to address the issue with short idle duration predictions > by the idle governor after the tick has been stopped, prepare the > menu governor code for reordering

Re: [RFC/RFT][PATCH 4/7] cpuidle: menu: Split idle duration prediction from state selection

2018-03-05 Thread Peter Zijlstra
On Sun, Mar 04, 2018 at 11:26:24PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > In order to address the issue with short idle duration predictions > by the idle governor after the tick has been stopped, prepare the > menu governor code for reordering with respect to the