Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-31 Thread Ingo Molnar
* KOSAKI Motohiro wrote: > >> I'm unhappy you guys uses offensive word so much. Please cool down all > >> you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's > >> patch doesn't have cleaner semantics. > > > > Erm, this feature _regressed_ after the patch. All other concerns

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-31 Thread Ingo Molnar
* KOSAKI Motohiro kosaki.motoh...@gmail.com wrote: I'm unhappy you guys uses offensive word so much. Please cool down all you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's patch doesn't have cleaner semantics. Erm, this feature _regressed_ after the patch. All

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread KOSAKI Motohiro
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c > index a841123..f8f47dc 100644 > --- a/drivers/infiniband/core/umem.c > +++ b/drivers/infiniband/core/umem.c > @@ -137,17 +137,22 @@ struct ib_umem *ib_umem_get (struct ib_ucontext > *context, unsigned long addr, > >

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread KOSAKI Motohiro
>> I'm unhappy you guys uses offensive word so much. Please cool down all >> you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's >> patch doesn't have cleaner semantics. > > Erm, this feature _regressed_ after the patch. All other concerns are > secondary. What's so difficult to

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread Pekka Enberg
On Mon, 27 May 2013, Peter Zijlstra wrote: >> Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK >> had a single resource counter. After your patch RLIMIT_MEMLOCK is >> applied separately to both -- more or less. On Tue, May 28, 2013 at 7:37 PM, Christoph Lameter wrote: >

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread Peter Zijlstra
On Tue, May 28, 2013 at 04:37:06PM +, Christoph Lameter wrote: > On Mon, 27 May 2013, Peter Zijlstra wrote: > > > Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK > > had a single resource counter. After your patch RLIMIT_MEMLOCK is > > applied separately to both --

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread Ingo Molnar
* KOSAKI Motohiro wrote: > Hi > > I'm unhappy you guys uses offensive word so much. Please cool down all > you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's > patch doesn't have cleaner semantics. Erm, this feature _regressed_ after the patch. All other concerns are

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread Ingo Molnar
* KOSAKI Motohiro kosaki.motoh...@gmail.com wrote: Hi I'm unhappy you guys uses offensive word so much. Please cool down all you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's patch doesn't have cleaner semantics. Erm, this feature _regressed_ after the patch. All

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread Peter Zijlstra
On Tue, May 28, 2013 at 04:37:06PM +, Christoph Lameter wrote: On Mon, 27 May 2013, Peter Zijlstra wrote: Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK had a single resource counter. After your patch RLIMIT_MEMLOCK is applied separately to both -- more or

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread Pekka Enberg
On Mon, 27 May 2013, Peter Zijlstra wrote: Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK had a single resource counter. After your patch RLIMIT_MEMLOCK is applied separately to both -- more or less. On Tue, May 28, 2013 at 7:37 PM, Christoph Lameter c...@linux.com

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread KOSAKI Motohiro
I'm unhappy you guys uses offensive word so much. Please cool down all you guys. :-/ In fact, _BOTH_ the behavior before and after Cristoph's patch doesn't have cleaner semantics. Erm, this feature _regressed_ after the patch. All other concerns are secondary. What's so difficult to

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-30 Thread KOSAKI Motohiro
diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index a841123..f8f47dc 100644 --- a/drivers/infiniband/core/umem.c +++ b/drivers/infiniband/core/umem.c @@ -137,17 +137,22 @@ struct ib_umem *ib_umem_get (struct ib_ucontext *context, unsigned long addr,

[regression] Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-29 Thread Ingo Molnar
* Christoph Lameter wrote: > On Mon, 27 May 2013, Peter Zijlstra wrote: > > > Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK > > had a single resource counter. After your patch RLIMIT_MEMLOCK is > > applied separately to both -- more or less. > > Before the patch the

[regression] Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-29 Thread Ingo Molnar
* Christoph Lameter c...@linux.com wrote: On Mon, 27 May 2013, Peter Zijlstra wrote: Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK had a single resource counter. After your patch RLIMIT_MEMLOCK is applied separately to both -- more or less. Before the patch

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-28 Thread Christoph Lameter
On Mon, 27 May 2013, Peter Zijlstra wrote: > Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK > had a single resource counter. After your patch RLIMIT_MEMLOCK is > applied separately to both -- more or less. Before the patch the count was doubled since a single page was

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-28 Thread Christoph Lameter
On Sat, 25 May 2013, KOSAKI Motohiro wrote: > If pinned and mlocked are totally difference intentionally, why IB uses > RLIMIT_MEMLOCK. Why don't IB uses IB specific limit and why only IB raise up > number of pinned pages and other gup users don't. > I can't guess IB folk's intent. True another

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-28 Thread Christoph Lameter
On Sat, 25 May 2013, KOSAKI Motohiro wrote: If pinned and mlocked are totally difference intentionally, why IB uses RLIMIT_MEMLOCK. Why don't IB uses IB specific limit and why only IB raise up number of pinned pages and other gup users don't. I can't guess IB folk's intent. True another

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-28 Thread Christoph Lameter
On Mon, 27 May 2013, Peter Zijlstra wrote: Before your patch pinned was included in locked and thus RLIMIT_MEMLOCK had a single resource counter. After your patch RLIMIT_MEMLOCK is applied separately to both -- more or less. Before the patch the count was doubled since a single page was

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-27 Thread Peter Zijlstra
On Fri, May 24, 2013 at 03:40:26PM +, Christoph Lameter wrote: > On Fri, 24 May 2013, Peter Zijlstra wrote: > > > Patch bc3e53f682 ("mm: distinguish between mlocked and pinned pages") > > broke RLIMIT_MEMLOCK. > > Nope the patch fixed a problem with double accounting. And introduces another

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-27 Thread Peter Zijlstra
On Fri, May 24, 2013 at 03:40:26PM +, Christoph Lameter wrote: On Fri, 24 May 2013, Peter Zijlstra wrote: Patch bc3e53f682 (mm: distinguish between mlocked and pinned pages) broke RLIMIT_MEMLOCK. Nope the patch fixed a problem with double accounting. And introduces another problem

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-25 Thread KOSAKI Motohiro
On Fri, May 24, 2013 at 11:40 AM, Christoph Lameter wrote: > On Fri, 24 May 2013, Peter Zijlstra wrote: > >> Patch bc3e53f682 ("mm: distinguish between mlocked and pinned pages") >> broke RLIMIT_MEMLOCK. > > Nope the patch fixed a problem with double accounting. > > The problem that we seem to

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-25 Thread KOSAKI Motohiro
On Fri, May 24, 2013 at 11:40 AM, Christoph Lameter c...@linux.com wrote: On Fri, 24 May 2013, Peter Zijlstra wrote: Patch bc3e53f682 (mm: distinguish between mlocked and pinned pages) broke RLIMIT_MEMLOCK. Nope the patch fixed a problem with double accounting. The problem that we seem to

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-24 Thread Christoph Lameter
On Fri, 24 May 2013, Peter Zijlstra wrote: > Patch bc3e53f682 ("mm: distinguish between mlocked and pinned pages") > broke RLIMIT_MEMLOCK. Nope the patch fixed a problem with double accounting. The problem that we seem to have is to define what mlocked and pinned mean and how this relates to

Re: [RFC][PATCH] mm: Fix RLIMIT_MEMLOCK

2013-05-24 Thread Christoph Lameter
On Fri, 24 May 2013, Peter Zijlstra wrote: Patch bc3e53f682 (mm: distinguish between mlocked and pinned pages) broke RLIMIT_MEMLOCK. Nope the patch fixed a problem with double accounting. The problem that we seem to have is to define what mlocked and pinned mean and how this relates to