Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Glauber Costa
> > OK, I guess I understand. > > Thanks for the clarification, Galuber! You're welcome Mihcal! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Michal Hocko
On Wed 03-04-13 17:11:37, Li Zefan wrote: > Use css_get/css_put instead of mem_cgroup_get/put. > > Note, if at the same time someone is moving @current to a different > cgroup and removing the old cgroup, css_tryget() may return false, > and sock->sk_cgrp won't be initialized. > > Signed-off-by:

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Michal Hocko
On Fri 05-04-13 12:08:40, Glauber Costa wrote: > On 04/03/2013 07:29 PM, Michal Hocko wrote: > > On Wed 03-04-13 16:58:48, Glauber Costa wrote: > >> On 04/03/2013 01:11 PM, Li Zefan wrote: > >>> Use css_get/css_put instead of mem_cgroup_get/put. > >>> > >>> Note, if at the same time someone is

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Glauber Costa
On 04/03/2013 07:29 PM, Michal Hocko wrote: > On Wed 03-04-13 16:58:48, Glauber Costa wrote: >> On 04/03/2013 01:11 PM, Li Zefan wrote: >>> Use css_get/css_put instead of mem_cgroup_get/put. >>> >>> Note, if at the same time someone is moving @current to a different >>> cgroup and removing the old

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Glauber Costa
On 04/03/2013 07:29 PM, Michal Hocko wrote: On Wed 03-04-13 16:58:48, Glauber Costa wrote: On 04/03/2013 01:11 PM, Li Zefan wrote: Use css_get/css_put instead of mem_cgroup_get/put. Note, if at the same time someone is moving @current to a different cgroup and removing the old cgroup,

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Michal Hocko
On Fri 05-04-13 12:08:40, Glauber Costa wrote: On 04/03/2013 07:29 PM, Michal Hocko wrote: On Wed 03-04-13 16:58:48, Glauber Costa wrote: On 04/03/2013 01:11 PM, Li Zefan wrote: Use css_get/css_put instead of mem_cgroup_get/put. Note, if at the same time someone is moving @current to a

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Michal Hocko
On Wed 03-04-13 17:11:37, Li Zefan wrote: Use css_get/css_put instead of mem_cgroup_get/put. Note, if at the same time someone is moving @current to a different cgroup and removing the old cgroup, css_tryget() may return false, and sock-sk_cgrp won't be initialized. Signed-off-by: Li

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-05 Thread Glauber Costa
OK, I guess I understand. Thanks for the clarification, Galuber! You're welcome Mihcal! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-04 Thread Kamezawa Hiroyuki
(2013/04/03 18:11), Li Zefan wrote: > Use css_get/css_put instead of mem_cgroup_get/put. > > Note, if at the same time someone is moving @current to a different > cgroup and removing the old cgroup, css_tryget() may return false, > and sock->sk_cgrp won't be initialized. > > Signed-off-by: Li

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-04 Thread Kamezawa Hiroyuki
(2013/04/03 18:11), Li Zefan wrote: Use css_get/css_put instead of mem_cgroup_get/put. Note, if at the same time someone is moving @current to a different cgroup and removing the old cgroup, css_tryget() may return false, and sock-sk_cgrp won't be initialized. Signed-off-by: Li Zefan

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-03 Thread Michal Hocko
On Wed 03-04-13 16:58:48, Glauber Costa wrote: > On 04/03/2013 01:11 PM, Li Zefan wrote: > > Use css_get/css_put instead of mem_cgroup_get/put. > > > > Note, if at the same time someone is moving @current to a different > > cgroup and removing the old cgroup, css_tryget() may return false, > >

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-03 Thread Glauber Costa
On 04/03/2013 01:11 PM, Li Zefan wrote: > Use css_get/css_put instead of mem_cgroup_get/put. > > Note, if at the same time someone is moving @current to a different > cgroup and removing the old cgroup, css_tryget() may return false, > and sock->sk_cgrp won't be initialized. > > Signed-off-by:

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-03 Thread Glauber Costa
On 04/03/2013 01:11 PM, Li Zefan wrote: Use css_get/css_put instead of mem_cgroup_get/put. Note, if at the same time someone is moving @current to a different cgroup and removing the old cgroup, css_tryget() may return false, and sock-sk_cgrp won't be initialized. Signed-off-by: Li Zefan

Re: [RFC][PATCH 1/7] memcg: use css_get in sock_update_memcg()

2013-04-03 Thread Michal Hocko
On Wed 03-04-13 16:58:48, Glauber Costa wrote: On 04/03/2013 01:11 PM, Li Zefan wrote: Use css_get/css_put instead of mem_cgroup_get/put. Note, if at the same time someone is moving @current to a different cgroup and removing the old cgroup, css_tryget() may return false, and