Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 14:17:28 +0100 Petr Mladek wrote: > > @@ -334,10 +297,7 @@ int trace_seq_putmem_hex(struct trace_seq *s, const > > void *mem, > > /* j increments twice per loop */ > > len -= j / 2; > > hex[j++] = ' '; > > - > > - cnt +=

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 09:53:39 -0500 Steven Rostedt wrote: > > > @@ -334,10 +297,7 @@ int trace_seq_putmem_hex(struct trace_seq *s, const > > > void *mem, > > > /* j increments twice per loop */ > > > len -= j / 2; > > > hex[j++] = ' '; > > > - > > > - cnt

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 14:17:28 +0100 Petr Mladek wrote: > > -int trace_seq_putmem_hex(struct trace_seq *s, const void *mem, > > +void trace_seq_putmem_hex(struct trace_seq *s, const void *mem, > > unsigned int len) > > { > > unsigned char hex[HEX_CHARS]; > > const

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Petr Mladek
On Thu 2014-11-13 20:12:56, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > The trace_seq_printf() and friends are used to store strings into a buffer > that can be passed around from function to function. If the trace_seq buffer > fills up, it will not print any more. The return

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Petr Mladek
On Thu 2014-11-13 20:12:56, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org The trace_seq_printf() and friends are used to store strings into a buffer that can be passed around from function to function. If the trace_seq buffer fills up, it will not print any more.

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 14:17:28 +0100 Petr Mladek pmla...@suse.cz wrote: -int trace_seq_putmem_hex(struct trace_seq *s, const void *mem, +void trace_seq_putmem_hex(struct trace_seq *s, const void *mem, unsigned int len) { unsigned char hex[HEX_CHARS]; const

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 09:53:39 -0500 Steven Rostedt rost...@goodmis.org wrote: @@ -334,10 +297,7 @@ int trace_seq_putmem_hex(struct trace_seq *s, const void *mem, /* j increments twice per loop */ len -= j / 2; hex[j++] = ' '; - - cnt +=

Re: [RFC][PATCH 12/23 v4] tracing: Remove return values of most trace_seq_*() functions

2014-11-14 Thread Steven Rostedt
On Fri, 14 Nov 2014 14:17:28 +0100 Petr Mladek pmla...@suse.cz wrote: @@ -334,10 +297,7 @@ int trace_seq_putmem_hex(struct trace_seq *s, const void *mem, /* j increments twice per loop */ len -= j / 2; hex[j++] = ' '; - - cnt +=