Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Mon, 5 Oct 2015 19:09:14 +0200 "Luis R. Rodriguez" wrote: > On Sun, Oct 04, 2015 at 09:02:04PM +0200, Arnd Bergmann wrote: > > On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > > > in

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Mon, 5 Oct 2015 19:09:14 +0200 "Luis R. Rodriguez" wrote: > On Sun, Oct 04, 2015 at 09:02:04PM +0200, Arnd Bergmann wrote: > > On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > > > > > Hmm, my gut feeling tells me that your approach won't solve the

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sun, Oct 04, 2015 at 09:02:04PM +0200, Arnd Bergmann wrote: > On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > > in general. s390 PCI is just weird in many ways and it will occasionally > > >

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sat, Oct 03, 2015 at 05:14:20PM -0700, Randy Dunlap wrote: > On 10/02/15 16:17, Luis R. Rodriguez wrote: > > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: > >> On 08/28/15 17:17, Luis R. Rodriguez wrote: > >>> > >>> arch/s390/Kconfig | 8 + > >>>

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sun, Oct 04, 2015 at 09:02:04PM +0200, Arnd Bergmann wrote: > On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > > in general. s390 PCI is just weird in many ways and it will occasionally > > >

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sat, Oct 03, 2015 at 05:14:20PM -0700, Randy Dunlap wrote: > On 10/02/15 16:17, Luis R. Rodriguez wrote: > > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: > >> On 08/28/15 17:17, Luis R. Rodriguez wrote: > >>> > >>> arch/s390/Kconfig | 8 + > >>>

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > in general. s390 PCI is just weird in many ways and it will occasionally > > suffer from problems like this (as do other aspects of the s390

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Saturday 03 October 2015 01:53:46 Luis R. Rodriguez wrote: > > > > Hmm, my gut feeling tells me that your approach won't solve the problem > > in general. s390 PCI is just weird in many ways and it will occasionally > > suffer from problems like this (as do other aspects of the s390

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On 10/02/15 16:17, Luis R. Rodriguez wrote: > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: >> On 08/28/15 17:17, Luis R. Rodriguez wrote: >>> >>> arch/s390/Kconfig | 8 + >>> arch/s390/include/asm/io.h| 11 --- >>> arch/s390/include/asm/pci.h

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On 10/02/15 16:17, Luis R. Rodriguez wrote: > On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: >> On 08/28/15 17:17, Luis R. Rodriguez wrote: >>> >>> arch/s390/Kconfig | 8 + >>> arch/s390/include/asm/io.h| 11 --- >>> arch/s390/include/asm/pci.h

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Fri, Sep 11, 2015 at 10:14:09AM +0200, Martin Schwidefsky wrote: > On Tue, 08 Sep 2015 15:42:40 +0200 > Arnd Bergmann wrote: > > > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > > On Friday 28 August

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Tue, Sep 08, 2015 at 03:42:40PM +0200, Arnd Bergmann wrote: > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > > While at it, as with the

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: > On 08/28/15 17:17, Luis R. Rodriguez wrote: > > > > arch/s390/Kconfig | 8 + > > arch/s390/include/asm/io.h| 11 --- > > arch/s390/include/asm/pci.h | 2 -- > >

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Fri, Aug 28, 2015 at 07:13:08PM -0700, Randy Dunlap wrote: > On 08/28/15 17:17, Luis R. Rodriguez wrote: > > > > arch/s390/Kconfig | 8 + > > arch/s390/include/asm/io.h| 11 --- > > arch/s390/include/asm/pci.h | 2 -- > >

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Tue, Sep 08, 2015 at 03:42:40PM +0200, Arnd Bergmann wrote: > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > > While at it, as with the

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Fri, Sep 11, 2015 at 10:14:09AM +0200, Martin Schwidefsky wrote: > On Tue, 08 Sep 2015 15:42:40 +0200 > Arnd Bergmann wrote: > > > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > > On

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Tue, 08 Sep 2015 15:42:40 +0200 Arnd Bergmann wrote: > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > > While at it, as with the

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Tue, 08 Sep 2015 15:42:40 +0200 Arnd Bergmann wrote: > On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > > While at it, as

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > While at it, as with the ioremap*() variants, since we have no clear > > > semantics yet well

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Wed, Sep 2, 2015 at 6:47 PM, Luis R. Rodriguez wrote: > On Wed, Sep 2, 2015 at 6:44 PM, Luis R. Rodriguez wrote: >>> I don't think we really need to spell it out here. s390 PCI is different >>> from everybody else's in a lot of ways, so a simple 'depends on PCI && >>> !S390' for

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Wed, Sep 2, 2015 at 6:47 PM, Luis R. Rodriguez wrote: > On Wed, Sep 2, 2015 at 6:44 PM, Luis R. Rodriguez wrote: >>> I don't think we really need to spell it out here. s390 PCI is different >>> from everybody else's in a lot of ways, so a simple

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Thursday 03 September 2015 03:44:15 Luis R. Rodriguez wrote: > On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > > While at it, as with the ioremap*() variants, since we have no clear > > > semantics yet well

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Wed, Sep 2, 2015 at 6:44 PM, Luis R. Rodriguez wrote: >> I don't think we really need to spell it out here. s390 PCI is different >> from everybody else's in a lot of ways, so a simple 'depends on PCI && >> !S390' for CONFIG_PCI_IOMAP seems simpler and more intuitive. > > Sure that would work

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sat, Aug 29, 2015 at 08:25:05AM -0700, Christoph Hellwig wrote: > On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > The S390 architecture requires a custom pci_iomap() implementation > > as the asm-generic implementation assumes there are

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > The S390 architecture requires a custom pci_iomap() implementation > > as the asm-generic implementation assumes there are

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Wed, Sep 2, 2015 at 6:44 PM, Luis R. Rodriguez wrote: >> I don't think we really need to spell it out here. s390 PCI is different >> from everybody else's in a lot of ways, so a simple 'depends on PCI && >> !S390' for CONFIG_PCI_IOMAP seems simpler and more intuitive. > > Sure

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sun, Aug 30, 2015 at 09:30:26PM +0200, Arnd Bergmann wrote: > On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > The S390 architecture requires a custom pci_iomap() implementation > > as the asm-generic implementation assumes

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Sat, Aug 29, 2015 at 08:25:05AM -0700, Christoph Hellwig wrote: > On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > > > > The S390 architecture requires a custom pci_iomap() implementation > > as the asm-generic implementation

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > The S390 architecture requires a custom pci_iomap() implementation > as the asm-generic implementation assumes there are disjunctions > between PCI BARs, and on S390 PCI BAR are not disjunctive, S390

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Friday 28 August 2015 17:17:27 Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com The S390 architecture requires a custom pci_iomap() implementation as the asm-generic implementation assumes there are disjunctions between PCI BARs, and on S390 PCI BAR are not disjunctive,

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > The S390 architecture requires a custom pci_iomap() implementation > as the asm-generic implementation assumes there are disjunctions > between PCI BARs, and on S390 PCI BAR are not disjunctive,

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On Fri, Aug 28, 2015 at 05:17:27PM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com The S390 architecture requires a custom pci_iomap() implementation as the asm-generic implementation assumes there are disjunctions between PCI BARs, and on S390 PCI BAR are not

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On 08/28/15 17:17, Luis R. Rodriguez wrote: > > arch/s390/Kconfig | 8 + > arch/s390/include/asm/io.h| 11 --- > arch/s390/include/asm/pci.h | 2 -- > arch/s390/include/asm/pci_iomap.h | 33 + > arch/s390/pci/pci.c | 2 ++

Re: [RFC] asm-generic/pci_iomap.h: make custom PCI BAR requirements explicit

On 08/28/15 17:17, Luis R. Rodriguez wrote: arch/s390/Kconfig | 8 + arch/s390/include/asm/io.h| 11 --- arch/s390/include/asm/pci.h | 2 -- arch/s390/include/asm/pci_iomap.h | 33 + arch/s390/pci/pci.c | 2 ++