Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Andy Lutomirski
On Mon, Nov 13, 2017 at 6:28 PM, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 6:25 PM, Andy Lutomirski wrote: >> On Mon, Nov 13, 2017 at 11:36 AM, Linus Torvalds >> wrote: >>> >>> I forget what the actual size is,

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Andy Lutomirski
On Mon, Nov 13, 2017 at 6:28 PM, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 6:25 PM, Andy Lutomirski wrote: >> On Mon, Nov 13, 2017 at 11:36 AM, Linus Torvalds >> wrote: >>> >>> I forget what the actual size is, but aligning the hardware TSS struct >>> to 128 bytes might be sufficient.

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 6:25 PM, Andy Lutomirski wrote: > On Mon, Nov 13, 2017 at 11:36 AM, Linus Torvalds > wrote: >> >> I forget what the actual size is, but aligning the hardware TSS struct >> to 128 bytes might be sufficient. It's not that big.

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 6:25 PM, Andy Lutomirski wrote: > On Mon, Nov 13, 2017 at 11:36 AM, Linus Torvalds > wrote: >> >> I forget what the actual size is, but aligning the hardware TSS struct >> to 128 bytes might be sufficient. It's not that big. > > 104 bytes, so it's probably already fine.

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Andy Lutomirski
On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen wrote: > On 11/10/2017 08:05 PM, Andy Lutomirski wrote: >> diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h >> index fbc9b7f4e35e..8a9ba5553cab 100644 >> --- a/arch/x86/include/asm/fixmap.h >> +++

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Andy Lutomirski
On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen wrote: > On 11/10/2017 08:05 PM, Andy Lutomirski wrote: >> diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h >> index fbc9b7f4e35e..8a9ba5553cab 100644 >> --- a/arch/x86/include/asm/fixmap.h >> +++

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Andy Lutomirski
On Mon, Nov 13, 2017 at 11:36 AM, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen wrote: >> >> Aha, and here's the place that you need sizeof(tss_struct) to be nice >> and page-aligned. > > No, it should _not_ be

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Andy Lutomirski
On Mon, Nov 13, 2017 at 11:36 AM, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen wrote: >> >> Aha, and here's the place that you need sizeof(tss_struct) to be nice >> and page-aligned. > > No, it should _not_ be page-aligned. It should fit _within_ a page, > but it 'struct

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen wrote: > > Aha, and here's the place that you need sizeof(tss_struct) to be nice > and page-aligned. No, it should _not_ be page-aligned. It should fit _within_ a page, but it 'struct tss_struct' now has something else in front

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 11:22 AM, Dave Hansen wrote: > > Aha, and here's the place that you need sizeof(tss_struct) to be nice > and page-aligned. No, it should _not_ be page-aligned. It should fit _within_ a page, but it 'struct tss_struct' now has something else in front of it, then

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Dave Hansen
On 11/10/2017 08:05 PM, Andy Lutomirski wrote: > diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h > index fbc9b7f4e35e..8a9ba5553cab 100644 > --- a/arch/x86/include/asm/fixmap.h > +++ b/arch/x86/include/asm/fixmap.h > @@ -52,6 +52,13 @@ extern unsigned long __FIXADDR_TOP;

Re: [RFC 6/7] x86/asm: Remap the TSS into the cpu entry area

2017-11-13 Thread Dave Hansen
On 11/10/2017 08:05 PM, Andy Lutomirski wrote: > diff --git a/arch/x86/include/asm/fixmap.h b/arch/x86/include/asm/fixmap.h > index fbc9b7f4e35e..8a9ba5553cab 100644 > --- a/arch/x86/include/asm/fixmap.h > +++ b/arch/x86/include/asm/fixmap.h > @@ -52,6 +52,13 @@ extern unsigned long __FIXADDR_TOP;