Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

>> >> The events are not lost. > > In sas_queue_event(), if there is a particular event pending for a port/PHY, > we cannot queue further same event types for that port/PHY. I think my > colleagues found issue where we try to enqueue multiple complementary events. Yes， we found this issue in

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

>> >> The events are not lost. > > In sas_queue_event(), if there is a particular event pending for a port/PHY, > we cannot queue further same event types for that port/PHY. I think my > colleagues found issue where we try to enqueue multiple complementary events. Yes， we found this issue in

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 21/11/2016 17:13, Dan Williams wrote: On Mon, Nov 21, 2016 at 7:16 AM, John Garry wrote: @Maintainers, would you be willing to accept this patch as an interim fix for the dastardly WARN while we try to fix the flutter issue? To me this adds a bug to quiet a

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 21/11/2016 17:13, Dan Williams wrote: On Mon, Nov 21, 2016 at 7:16 AM, John Garry wrote: @Maintainers, would you be willing to accept this patch as an interim fix for the dastardly WARN while we try to fix the flutter issue? To me this adds a bug to quiet a benign, albeit noisy,

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Mon, Nov 21, 2016 at 7:16 AM, John Garry wrote: > @Maintainers, would you be willing to accept this patch as an interim > fix > for the dastardly WARN while we try to fix the flutter issue? To me this adds a bug to quiet a benign, albeit

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Mon, Nov 21, 2016 at 7:16 AM, John Garry wrote: > @Maintainers, would you be willing to accept this patch as an interim > fix > for the dastardly WARN while we try to fix the flutter issue? To me this adds a bug to quiet a benign, albeit noisy, warning. >>>

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

@Maintainers, would you be willing to accept this patch as an interim fix for the dastardly WARN while we try to fix the flutter issue? To me this adds a bug to quiet a benign, albeit noisy, warning. What is the bug which is being added? The bug where we queue a port teardown, but see a

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

@Maintainers, would you be willing to accept this patch as an interim fix for the dastardly WARN while we try to fix the flutter issue? To me this adds a bug to quiet a benign, albeit noisy, warning. What is the bug which is being added? The bug where we queue a port teardown, but see a

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Fri, Nov 18, 2016 at 1:00 AM, John Garry wrote: > On 18/11/2016 01:53, Dan Williams wrote: >> >> On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: >>> >>> On 11/11/2016 08:49, wangyijing wrote: >>> >>> >>> I have not seen the flutter

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Fri, Nov 18, 2016 at 1:00 AM, John Garry wrote: > On 18/11/2016 01:53, Dan Williams wrote: >> >> On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: >>> >>> On 11/11/2016 08:49, wangyijing wrote: >>> >>> >>> I have not seen the flutter issue. I am just trying to solve the >>>

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 18/11/2016 01:53, Dan Williams wrote: On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: On 11/11/2016 08:49, wangyijing wrote: I have not seen the flutter issue. I am just trying to solve the horrible WARN dump. However I do understand that there may be a issue

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 18/11/2016 01:53, Dan Williams wrote: On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: On 11/11/2016 08:49, wangyijing wrote: I have not seen the flutter issue. I am just trying to solve the horrible WARN dump. However I do understand that there may be a issue related to how we queue

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: > On 11/11/2016 08:49, wangyijing wrote: > > I have not seen the flutter issue. I am just trying to solve the > horrible WARN dump. > However I do understand that there may be a issue related to how we >

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Thu, Nov 17, 2016 at 7:23 AM, John Garry wrote: > On 11/11/2016 08:49, wangyijing wrote: > > I have not seen the flutter issue. I am just trying to solve the > horrible WARN dump. > However I do understand that there may be a issue related to how we > queue the events;

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

> "John" == John Garry writes: John> @Maintainers, would you be willing to accept this patch as an John> interim fix for the dastardly WARN while we try to fix the flutter John> issue? I'll defer to James since I don't have much libsas experience. -- Martin K.

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

> "John" == John Garry writes: John> @Maintainers, would you be willing to accept this patch as an John> interim fix for the dastardly WARN while we try to fix the flutter John> issue? I'll defer to James since I don't have much libsas experience. -- Martin K. Petersen Oracle Linux

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 11/11/2016 08:49, wangyijing wrote: I have not seen the flutter issue. I am just trying to solve the horrible WARN dump. However I do understand that there may be a issue related to how we queue the events; there was a recent attempt to fix this, but it came to nothing:

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 11/11/2016 08:49, wangyijing wrote: I have not seen the flutter issue. I am just trying to solve the horrible WARN dump. However I do understand that there may be a issue related to how we queue the events; there was a recent attempt to fix this, but it came to nothing:

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

>>> I have not seen the flutter issue. I am just trying to solve the horrible >>> WARN dump. >>> However I do understand that there may be a issue related to how we queue >>> the events; there was a recent attempt to fix this, but it came to nothing: >>>

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

>>> I have not seen the flutter issue. I am just trying to solve the horrible >>> WARN dump. >>> However I do understand that there may be a issue related to how we queue >>> the events; there was a recent attempt to fix this, but it came to nothing: >>>

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 11/11/2016 08:12, wangyijing wrote: They're not the same. I don't see how your solution properly deals with remote sas_port deletion. When we unplug a device connected to an expander, can't the sas_port be deleted twice, in sas_unregister_devs_sas_addr() from domain revalidation and also

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 11/11/2016 08:12, wangyijing wrote: They're not the same. I don't see how your solution properly deals with remote sas_port deletion. When we unplug a device connected to an expander, can't the sas_port be deleted twice, in sas_unregister_devs_sas_addr() from domain revalidation and also

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

> > They're not the same. I don't see how your solution properly deals with > remote sas_port deletion. > > When we unplug a device connected to an expander, can't the sas_port be > deleted twice, in sas_unregister_devs_sas_addr() from domain revalidation and > also now in

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

> > They're not the same. I don't see how your solution properly deals with > remote sas_port deletion. > > When we unplug a device connected to an expander, can't the sas_port be > deleted twice, in sas_unregister_devs_sas_addr() from domain revalidation and > also now in

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 09/11/2016 20:35, Dan Williams wrote: On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams wrote: On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: On 09/11/2016 12:28, John Garry wrote: On 03/11/2016 14:58, John Garry wrote: The following

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 09/11/2016 20:35, Dan Williams wrote: On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams wrote: On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: On 09/11/2016 12:28, John Garry wrote: On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying WARN when a device is

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams wrote: > On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: >> On 09/11/2016 12:28, John Garry wrote: >>> >>> On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams wrote: > On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: >> On 09/11/2016 12:28, John Garry wrote: >>> >>> On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying WARN when a device is removed from the SAS

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: > On 09/11/2016 12:28, John Garry wrote: >> >> On 03/11/2016 14:58, John Garry wrote: >>> >>> The following patch introduces an annoying WARN >>> when a device is removed from the SAS topology: >>> [SCSI] libsas: prevent

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On Wed, Nov 9, 2016 at 9:36 AM, John Garry wrote: > On 09/11/2016 12:28, John Garry wrote: >> >> On 03/11/2016 14:58, John Garry wrote: >>> >>> The following patch introduces an annoying WARN >>> when a device is removed from the SAS topology: >>> [SCSI] libsas: prevent domain rediscovery

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying WARN when a device is removed from the SAS topology: [SCSI] libsas: prevent domain rediscovery competing with ata error handling Are there any views on this patch? I would have thought that the parties who use

Re: [RFC PATCH] scsi: libsas: fix WARN on device removal

On 03/11/2016 14:58, John Garry wrote: The following patch introduces an annoying WARN when a device is removed from the SAS topology: [SCSI] libsas: prevent domain rediscovery competing with ata error handling Are there any views on this patch? I would have thought that the parties who use