Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Wang Nan
On 2015/5/6 12:56, Alexei Starovoitov wrote: > On 5/5/15 9:46 PM, Wang Nan wrote: >> Hi Alexei Starovoitov, >> >> Have you ever read this mail? > > please don't top post. > all makes sense and your use case fits quite well into existing bpf+kprobe model. I'm not sure why you're calling

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Alexei Starovoitov
On 5/5/15 9:46 PM, Wang Nan wrote: Hi Alexei Starovoitov, Have you ever read this mail? please don't top post. all makes sense and your use case fits quite well into existing bpf+kprobe model. I'm not sure why you're calling a 'problem'. A problem of how to display that call stack from

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Wang Nan
Hi Alexei Starovoitov, Have you ever read this mail? I'm very intrerested in triggering perf sample in BPF code. You said it is not a problem. Could you please give me some further information? Thank you. On 2015/5/5 14:14, Wang Nan wrote: > On 2015/5/5 13:49, Alexei Starovoitov wrote: >> On

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Brendan Gregg
On Thu, Apr 30, 2015 at 3:52 AM, Wang Nan wrote: [...] > An example is pasted at the bottom of this cover letter. In that > example, mybpfprog is configured by string in config section, and will > be probed at __alloc_pages_nodemask. sample_bpf.o is generated using: > > $ $CLANG

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Arnaldo Carvalho de Melo
Em Fri, May 01, 2015 at 09:56:23AM -0700, Alexei Starovoitov escreveu: > Anyway, back to my original question about long term home. > where to land 'perf/bpf' branch ? I don't care, but for me to merge it, please go on addressing the comments made in this thread (perf bpf command --args, etc) and

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Wang Nan
On 2015/5/5 13:49, Alexei Starovoitov wrote: > On 5/4/15 9:41 PM, Wang Nan wrote: >> >> That's great. Could you please append the description of 'llvm -s' into your >> README >> or comments? It has cost me a lot of time for dumping eBPF instructions so I >> decide to >> add it into perf... > >

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Wang Nan
Hi Alexei Starovoitov, Have you ever read this mail? I'm very intrerested in triggering perf sample in BPF code. You said it is not a problem. Could you please give me some further information? Thank you. On 2015/5/5 14:14, Wang Nan wrote: On 2015/5/5 13:49, Alexei Starovoitov wrote: On

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Wang Nan
On 2015/5/6 12:56, Alexei Starovoitov wrote: On 5/5/15 9:46 PM, Wang Nan wrote: Hi Alexei Starovoitov, Have you ever read this mail? please don't top post. all makes sense and your use case fits quite well into existing bpf+kprobe model. I'm not sure why you're calling a 'problem'. A

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Alexei Starovoitov
On 5/5/15 9:46 PM, Wang Nan wrote: Hi Alexei Starovoitov, Have you ever read this mail? please don't top post. all makes sense and your use case fits quite well into existing bpf+kprobe model. I'm not sure why you're calling a 'problem'. A problem of how to display that call stack from

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Arnaldo Carvalho de Melo
Em Fri, May 01, 2015 at 09:56:23AM -0700, Alexei Starovoitov escreveu: Anyway, back to my original question about long term home. where to land 'perf/bpf' branch ? I don't care, but for me to merge it, please go on addressing the comments made in this thread (perf bpf command --args, etc) and

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Wang Nan
On 2015/5/5 13:49, Alexei Starovoitov wrote: On 5/4/15 9:41 PM, Wang Nan wrote: That's great. Could you please append the description of 'llvm -s' into your README or comments? It has cost me a lot of time for dumping eBPF instructions so I decide to add it into perf... sure. it's just

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-05 Thread Brendan Gregg
On Thu, Apr 30, 2015 at 3:52 AM, Wang Nan wangn...@huawei.com wrote: [...] An example is pasted at the bottom of this cover letter. In that example, mybpfprog is configured by string in config section, and will be probed at __alloc_pages_nodemask. sample_bpf.o is generated using: $ $CLANG

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-04 Thread Alexei Starovoitov
On 5/4/15 9:41 PM, Wang Nan wrote: That's great. Could you please append the description of 'llvm -s' into your README or comments? It has cost me a lot of time for dumping eBPF instructions so I decide to add it into perf... sure. it's just -filetype=asm flag to llc instead of

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-04 Thread Wang Nan
On 2015/5/5 11:02, Alexei Starovoitov wrote: > On 5/2/15 12:19 AM, Wang Nan wrote: >> >> I'd like to do following works in the next version (based on my experience >> and feedbacks): >> >> 1. Safely clean up kprobe points after unloading; >> >> 2. Add subcommand space to 'perf bpf'. Current staff

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-04 Thread Alexei Starovoitov
On 5/2/15 12:19 AM, Wang Nan wrote: I'd like to do following works in the next version (based on my experience and feedbacks): 1. Safely clean up kprobe points after unloading; 2. Add subcommand space to 'perf bpf'. Current staff should be reside in 'perf bpf load'; 3. Extract eBPF ELF

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-04 Thread Alexei Starovoitov
On 5/2/15 12:19 AM, Wang Nan wrote: I'd like to do following works in the next version (based on my experience and feedbacks): 1. Safely clean up kprobe points after unloading; 2. Add subcommand space to 'perf bpf'. Current staff should be reside in 'perf bpf load'; 3. Extract eBPF ELF

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-04 Thread Wang Nan
On 2015/5/5 11:02, Alexei Starovoitov wrote: On 5/2/15 12:19 AM, Wang Nan wrote: I'd like to do following works in the next version (based on my experience and feedbacks): 1. Safely clean up kprobe points after unloading; 2. Add subcommand space to 'perf bpf'. Current staff should be

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-04 Thread Alexei Starovoitov
On 5/4/15 9:41 PM, Wang Nan wrote: That's great. Could you please append the description of 'llvm -s' into your README or comments? It has cost me a lot of time for dumping eBPF instructions so I decide to add it into perf... sure. it's just -filetype=asm flag to llc instead of

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-02 Thread Wang Nan
On 2015/5/1 12:37, Alexei Starovoitov wrote: > On 4/30/15 3:52 AM, Wang Nan wrote: >> This series of patches is an approach to integrate eBPF with perf. >> After applying these patches, users are allowed to use following >> command to load eBPF program compiled by LLVM into kernel: >> >> $ perf

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-02 Thread Wang Nan
On 2015/5/1 12:37, Alexei Starovoitov wrote: On 4/30/15 3:52 AM, Wang Nan wrote: This series of patches is an approach to integrate eBPF with perf. After applying these patches, users are allowed to use following command to load eBPF program compiled by LLVM into kernel: $ perf bpf

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Ingo Molnar
* Alexei Starovoitov wrote: > On 5/1/15 4:49 AM, Ingo Molnar wrote: > > > >* Peter Zijlstra wrote: > > > >>On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: > >>>We're also working in parallel on creating a new tracing language > >>>that together with llvm backend can be used

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Alexei Starovoitov
On 5/1/15 4:49 AM, Ingo Molnar wrote: * Peter Zijlstra wrote: On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: We're also working in parallel on creating a new tracing language that together with llvm backend can be used as a single shared library that can be called from

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: > > We're also working in parallel on creating a new tracing language > > that together with llvm backend can be used as a single shared library > > that can be called from perf or anything else. > >

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Peter Zijlstra
On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: > We're also working in parallel on creating a new tracing language > that together with llvm backend can be used as a single shared library > that can be called from perf or anything else. Gurgh, please also keep normal C an

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Ingo Molnar
* Wang Nan wrote: > This series of patches is an approach to integrate eBPF with perf. Very promising! > After applying these patches, users are allowed to use following > command to load eBPF program compiled by LLVM into kernel: > > $ perf bpf sample_bpf.o Please keep space for a

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Ingo Molnar
* Wang Nan wangn...@huawei.com wrote: This series of patches is an approach to integrate eBPF with perf. Very promising! After applying these patches, users are allowed to use following command to load eBPF program compiled by LLVM into kernel: $ perf bpf sample_bpf.o Please keep space

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Alexei Starovoitov
On 5/1/15 4:49 AM, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: We're also working in parallel on creating a new tracing language that together with llvm backend can be used as a single shared library that

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Ingo Molnar
* Alexei Starovoitov a...@plumgrid.com wrote: On 5/1/15 4:49 AM, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: We're also working in parallel on creating a new tracing language that together with llvm

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Peter Zijlstra
On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: We're also working in parallel on creating a new tracing language that together with llvm backend can be used as a single shared library that can be called from perf or anything else. Gurgh, please also keep normal C an

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-05-01 Thread Ingo Molnar
* Peter Zijlstra pet...@infradead.org wrote: On Thu, Apr 30, 2015 at 09:37:04PM -0700, Alexei Starovoitov wrote: We're also working in parallel on creating a new tracing language that together with llvm backend can be used as a single shared library that can be called from perf or

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-04-30 Thread Alexei Starovoitov
On 4/30/15 3:52 AM, Wang Nan wrote: This series of patches is an approach to integrate eBPF with perf. After applying these patches, users are allowed to use following command to load eBPF program compiled by LLVM into kernel: $ perf bpf sample_bpf.o The required BPF code and the loading

Re: [RFC PATCH 00/22] perf tools: introduce 'perf bpf' command to load eBPF programs.

2015-04-30 Thread Alexei Starovoitov
On 4/30/15 3:52 AM, Wang Nan wrote: This series of patches is an approach to integrate eBPF with perf. After applying these patches, users are allowed to use following command to load eBPF program compiled by LLVM into kernel: $ perf bpf sample_bpf.o The required BPF code and the loading