Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-05 Thread Moger, Babu
Hi James, On 10/05/2018 11:20 AM, James Morse wrote: > Hi Babu, > > On 24/09/18 20:19, Moger, Babu wrote: >> Enables QOS feature on AMD. >> Following QoS sub-features are supported in AMD if the underlying >> hardware supports it. >> - L3 Cache allocation enforcement >> - L3 Cache occupancy

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-05 Thread Moger, Babu
Hi James, On 10/05/2018 11:20 AM, James Morse wrote: > Hi Babu, > > On 24/09/18 20:19, Moger, Babu wrote: >> Enables QOS feature on AMD. >> Following QoS sub-features are supported in AMD if the underlying >> hardware supports it. >> - L3 Cache allocation enforcement >> - L3 Cache occupancy

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-05 Thread James Morse
Hi Babu, On 24/09/18 20:19, Moger, Babu wrote: > Enables QOS feature on AMD. > Following QoS sub-features are supported in AMD if the underlying > hardware supports it. > - L3 Cache allocation enforcement > - L3 Cache occupancy monitoring > - L3 Code-Data Prioritization support > - Memory

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-05 Thread James Morse
Hi Babu, On 24/09/18 20:19, Moger, Babu wrote: > Enables QOS feature on AMD. > Following QoS sub-features are supported in AMD if the underlying > hardware supports it. > - L3 Cache allocation enforcement > - L3 Cache occupancy monitoring > - L3 Code-Data Prioritization support > - Memory

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-03 Thread Moger, Babu
Hi Reinette, On 10/02/2018 05:13 PM, Reinette Chatre wrote: > Hi Babu, > > On 9/24/2018 12:19 PM, Moger, Babu wrote: >> +/* >> + * Check whether a cache bit mask is valid. AMD allows >> + * non-contiguous masks. >> + */ >> +bool cbm_validate_amd(char *buf, u32 *data, struct rdt_resource *r) >>

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-03 Thread Moger, Babu
Hi Reinette, On 10/02/2018 05:13 PM, Reinette Chatre wrote: > Hi Babu, > > On 9/24/2018 12:19 PM, Moger, Babu wrote: >> +/* >> + * Check whether a cache bit mask is valid. AMD allows >> + * non-contiguous masks. >> + */ >> +bool cbm_validate_amd(char *buf, u32 *data, struct rdt_resource *r) >>

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-03 Thread Moger, Babu
On 10/02/2018 01:27 PM, Fenghua Yu wrote: > On Mon, Sep 24, 2018 at 07:19:16PM +, Moger, Babu wrote: >> int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d); >> +int parse_bw_amd(void *_buf, struct rdt_resource *r, struct rdt_domain *d); > > Please note the type of _buf

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-03 Thread Moger, Babu
On 10/02/2018 01:27 PM, Fenghua Yu wrote: > On Mon, Sep 24, 2018 at 07:19:16PM +, Moger, Babu wrote: >> int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d); >> +int parse_bw_amd(void *_buf, struct rdt_resource *r, struct rdt_domain *d); > > Please note the type of _buf

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-02 Thread Reinette Chatre
Hi Babu, On 9/24/2018 12:19 PM, Moger, Babu wrote: > +/* > + * Check whether a cache bit mask is valid. AMD allows > + * non-contiguous masks. > + */ > +bool cbm_validate_amd(char *buf, u32 *data, struct rdt_resource *r) > +{ > + unsigned long first_bit, zero_bit, val; > + unsigned int

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-02 Thread Reinette Chatre
Hi Babu, On 9/24/2018 12:19 PM, Moger, Babu wrote: > +/* > + * Check whether a cache bit mask is valid. AMD allows > + * non-contiguous masks. > + */ > +bool cbm_validate_amd(char *buf, u32 *data, struct rdt_resource *r) > +{ > + unsigned long first_bit, zero_bit, val; > + unsigned int

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-02 Thread Fenghua Yu
On Mon, Sep 24, 2018 at 07:19:16PM +, Moger, Babu wrote: > int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d); > +int parse_bw_amd(void *_buf, struct rdt_resource *r, struct rdt_domain *d); Please note the type of _buf in parse_bw() is changed in latest kernel to fix

Re: [RFC PATCH 10/10] arch/x86: Introduce QOS feature for AMD

2018-10-02 Thread Fenghua Yu
On Mon, Sep 24, 2018 at 07:19:16PM +, Moger, Babu wrote: > int parse_bw(void *_buf, struct rdt_resource *r, struct rdt_domain *d); > +int parse_bw_amd(void *_buf, struct rdt_resource *r, struct rdt_domain *d); Please note the type of _buf in parse_bw() is changed in latest kernel to fix