On 07-Jun-20 22:11, Florian Fainelli wrote:
>
>
> On 6/7/2020 7:59 AM, Amit Cohen wrote:
>> Add link extended state attributes.
>>
>> Signed-off-by: Amit Cohen
>> Reviewed-by: Petr Machata
>> Reviewed-by: Jiri Pirko
>
> If you need to resubmit, I would swap the order of patches #4 and #5
>
On Mon, Jun 08, 2020 at 10:02:04AM +, Amit Cohen wrote:
> Andrew Lunn writes:
>
> >> +Link extended states:
> >> +
> >> +
> >> =
> >> + ``Autoneg failure`` Failure during auto negotiation
> >>
Andrew Lunn writes:
>> +Link extended states:
>> +
>> +
>> =
>> + ``Autoneg failure`` Failure during auto negotiation mechanism
>
>I think you need to define 'failure' here.
>
>Linux PHYs don't have this
On 6/7/2020 7:59 AM, Amit Cohen wrote:
> Add link extended state attributes.
>
> Signed-off-by: Amit Cohen
> Reviewed-by: Petr Machata
> Reviewed-by: Jiri Pirko
If you need to resubmit, I would swap the order of patches #4 and #5
such that the documentation comes first.
[snip]
>
>
> +Link extended states:
> +
> +
> =
> + ``Autoneg failure`` Failure during auto negotiation mechanism
I think you need to define 'failure' here.
Linux PHYs don't have this state. auto-neg is either
5 matches
Mail list logo
