Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread Florian Westphal
David Woodhouse wrote: > > > On Fri, 2015-03-06 at 17:37 +0100, Florian Westphal wrote: > > > > > > I did performance measurements in the following way: > > > >  > > > > Removed those pieces of the packet pipeline that I don't necessarily > > > > need one-by-one.  Then

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread Florian Westphal
David Woodhouse wrote: > > > On Fri, 2015-03-06 at 17:37 +0100, Florian Westphal wrote: > > > > > > I did performance measurements in the following way: > > > >  > > > > Removed those pieces of the packet pipeline that I don't necessarily > > > > need one-by-one.  Then measured their effect on

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Woodhouse
On Fri, 2018-03-09 at 10:57 -0500, David Miller wrote: > From: David Woodhouse > Date: Fri, 09 Mar 2018 15:31:15 + > > > Eschewing a 15% speedup on the basis that "well, even though we've had > > three of these already for a decade, we're worried that adding a fourth >

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Woodhouse
On Fri, 2018-03-09 at 10:57 -0500, David Miller wrote: > From: David Woodhouse > Date: Fri, 09 Mar 2018 15:31:15 + > > > Eschewing a 15% speedup on the basis that "well, even though we've had > > three of these already for a decade, we're worried that adding a fourth > > might open the

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Miller
From: David Woodhouse Date: Fri, 09 Mar 2018 15:31:15 + > Eschewing a 15% speedup on the basis that "well, even though we've had > three of these already for a decade, we're worried that adding a fourth > might open the floodgates to further patches" does seem a little

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Miller
From: David Woodhouse Date: Fri, 09 Mar 2018 15:31:15 + > Eschewing a 15% speedup on the basis that "well, even though we've had > three of these already for a decade, we're worried that adding a fourth > might open the floodgates to further patches" does seem a little odd to > me, FWIW.

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Woodhouse
On Fri, 2015-03-06 at 17:37 +0100, Florian Westphal wrote: > > > > I did performance measurements in the following way: > > >  > > > Removed those pieces of the packet pipeline that I don't necessarily > > > need one-by-one.  Then measured their effect on small packet > > > performance. > > > 

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2018-03-09 Thread David Woodhouse
On Fri, 2015-03-06 at 17:37 +0100, Florian Westphal wrote: > > > > I did performance measurements in the following way: > > >  > > > Removed those pieces of the packet pipeline that I don't necessarily > > > need one-by-one.  Then measured their effect on small packet > > > performance. > > > 

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread David Miller
From: Imre Palik Date: Fri, 06 Mar 2015 11:34:29 +0100 > Removed those pieces of the packet pipeline that I don't necessarily > need one-by-one. Then measured their effect on small packet > performance. > > This was the only part that produced considerable effect. > > The pure speculation was

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Fri, Mar 06, 2015 at 11:34:29AM +0100, Imre Palik wrote: > > On 02/26/15 17:34, David Miller wrote: > > > From: Imre Palik > > > Date: Thu, 26 Feb 2015 11:19:25 +0100 > > > > > >> If you are looking for peculiarities in my setup then here they are: > > >> I am on

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread Pablo Neira Ayuso
On Fri, Mar 06, 2015 at 11:34:29AM +0100, Imre Palik wrote: > On 02/26/15 17:34, David Miller wrote: > > From: Imre Palik > > Date: Thu, 26 Feb 2015 11:19:25 +0100 > > > >> If you are looking for peculiarities in my setup then here they are: > >> I am on 4k pages, and perf is not working :-( >

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread Imre Palik
On 02/26/15 17:34, David Miller wrote: > From: Imre Palik > Date: Thu, 26 Feb 2015 11:19:25 +0100 > >> If you are looking for peculiarities in my setup then here they are: >> I am on 4k pages, and perf is not working :-( >> (I am trying to fix those too, but that is far from being a low hanging

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread Pablo Neira Ayuso
On Fri, Mar 06, 2015 at 11:34:29AM +0100, Imre Palik wrote: On 02/26/15 17:34, David Miller wrote: From: Imre Palik im...@amazon.de Date: Thu, 26 Feb 2015 11:19:25 +0100 If you are looking for peculiarities in my setup then here they are: I am on 4k pages, and perf is not working :-(

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread Florian Westphal
Pablo Neira Ayuso pa...@netfilter.org wrote: On Fri, Mar 06, 2015 at 11:34:29AM +0100, Imre Palik wrote: On 02/26/15 17:34, David Miller wrote: From: Imre Palik im...@amazon.de Date: Thu, 26 Feb 2015 11:19:25 +0100 If you are looking for peculiarities in my setup then here they

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread Imre Palik
On 02/26/15 17:34, David Miller wrote: From: Imre Palik im...@amazon.de Date: Thu, 26 Feb 2015 11:19:25 +0100 If you are looking for peculiarities in my setup then here they are: I am on 4k pages, and perf is not working :-( (I am trying to fix those too, but that is far from being a low

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-03-06 Thread David Miller
From: Imre Palik imrep@gmail.com Date: Fri, 06 Mar 2015 11:34:29 +0100 Removed those pieces of the packet pipeline that I don't necessarily need one-by-one. Then measured their effect on small packet performance. This was the only part that produced considerable effect. The pure

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-26 Thread Felix Fietkau
On 2015-02-24 05:06, Florian Westphal wrote: > Imre Palik wrote: >> The netfilter code is made with flexibility instead of performance in mind. >> So when all we want is to pass packets between different interfaces, the >> performance penalty of hitting netfilter code can be considerable, even

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-26 Thread David Miller
From: Imre Palik Date: Thu, 26 Feb 2015 11:19:25 +0100 > If you are looking for peculiarities in my setup then here they are: > I am on 4k pages, and perf is not working :-( > (I am trying to fix those too, but that is far from being a low hanging > fruit.) > So my guess would be that the

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-26 Thread Imre Palik
On 02/23/15 17:06, Florian Westphal wrote: > Imre Palik wrote: >> The netfilter code is made with flexibility instead of performance in mind. >> So when all we want is to pass packets between different interfaces, the >> performance penalty of hitting netfilter code can be considerable, even when

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-26 Thread David Miller
From: Imre Palik im...@amazon.de Date: Thu, 26 Feb 2015 11:19:25 +0100 If you are looking for peculiarities in my setup then here they are: I am on 4k pages, and perf is not working :-( (I am trying to fix those too, but that is far from being a low hanging fruit.) So my guess would be that

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-26 Thread Felix Fietkau
On 2015-02-24 05:06, Florian Westphal wrote: Imre Palik imrep@gmail.com wrote: The netfilter code is made with flexibility instead of performance in mind. So when all we want is to pass packets between different interfaces, the performance penalty of hitting netfilter code can be

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-26 Thread Imre Palik
On 02/23/15 17:06, Florian Westphal wrote: Imre Palik imrep@gmail.com wrote: The netfilter code is made with flexibility instead of performance in mind. So when all we want is to pass packets between different interfaces, the performance penalty of hitting netfilter code can be

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-23 Thread Florian Westphal
Imre Palik wrote: > The netfilter code is made with flexibility instead of performance in mind. > So when all we want is to pass packets between different interfaces, the > performance penalty of hitting netfilter code can be considerable, even when > all the firewalling is disabled for the

Re: [RFC PATCH v2] bridge: make it possible for packets to traverse the bridge without hitting netfilter

2015-02-23 Thread Florian Westphal
Imre Palik imrep@gmail.com wrote: The netfilter code is made with flexibility instead of performance in mind. So when all we want is to pass packets between different interfaces, the performance penalty of hitting netfilter code can be considerable, even when all the firewalling is