Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-16 Thread Madhavan T. Venkataraman
Thanks! Madhavan On 4/16/21 11:17 AM, Mark Brown wrote: > On Thu, Apr 01, 2021 at 10:24:04PM -0500, madve...@linux.microsoft.com wrote: > >> Reliable stacktracing requires that we identify when a stacktrace is >> terminated early. We can do this by ensuring all tasks have a final >> frame

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-16 Thread Mark Brown
On Thu, Apr 01, 2021 at 10:24:04PM -0500, madve...@linux.microsoft.com wrote: > Reliable stacktracing requires that we identify when a stacktrace is > terminated early. We can do this by ensuring all tasks have a final > frame record at a known location on their task stack, and checking > that

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-14 Thread Madhavan T. Venkataraman
Hi Mark Rutland, Mark Brown, Could you take a look at this version for proper stack termination and let me know what you think? Thanks! Madhavan On 4/1/21 10:24 PM, madve...@linux.microsoft.com wrote: > From: "Madhavan T. Venkataraman" > > Reliable stacktracing requires that we identify

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-04 Thread Madhavan T. Venkataraman
On 4/3/21 11:40 PM, Madhavan T. Venkataraman wrote: > > > On 4/3/21 10:46 PM, Madhavan T. Venkataraman wrote: >>> I'm somewhat arm-ignorant, so take the following comments with a grain >>> of salt. >>> >>> >>> I don't think changing these to 'bl' is necessary, unless you wanted >>>

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-03 Thread Madhavan T. Venkataraman
On 4/3/21 10:46 PM, Madhavan T. Venkataraman wrote: >> I'm somewhat arm-ignorant, so take the following comments with a grain >> of salt. >> >> >> I don't think changing these to 'bl' is necessary, unless you wanted >> __primary_switched() and __secondary_switched() to show up in the >>

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-03 Thread Madhavan T. Venkataraman
On 4/3/21 10:59 AM, Josh Poimboeuf wrote: > On Thu, Apr 01, 2021 at 10:24:04PM -0500, madve...@linux.microsoft.com wrote: >> From: "Madhavan T. Venkataraman" >> @@ -447,9 +464,9 @@ SYM_FUNC_START_LOCAL(__primary_switched) >> #endif >> bl switch_to_vhe // Prefer VHE

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-03 Thread Josh Poimboeuf
On Thu, Apr 01, 2021 at 10:24:04PM -0500, madve...@linux.microsoft.com wrote: > From: "Madhavan T. Venkataraman" > @@ -447,9 +464,9 @@ SYM_FUNC_START_LOCAL(__primary_switched) > #endif > bl switch_to_vhe // Prefer VHE if possible > add sp, sp, #16 > -