RE: [RFC PATCH v3] scsi: ufs: Quiesce all scsi devices before shutdown

2020-07-27 Thread Avri Altman
> > Hi Bart, > > On Sat, 2020-07-11 at 20:21 -0700, Bart Van Assche wrote: > > On 2020-07-06 06:22, Stanley Chu wrote: > > > +static void ufshcd_cleanup_queue(struct scsi_device *sdev, void *data) > > > +{ > > > + if (sdev->request_queue) > > > +

Re: [RFC PATCH v3] scsi: ufs: Quiesce all scsi devices before shutdown

2020-07-22 Thread Stanley Chu
Hi Bart, On Sat, 2020-07-11 at 20:21 -0700, Bart Van Assche wrote: > On 2020-07-06 06:22, Stanley Chu wrote: > > +static void ufshcd_cleanup_queue(struct scsi_device *sdev, void *data) > > +{ > > + if (sdev->request_queue) > > + blk_cleanup_queue(sdev->request_queue); > > +} > > No

Re: [RFC PATCH v3] scsi: ufs: Quiesce all scsi devices before shutdown

2020-07-11 Thread Bart Van Assche
On 2020-07-06 06:22, Stanley Chu wrote: > +static void ufshcd_cleanup_queue(struct scsi_device *sdev, void *data) > +{ > + if (sdev->request_queue) > + blk_cleanup_queue(sdev->request_queue); > +} No SCSI LLD should ever call blk_cleanup_queue() directly for sdev->request_queue.

Re: [RFC PATCH v3] scsi: ufs: Quiesce all scsi devices before shutdown

2020-07-11 Thread Stanley Chu
Hi Bart, Avri, May I know if you have any suggestion for this RFC fix? Very appreciated : ) On Mon, 2020-07-06 at 21:22 +0800, Stanley Chu wrote: > Currently I/O request could be still submitted to UFS device while > UFS is working on shutdown flow. This may lead to racing as below > scenarios