Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-17 Thread Dmitry Osipenko
17.07.2020 18:41, Sowjanya Komatineni пишет: ... >> Also, what about the auto-calibration? Isn't it needed to be enabled for >> CSI? > STARTCAL does one time calibration and with AUTOCAL calibration will be > triggered periodically. > > For pads PULLUP/PULLDN/TERM impedance calibration, we only

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-17 Thread Sowjanya Komatineni
On 7/17/20 8:01 AM, Dmitry Osipenko wrote: 17.07.2020 07:46, Sowjanya Komatineni пишет: ... Looks like sequence posted in TRM need to be updated clearly for proper MIPI CAL start and wait. Correct steps should be like below 1. Set up CSI registers for use case such as number of lanes,

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-17 Thread Dmitry Osipenko
17.07.2020 07:46, Sowjanya Komatineni пишет: ... > Looks like sequence posted in TRM need to be updated clearly for proper > MIPI CAL start and wait. > > Correct steps should be like below > > 1. Set up CSI registers for use case such as number of lanes, virtual  > channel, etc. > 2. Initialize

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Sowjanya Komatineni
On 7/16/20 5:16 PM, Sowjanya Komatineni wrote: On 7/16/20 4:47 PM, Dmitry Osipenko wrote: 17.07.2020 02:09, Sowjanya Komatineni пишет: On 7/16/20 4:06 PM, Sowjanya Komatineni wrote: On 7/16/20 4:01 PM, Dmitry Osipenko wrote: 17.07.2020 01:49, Sowjanya Komatineni пишет: What keeps MIPI

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Sowjanya Komatineni
On 7/16/20 4:47 PM, Dmitry Osipenko wrote: 17.07.2020 02:09, Sowjanya Komatineni пишет: On 7/16/20 4:06 PM, Sowjanya Komatineni wrote: On 7/16/20 4:01 PM, Dmitry Osipenko wrote: 17.07.2020 01:49, Sowjanya Komatineni пишет: What keeps MIPI clock enabled after completion of the

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Dmitry Osipenko
17.07.2020 02:09, Sowjanya Komatineni пишет: > > On 7/16/20 4:06 PM, Sowjanya Komatineni wrote: >> >> On 7/16/20 4:01 PM, Dmitry Osipenko wrote: >>> 17.07.2020 01:49, Sowjanya Komatineni пишет: > What keeps MIPI clock enabled after completion of the > tegra_mipi_calibrate() invocation?

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Sowjanya Komatineni
On 7/16/20 2:18 PM, Dmitry Osipenko wrote: 17.07.2020 00:09, Sowjanya Komatineni пишет: On 7/16/20 1:38 PM, Dmitry Osipenko wrote: 15.07.2020 07:20, Sowjanya Komatineni пишет: SW can trigger MIPI pads calibration any time after power on but calibration results will be latched and applied to

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Dmitry Osipenko
17.07.2020 01:49, Sowjanya Komatineni пишет: >> What keeps MIPI clock enabled after completion of the >> tegra_mipi_calibrate() invocation? > > MIPI clock is disabled at end of tegra_mipi_calibrate and is re-enabled > during tegra_mipi_wait. > > I think I should fix this to keep the clock

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Sowjanya Komatineni
On 7/16/20 4:06 PM, Sowjanya Komatineni wrote: On 7/16/20 4:01 PM, Dmitry Osipenko wrote: 17.07.2020 01:49, Sowjanya Komatineni пишет: What keeps MIPI clock enabled after completion of the tegra_mipi_calibrate() invocation? MIPI clock is disabled at end of tegra_mipi_calibrate and is

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Sowjanya Komatineni
On 7/16/20 4:01 PM, Dmitry Osipenko wrote: 17.07.2020 01:49, Sowjanya Komatineni пишет: What keeps MIPI clock enabled after completion of the tegra_mipi_calibrate() invocation? MIPI clock is disabled at end of tegra_mipi_calibrate and is re-enabled during tegra_mipi_wait. I think I should

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Dmitry Osipenko
17.07.2020 00:09, Sowjanya Komatineni пишет: > > On 7/16/20 1:38 PM, Dmitry Osipenko wrote: >> 15.07.2020 07:20, Sowjanya Komatineni пишет: >>> SW can trigger MIPI pads calibration any time after power on >>> but calibration results will be latched and applied to the pads >>> by MIPI CAL unit

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Sowjanya Komatineni
On 7/16/20 1:38 PM, Dmitry Osipenko wrote: 15.07.2020 07:20, Sowjanya Komatineni пишет: SW can trigger MIPI pads calibration any time after power on but calibration results will be latched and applied to the pads by MIPI CAL unit only when the link is in LP-11 state and then status register

Re: [RFC PATCH v3 16/18] gpu: host1x: mipi: Split tegra_mipi_calibrate and tegra_mipi_wait

2020-07-16 Thread Dmitry Osipenko
15.07.2020 07:20, Sowjanya Komatineni пишет: > SW can trigger MIPI pads calibration any time after power on > but calibration results will be latched and applied to the pads > by MIPI CAL unit only when the link is in LP-11 state and then > status register will be updated. > > For CSI, trigger of