Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-04 Thread Hanjun Guo
On 2013年12月04日 01:12, Rob Herring wrote: On Tue, Dec 3, 2013 at 10:36 AM, Hanjun Guo wrote: [...] +#ifndef _ASM_ARM_ACPI_H +#define _ASM_ARM_ACPI_H + +static inline bool arch_has_acpi_pdc(void) +{ + return false; /* always false for now */ +} + +static inline void

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-04 Thread Hanjun Guo
On 2013年12月04日 00:53, One Thousand Gnomes wrote: O> +enum idle_boot_override { IDLE_NO_OVERRIDE = 0, IDLE_HALT, IDLE_NOMWAIT, + IDLE_POLL, IDLE_FORCE_MWAIT }; This should probably move out of the arch directory to be a single enum including both platforms values. That

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-04 Thread Hanjun Guo
On 2013年12月04日 00:53, One Thousand Gnomes wrote: O +enum idle_boot_override { IDLE_NO_OVERRIDE = 0, IDLE_HALT, IDLE_NOMWAIT, + IDLE_POLL, IDLE_FORCE_MWAIT }; This should probably move out of the arch directory to be a single enum including both platforms values. That will

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-04 Thread Hanjun Guo
On 2013年12月04日 01:12, Rob Herring wrote: On Tue, Dec 3, 2013 at 10:36 AM, Hanjun Guo hanjun@linaro.org wrote: [...] +#ifndef _ASM_ARM_ACPI_H +#define _ASM_ARM_ACPI_H + +static inline bool arch_has_acpi_pdc(void) +{ + return false; /* always false for now */ +} + +static inline void

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-03 Thread Rob Herring
On Tue, Dec 3, 2013 at 10:36 AM, Hanjun Guo wrote: > The _PDC (Processor Driver Capabilities) object provides OSPM a > mechanism to convey to the platform the capabilities supported > by OSPM for processor power management. > > OSPM evaluates _PDC prior to evaluating any other processor > power

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-03 Thread One Thousand Gnomes
O> +enum idle_boot_override { IDLE_NO_OVERRIDE = 0, IDLE_HALT, IDLE_NOMWAIT, > + IDLE_POLL, IDLE_FORCE_MWAIT }; This should probably move out of the arch directory to be a single enum including both platforms values. That will make it rather easier to keep sane and avoid

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-03 Thread One Thousand Gnomes
O +enum idle_boot_override { IDLE_NO_OVERRIDE = 0, IDLE_HALT, IDLE_NOMWAIT, + IDLE_POLL, IDLE_FORCE_MWAIT }; This should probably move out of the arch directory to be a single enum including both platforms values. That will make it rather easier to keep sane and avoid ifdefs

Re: [RFC part1 PATCH 4/7] ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64

2013-12-03 Thread Rob Herring
On Tue, Dec 3, 2013 at 10:36 AM, Hanjun Guo hanjun@linaro.org wrote: The _PDC (Processor Driver Capabilities) object provides OSPM a mechanism to convey to the platform the capabilities supported by OSPM for processor power management. OSPM evaluates _PDC prior to evaluating any other