Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-20 Thread Aaron Lu
On Fri, Oct 19, 2018 at 08:00:53AM -0700, Daniel Jordan wrote: > On Fri, Oct 19, 2018 at 09:54:35AM +0100, Mel Gorman wrote: > > On Fri, Oct 19, 2018 at 01:57:03PM +0800, Aaron Lu wrote: > > > > > > > > I don't think this is the right way of thinking about it because it's > > > > possible to have

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-20 Thread Aaron Lu
On Fri, Oct 19, 2018 at 08:00:53AM -0700, Daniel Jordan wrote: > On Fri, Oct 19, 2018 at 09:54:35AM +0100, Mel Gorman wrote: > > On Fri, Oct 19, 2018 at 01:57:03PM +0800, Aaron Lu wrote: > > > > > > > > I don't think this is the right way of thinking about it because it's > > > > possible to have

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-19 Thread Daniel Jordan
On Fri, Oct 19, 2018 at 09:54:35AM +0100, Mel Gorman wrote: > On Fri, Oct 19, 2018 at 01:57:03PM +0800, Aaron Lu wrote: > > > > > > I don't think this is the right way of thinking about it because it's > > > possible to have the system split in such a way so that the migration > > > scanner only

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-19 Thread Daniel Jordan
On Fri, Oct 19, 2018 at 09:54:35AM +0100, Mel Gorman wrote: > On Fri, Oct 19, 2018 at 01:57:03PM +0800, Aaron Lu wrote: > > > > > > I don't think this is the right way of thinking about it because it's > > > possible to have the system split in such a way so that the migration > > > scanner only

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-19 Thread Mel Gorman
On Fri, Oct 19, 2018 at 01:57:03PM +0800, Aaron Lu wrote: > > > > I don't think this is the right way of thinking about it because it's > > possible to have the system split in such a way so that the migration > > scanner only encounters unmovable pages before it meets the free scanner > > where

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-19 Thread Mel Gorman
On Fri, Oct 19, 2018 at 01:57:03PM +0800, Aaron Lu wrote: > > > > I don't think this is the right way of thinking about it because it's > > possible to have the system split in such a way so that the migration > > scanner only encounters unmovable pages before it meets the free scanner > > where

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Aaron Lu
On Thu, Oct 18, 2018 at 12:16:32PM +0100, Mel Gorman wrote: > On Wed, Oct 17, 2018 at 10:59:04PM +0800, Aaron Lu wrote: > > > Any particuular reason why? I assume it's related to the number of zone > > > locks with the increase number of zones and the number of threads used > > > for the test. > >

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Aaron Lu
On Thu, Oct 18, 2018 at 12:16:32PM +0100, Mel Gorman wrote: > On Wed, Oct 17, 2018 at 10:59:04PM +0800, Aaron Lu wrote: > > > Any particuular reason why? I assume it's related to the number of zone > > > locks with the increase number of zones and the number of threads used > > > for the test. > >

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Mel Gorman
On Wed, Oct 17, 2018 at 10:59:04PM +0800, Aaron Lu wrote: > > Any particuular reason why? I assume it's related to the number of zone > > locks with the increase number of zones and the number of threads used > > for the test. > > I think so too. > > The 4 sockets server has 192 CPUs in total

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Mel Gorman
On Wed, Oct 17, 2018 at 10:59:04PM +0800, Aaron Lu wrote: > > Any particuular reason why? I assume it's related to the number of zone > > locks with the increase number of zones and the number of threads used > > for the test. > > I think so too. > > The 4 sockets server has 192 CPUs in total

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Aaron Lu
On Thu, Oct 18, 2018 at 10:23:22AM +0200, Vlastimil Babka wrote: > On 10/18/18 8:48 AM, Aaron Lu wrote: > > On Wed, Oct 17, 2018 at 07:03:30PM +0200, Vlastimil Babka wrote: > >> On 10/17/18 3:58 PM, Mel Gorman wrote: > >>> Again, as compaction is not guaranteed to find the pageblocks, it would >

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Aaron Lu
On Thu, Oct 18, 2018 at 10:23:22AM +0200, Vlastimil Babka wrote: > On 10/18/18 8:48 AM, Aaron Lu wrote: > > On Wed, Oct 17, 2018 at 07:03:30PM +0200, Vlastimil Babka wrote: > >> On 10/17/18 3:58 PM, Mel Gorman wrote: > >>> Again, as compaction is not guaranteed to find the pageblocks, it would >

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Vlastimil Babka
On 10/18/18 8:48 AM, Aaron Lu wrote: > On Wed, Oct 17, 2018 at 07:03:30PM +0200, Vlastimil Babka wrote: >> On 10/17/18 3:58 PM, Mel Gorman wrote: >>> Again, as compaction is not guaranteed to find the pageblocks, it would >>> be important to consider whether a) that matters or b) find an >>>

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Vlastimil Babka
On 10/18/18 8:48 AM, Aaron Lu wrote: > On Wed, Oct 17, 2018 at 07:03:30PM +0200, Vlastimil Babka wrote: >> On 10/17/18 3:58 PM, Mel Gorman wrote: >>> Again, as compaction is not guaranteed to find the pageblocks, it would >>> be important to consider whether a) that matters or b) find an >>>

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Aaron Lu
On Wed, Oct 17, 2018 at 07:03:30PM +0200, Vlastimil Babka wrote: > On 10/17/18 3:58 PM, Mel Gorman wrote: > > Again, as compaction is not guaranteed to find the pageblocks, it would > > be important to consider whether a) that matters or b) find an > > alternative way of keeping unmerged buddies

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-18 Thread Aaron Lu
On Wed, Oct 17, 2018 at 07:03:30PM +0200, Vlastimil Babka wrote: > On 10/17/18 3:58 PM, Mel Gorman wrote: > > Again, as compaction is not guaranteed to find the pageblocks, it would > > be important to consider whether a) that matters or b) find an > > alternative way of keeping unmerged buddies

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Vlastimil Babka
On 10/17/18 3:58 PM, Mel Gorman wrote: > Again, as compaction is not guaranteed to find the pageblocks, it would > be important to consider whether a) that matters or b) find an > alternative way of keeping unmerged buddies on separate lists so they > can be quickly discovered when a high-order

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Vlastimil Babka
On 10/17/18 3:58 PM, Mel Gorman wrote: > Again, as compaction is not guaranteed to find the pageblocks, it would > be important to consider whether a) that matters or b) find an > alternative way of keeping unmerged buddies on separate lists so they > can be quickly discovered when a high-order

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Aaron Lu
On Wed, Oct 17, 2018 at 02:58:07PM +0100, Mel Gorman wrote: > On Wed, Oct 17, 2018 at 09:10:59PM +0800, Aaron Lu wrote: > > On Wed, Oct 17, 2018 at 11:44:27AM +0100, Mel Gorman wrote: > > > On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > > > > Running will-it-scale/page_fault1 process

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Aaron Lu
On Wed, Oct 17, 2018 at 02:58:07PM +0100, Mel Gorman wrote: > On Wed, Oct 17, 2018 at 09:10:59PM +0800, Aaron Lu wrote: > > On Wed, Oct 17, 2018 at 11:44:27AM +0100, Mel Gorman wrote: > > > On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > > > > Running will-it-scale/page_fault1 process

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Mel Gorman
On Wed, Oct 17, 2018 at 09:10:59PM +0800, Aaron Lu wrote: > On Wed, Oct 17, 2018 at 11:44:27AM +0100, Mel Gorman wrote: > > On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > > > Running will-it-scale/page_fault1 process mode workload on a 2 sockets > > > Intel Skylake server showed

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Mel Gorman
On Wed, Oct 17, 2018 at 09:10:59PM +0800, Aaron Lu wrote: > On Wed, Oct 17, 2018 at 11:44:27AM +0100, Mel Gorman wrote: > > On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > > > Running will-it-scale/page_fault1 process mode workload on a 2 sockets > > > Intel Skylake server showed

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Aaron Lu
On Wed, Oct 17, 2018 at 11:44:27AM +0100, Mel Gorman wrote: > On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > > Running will-it-scale/page_fault1 process mode workload on a 2 sockets > > Intel Skylake server showed severe lock contention of zone->lock, as > > high as about 80%(42% on

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Aaron Lu
On Wed, Oct 17, 2018 at 11:44:27AM +0100, Mel Gorman wrote: > On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > > Running will-it-scale/page_fault1 process mode workload on a 2 sockets > > Intel Skylake server showed severe lock contention of zone->lock, as > > high as about 80%(42% on

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Mel Gorman
On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > Running will-it-scale/page_fault1 process mode workload on a 2 sockets > Intel Skylake server showed severe lock contention of zone->lock, as > high as about 80%(42% on allocation path and 35% on free path) CPU > cycles are burnt

Re: [RFC v4 PATCH 2/5] mm/__free_one_page: skip merge for order-0 page unless compaction failed

2018-10-17 Thread Mel Gorman
On Wed, Oct 17, 2018 at 02:33:27PM +0800, Aaron Lu wrote: > Running will-it-scale/page_fault1 process mode workload on a 2 sockets > Intel Skylake server showed severe lock contention of zone->lock, as > high as about 80%(42% on allocation path and 35% on free path) CPU > cycles are burnt