Re: Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-22 Thread Linus Walleij
On Wed, Dec 18, 2013 at 12:25 AM, Sebastian Reichel wrote: > I had a look at both ofono's and freesmartphone.org's implementation > for the GPIO handling and both implementations are very similar. I > think it should be possible to move the state machine described in > [0] into the kernel and pro

Re: Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-17 Thread Sebastian Reichel
On Tue, Dec 17, 2013 at 07:58:56PM +0200, Ivajlo Dimitrov wrote: > >On Mon, Dec 16, 2013 at 02:31:53PM +0100, Linus Walleij wrote: > >>I am very reluctant in letting device trees specify exports of GPIOs > >>to userspace, not so much because it's Linux-specific but for > >>the fact that people are

Re: Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-17 Thread Ivajlo Dimitrov
On 16.12.2013 20:34, Sebastian Reichel wrote: Hi, On Mon, Dec 16, 2013 at 02:31:53PM +0100, Linus Walleij wrote: I am very reluctant in letting device trees specify exports of GPIOs to userspace, not so much because it's Linux-specific but for the fact that people are doing things in userspace

Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-16 Thread Sebastian Reichel
Hi, On Mon, Dec 16, 2013 at 02:31:53PM +0100, Linus Walleij wrote: > I am very reluctant in letting device trees specify exports of GPIOs > to userspace, not so much because it's Linux-specific but for > the fact that people are doing things in userspace that should not > be done in userspace. >

Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-16 Thread Linus Walleij
On Mon, Dec 16, 2013 at 1:15 PM, Sebastian Reichel wrote: > On Mon, Dec 16, 2013 at 10:48:06AM +0100, Linus Walleij wrote: >> I.e. it doesn't look device-specific at all, just like some >> generic glue code that could be useful to many such >> scenarios. > > I like the idea. > > Probably the rema

Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-16 Thread Sebastian Reichel
Hi Linus, On Mon, Dec 16, 2013 at 10:48:06AM +0100, Linus Walleij wrote: > On Mon, Dec 16, 2013 at 12:27 AM, Sebastian Reichel wrote: > > Add driver handling GPIO pins of Nokia modems. The > > driver provides reset notifications, so that SSI > > clients can subscribe to them easily. > > > > Signe

Re: [RFCv4 06/11] misc: Introduce Nokia CMT driver

2013-12-16 Thread Linus Walleij
On Mon, Dec 16, 2013 at 12:27 AM, Sebastian Reichel wrote: > Add driver handling GPIO pins of Nokia modems. The > driver provides reset notifications, so that SSI > clients can subscribe to them easily. > > Signed-off-by: Sebastian Reichel If the driver provides reset notifications, should it r