Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread jiangyiwen
On 2018/7/17 21:07, Dominique Martinet wrote: > jiangyiwen wrote on Tue, Jul 17, 2018: >> On 2018/7/17 19:42, Dominique Martinet wrote: >>> Subject: net/9p: Fix a deadlock case in the virtio transport >>> >>> I hadn't noticed in the v1, but how is that a deadlock fix? >>> The previous code

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread jiangyiwen
On 2018/7/17 21:07, Dominique Martinet wrote: > jiangyiwen wrote on Tue, Jul 17, 2018: >> On 2018/7/17 19:42, Dominique Martinet wrote: >>> Subject: net/9p: Fix a deadlock case in the virtio transport >>> >>> I hadn't noticed in the v1, but how is that a deadlock fix? >>> The previous code

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread Dominique Martinet
jiangyiwen wrote on Tue, Jul 17, 2018: > On 2018/7/17 19:42, Dominique Martinet wrote: > > > >> Subject: net/9p: Fix a deadlock case in the virtio transport > > > > I hadn't noticed in the v1, but how is that a deadlock fix? > > The previous code doesn't look like it deadlocks to me, the commit

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread Dominique Martinet
jiangyiwen wrote on Tue, Jul 17, 2018: > On 2018/7/17 19:42, Dominique Martinet wrote: > > > >> Subject: net/9p: Fix a deadlock case in the virtio transport > > > > I hadn't noticed in the v1, but how is that a deadlock fix? > > The previous code doesn't look like it deadlocks to me, the commit

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread jiangyiwen
On 2018/7/17 19:42, Dominique Martinet wrote: > >> Subject: net/9p: Fix a deadlock case in the virtio transport > > I hadn't noticed in the v1, but how is that a deadlock fix? > The previous code doesn't look like it deadlocks to me, the commit > message is more correct. > Hi Dominique, If

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread jiangyiwen
On 2018/7/17 19:42, Dominique Martinet wrote: > >> Subject: net/9p: Fix a deadlock case in the virtio transport > > I hadn't noticed in the v1, but how is that a deadlock fix? > The previous code doesn't look like it deadlocks to me, the commit > message is more correct. > Hi Dominique, If

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread Dominique Martinet
> Subject: net/9p: Fix a deadlock case in the virtio transport I hadn't noticed in the v1, but how is that a deadlock fix? The previous code doesn't look like it deadlocks to me, the commit message is more correct. jiangyiwen wrote on Tue, Jul 17, 2018: > When client has multiple threads that

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread Dominique Martinet
> Subject: net/9p: Fix a deadlock case in the virtio transport I hadn't noticed in the v1, but how is that a deadlock fix? The previous code doesn't look like it deadlocks to me, the commit message is more correct. jiangyiwen wrote on Tue, Jul 17, 2018: > When client has multiple threads that

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread piaojun
LGTM On 2018/7/17 19:03, jiangyiwen wrote: > When client has multiple threads that issue io requests > all the time, and the server has a very good performance, > it may cause cpu is running in the irq context for a long > time because it can check virtqueue has buf in the *while* > loop. > > So

Re: [V9fs-developer] [PATCH v2] net/9p: Fix a deadlock case in the virtio transport

2018-07-17 Thread piaojun
LGTM On 2018/7/17 19:03, jiangyiwen wrote: > When client has multiple threads that issue io requests > all the time, and the server has a very good performance, > it may cause cpu is running in the irq context for a long > time because it can check virtqueue has buf in the *while* > loop. > > So