Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-16 Thread Ian Campbell
On Tue, 2012-10-16 at 10:46 -0700, Mukesh Rathor wrote: > On Tue, 16 Oct 2012 17:27:01 +0100 > Ian Campbell wrote: > > > On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote: > > > > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma) > > > > +{ > > > > + int numpgs = (vma->vm_end

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-16 Thread Mukesh Rathor
On Tue, 16 Oct 2012 17:27:01 +0100 Ian Campbell wrote: > On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote: > > > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma) > > > +{ > > > + int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > + struct page **pages =

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-16 Thread Ian Campbell
On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote: > > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma) > > +{ > > + int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > + struct page **pages = vma ? vma->vm_private_data : NULL; > > I thought we agreed to keep

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-16 Thread Ian Campbell
On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote: +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma) +{ + int numpgs = (vma-vm_end - vma-vm_start) PAGE_SHIFT; + struct page **pages = vma ? vma-vm_private_data : NULL; I thought we agreed to keep uses of

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-16 Thread Mukesh Rathor
On Tue, 16 Oct 2012 17:27:01 +0100 Ian Campbell ian.campb...@citrix.com wrote: On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote: +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma) +{ + int numpgs = (vma-vm_end - vma-vm_start) PAGE_SHIFT; + struct page

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-16 Thread Ian Campbell
On Tue, 2012-10-16 at 10:46 -0700, Mukesh Rathor wrote: On Tue, 16 Oct 2012 17:27:01 +0100 Ian Campbell ian.campb...@citrix.com wrote: On Fri, 2012-10-12 at 09:57 +0100, Ian Campbell wrote: +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma) +{ + int numpgs =

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-12 Thread Mukesh Rathor
On Fri, 12 Oct 2012 09:57:56 +0100 Ian Campbell wrote: > On Thu, 2012-10-11 at 22:58 +0100, Mukesh Rathor wrote: > > @@ -2177,8 +2210,19 @@ static const struct pv_mmu_ops xen_mmu_ops > > __initconst = { > > > > void __init xen_init_mmu_ops(void) > > { > > -

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-12 Thread Ian Campbell
On Thu, 2012-10-11 at 22:58 +0100, Mukesh Rathor wrote: > @@ -2177,8 +2210,19 @@ static const struct pv_mmu_ops xen_mmu_ops __initconst > = { > > void __init xen_init_mmu_ops(void) > { > - x86_init.mapping.pagetable_reserve = xen_mapping_pagetable_reserve; >

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-12 Thread Ian Campbell
On Thu, 2012-10-11 at 22:58 +0100, Mukesh Rathor wrote: @@ -2177,8 +2210,19 @@ static const struct pv_mmu_ops xen_mmu_ops __initconst = { void __init xen_init_mmu_ops(void) { - x86_init.mapping.pagetable_reserve = xen_mapping_pagetable_reserve;

Re: [Xen-devel] [PATCH V2 3/7]: PVH: mmu related changes.

2012-10-12 Thread Mukesh Rathor
On Fri, 12 Oct 2012 09:57:56 +0100 Ian Campbell ian.campb...@citrix.com wrote: On Thu, 2012-10-11 at 22:58 +0100, Mukesh Rathor wrote: @@ -2177,8 +2210,19 @@ static const struct pv_mmu_ops xen_mmu_ops __initconst = { void __init xen_init_mmu_ops(void) { -