Re: [dm-devel] DM Regression in 4.16-rc1 - read() returns data when it shouldn't

2018-02-15 Thread NeilBrown
On Thu, Feb 15 2018, Milan Broz wrote: > On 02/15/2018 01:07 AM, NeilBrown wrote: >> >> And looking again at the code, it doesn't seem so bad. I was worried >> about reassigning ci.io->orig_bio after calling >> __split_and_process_non_flush(), but the important thing is to set it >> before the

Re: [dm-devel] DM Regression in 4.16-rc1 - read() returns data when it shouldn't

2018-02-15 Thread NeilBrown
On Thu, Feb 15 2018, Milan Broz wrote: > On 02/15/2018 01:07 AM, NeilBrown wrote: >> >> And looking again at the code, it doesn't seem so bad. I was worried >> about reassigning ci.io->orig_bio after calling >> __split_and_process_non_flush(), but the important thing is to set it >> before the

Re: [dm-devel] DM Regression in 4.16-rc1 - read() returns data when it shouldn't

2018-02-14 Thread Milan Broz
On 02/15/2018 01:07 AM, NeilBrown wrote: > > And looking again at the code, it doesn't seem so bad. I was worried > about reassigning ci.io->orig_bio after calling > __split_and_process_non_flush(), but the important thing is to set it > before the last dec_pending() call, and the code gets that

Re: [dm-devel] DM Regression in 4.16-rc1 - read() returns data when it shouldn't

2018-02-14 Thread Milan Broz
On 02/15/2018 01:07 AM, NeilBrown wrote: > > And looking again at the code, it doesn't seem so bad. I was worried > about reassigning ci.io->orig_bio after calling > __split_and_process_non_flush(), but the important thing is to set it > before the last dec_pending() call, and the code gets that

Re: [dm-devel] DM Regression in 4.16-rc1 - read() returns data when it shouldn't

2018-02-14 Thread NeilBrown
On Wed, Feb 14 2018, Mike Snitzer wrote: > On Wed, Feb 14 2018 at 3:39pm -0500, > NeilBrown wrote: > >> On Wed, Feb 14 2018, Milan Broz wrote: >> >> > Hi, >> > >> > the commit (found by bisect) >> > >> > commit 18a25da84354c6bb655320de6072c00eda6eb602 >> > Author: NeilBrown

Re: [dm-devel] DM Regression in 4.16-rc1 - read() returns data when it shouldn't

2018-02-14 Thread NeilBrown
On Wed, Feb 14 2018, Mike Snitzer wrote: > On Wed, Feb 14 2018 at 3:39pm -0500, > NeilBrown wrote: > >> On Wed, Feb 14 2018, Milan Broz wrote: >> >> > Hi, >> > >> > the commit (found by bisect) >> > >> > commit 18a25da84354c6bb655320de6072c00eda6eb602 >> > Author: NeilBrown >> > Date: