On Tue, Feb 11, 2014 at 9:57 AM, Lee Jones wrote:
>> >> Time to revisit this decision
>> >>
>> >> So, based on the fact that children device names usually contain
>> >> dashes, I do not understand why hwmon would be any special in this
>> >> regard. It is possible that the hwmon developers
On Tue, Feb 11, 2014 at 10:22 AM, Laszlo Papp wrote:
> On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>>> >> > Additionally, dashes are explicitly forbidden in hwmon
>>> >> > device names.
>>> >>
>>> >> Also, where is that
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> > device names.
>> >>
>> >> Also, where is that documented?
>> >
>> > In Documentation/hwmon/sysfs-interface:
>> >
>>
> >> Time to revisit this decision
> >>
> >> So, based on the fact that children device names usually contain
> >> dashes, I do not understand why hwmon would be any special in this
> >> regard. It is possible that the hwmon developers have not faced much
> >> MFD situation before, and so,
On Tue, Feb 11, 2014 at 9:47 AM, Lee Jones wrote:
>> >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> >> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> >> > device names.
>> >> >>
>> >> >> Also, where is that documented?
>> >> >
>> >> > In
> >> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> >> >> > Additionally, dashes are explicitly forbidden in hwmon
> >> >> > device names.
> >> >>
> >> >> Also, where is that documented?
> >> >
> >> > In Documentation/hwmon/sysfs-interface:
> >> >
> >> > *
> >> > *
On Tue, Feb 11, 2014 at 8:58 AM, Laszlo Papp wrote:
> On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>>> >> > Additionally, dashes are explicitly forbidden in hwmon
>>> >> > device names.
>>> >>
>>> >> Also, where is that
On Tue, Feb 11, 2014 at 8:49 AM, Jean Delvare wrote:
> Le Tuesday 11 February 2014 à 08:28 +, Laszlo Papp a écrit :
>> On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
>> > Hi Laszlo,
>> >
>> > On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM,
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> > device names.
>> >>
>> >> Also, where is that documented?
>> >
>> > In Documentation/hwmon/sysfs-interface:
>> >
>>
> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> >> > Additionally, dashes are explicitly forbidden in hwmon
> >> > device names.
> >>
> >> Also, where is that documented?
> >
> > In Documentation/hwmon/sysfs-interface:
> >
> > *
> > * Global attributes *
> >
Le Tuesday 11 February 2014 à 08:28 +, Laszlo Papp a écrit :
> On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
> > Hi Laszlo,
> >
> > On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> >> > Additionally, dashes are
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
> Hi Laszlo,
>
> On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
>> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> > Additionally, dashes are explicitly forbidden in hwmon
>> > device names.
>>
>> Also, where is that
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare wrote:
> Hi Laszlo,
>
> On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
>> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> > Additionally, dashes are explicitly forbidden in hwmon
>> > device names.
>>
>> Also, where is that
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare jdelv...@suse.de wrote:
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare jdelv...@suse.de wrote:
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where
Le Tuesday 11 February 2014 à 08:28 +, Laszlo Papp a écrit :
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare jdelv...@suse.de wrote:
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally,
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
*
* Global attributes *
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones lee.jo...@linaro.org wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
On Tue, Feb 11, 2014 at 8:49 AM, Jean Delvare jdelv...@suse.de wrote:
Le Tuesday 11 February 2014 à 08:28 +, Laszlo Papp a écrit :
On Tue, Feb 11, 2014 at 7:50 AM, Jean Delvare jdelv...@suse.de wrote:
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
On Mon, Feb 10,
On Tue, Feb 11, 2014 at 8:58 AM, Laszlo Papp lp...@kde.org wrote:
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones lee.jo...@linaro.org wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also,
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
*
* Global attributes *
On Tue, Feb 11, 2014 at 9:47 AM, Lee Jones lee.jo...@linaro.org wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
In
Time to revisit this decision
So, based on the fact that children device names usually contain
dashes, I do not understand why hwmon would be any special in this
regard. It is possible that the hwmon developers have not faced much
MFD situation before, and so, this was not
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones lee.jo...@linaro.org wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
On Tue, Feb 11, 2014 at 10:22 AM, Laszlo Papp lp...@kde.org wrote:
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones lee.jo...@linaro.org wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also,
On Tue, Feb 11, 2014 at 9:57 AM, Lee Jones lee.jo...@linaro.org wrote:
Time to revisit this decision
So, based on the fact that children device names usually contain
dashes, I do not understand why hwmon would be any special in this
regard. It is possible that the hwmon developers
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> > Additionally, dashes are explicitly forbidden in hwmon
> > device names.
>
> Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
On Tue, Feb 11, 2014 at 3:23 AM, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 11:10 PM, Guenter Roeck wrote:
>> On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
>> I think I'll let Jean handle this one.
>
> Guys, please be a bit more definite.
>
> We should get over this long
On Mon, Feb 10, 2014 at 11:10 PM, Guenter Roeck wrote:
> On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
> I think I'll let Jean handle this one.
Guys, please be a bit more definite.
We should get over this long ping-pong game. It has been clearly
stated that either way is fine,
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> Additionally, dashes are explicitly forbidden in hwmon
> device names.
Also, where is that documented?
I do not think you can make such a decision, and you will realize that
once you begin to think a bit out of the box and look around. See
On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 4:53 PM, wrote:
> > Quoting Jean Delvare :
> >
> >>
> >> That being said, going with MFD in this case seems quite overkill to
> >> me. MFD makes a lot of sense when each function has its own resources.
> >> As
On Mon, Feb 10, 2014 at 4:53 PM, wrote:
> Quoting Jean Delvare :
>
>>
>> That being said, going with MFD in this case seems quite overkill to
>> me. MFD makes a lot of sense when each function has its own resources.
>> As this isn't the case here, a single driver registering both an hwmon
>>
On Mon, 10 Feb 2014 18:27:07 +, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 5:43 PM, Jean Delvare wrote:
> > On Mon, 10 Feb 2014 16:58:53 +, Lee Jones wrote:
> >> > > Might be worth taking the opportunity to swap out these magic numbers
> >> > > now.
> >> >
> >> > There's nothing magic
> > > > > > Might be worth taking the opportunity to swap out these magic
> > > > > > numbers
> > > > > > now.
> > > > >
> > > > > There's nothing magic about them, they tell the driver how many fans
> > > > > each device supports. If you don't pass them as driver_data you'll
> > > > > have
> >
On Mon, 10 Feb 2014 18:01:59 +, Lee Jones wrote:
> > > > > Might be worth taking the opportunity to swap out these magic numbers
> > > > > now.
> > > >
> > > > There's nothing magic about them, they tell the driver how many fans
> > > > each device supports. If you don't pass them as
On Mon, Feb 10, 2014 at 5:06 PM, Laszlo Papp wrote:
> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
>> Hi Lee, Laszlo,
>>
>> On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
>>> > In the preparation of creating an mfd driver and then refactor this one
>>> > into a
>>> > platform
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare wrote:
> Hi Lee, Laszlo,
>
> On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
>> > In the preparation of creating an mfd driver and then refactor this one
>> > into a
>> > platform driver in order to add some pinctrl functionality to the chip, it
> > > static const struct i2c_device_id max6650_id[] = {
> > > - { "max6650", 1 },
> > > - { "max6651", 4 },
> > > + { "max6650-hwmon", 1 },
> > > + { "max6651-hwmon", 4 },
>
> No, this is not acceptable, sorry. This will change the name of the
> hwmon device as seen from user-space, breaking
Quoting Jean Delvare :
That being said, going with MFD in this case seems quite overkill to
me. MFD makes a lot of sense when each function has its own resources.
As this isn't the case here, a single driver registering both an hwmon
interface and a pinctrl interface would seem sufficient to
Hi Lee, Laszlo,
On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
> > In the preparation of creating an mfd driver and then refactor this one
> > into a
> > platform driver in order to add some pinctrl functionality to the chip, it
> > is
> > necessary to start the series with this change so
Hi Lee, Laszlo,
On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
In the preparation of creating an mfd driver and then refactor this one
into a
platform driver in order to add some pinctrl functionality to the chip, it
is
necessary to start the series with this change so that the
Quoting Jean Delvare jdelv...@suse.de:
That being said, going with MFD in this case seems quite overkill to
me. MFD makes a lot of sense when each function has its own resources.
As this isn't the case here, a single driver registering both an hwmon
interface and a pinctrl interface would seem
static const struct i2c_device_id max6650_id[] = {
- { max6650, 1 },
- { max6651, 4 },
+ { max6650-hwmon, 1 },
+ { max6651-hwmon, 4 },
No, this is not acceptable, sorry. This will change the name of the
hwmon device as seen from user-space, breaking any configuration file
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Hi Lee, Laszlo,
On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
In the preparation of creating an mfd driver and then refactor this one
into a
platform driver in order to add some pinctrl functionality to the
On Mon, Feb 10, 2014 at 5:06 PM, Laszlo Papp lp...@kde.org wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Hi Lee, Laszlo,
On Mon, 10 Feb 2014 16:08:42 +, Lee Jones wrote:
In the preparation of creating an mfd driver and then refactor this one
into a
On Mon, 10 Feb 2014 18:01:59 +, Lee Jones wrote:
Might be worth taking the opportunity to swap out these magic numbers
now.
There's nothing magic about them, they tell the driver how many fans
each device supports. If you don't pass them as driver_data you'll have
to
Might be worth taking the opportunity to swap out these magic
numbers
now.
There's nothing magic about them, they tell the driver how many fans
each device supports. If you don't pass them as driver_data you'll
have
to derive them from the device name
On Mon, 10 Feb 2014 18:27:07 +, Laszlo Papp wrote:
On Mon, Feb 10, 2014 at 5:43 PM, Jean Delvare jdelv...@suse.de wrote:
On Mon, 10 Feb 2014 16:58:53 +, Lee Jones wrote:
Might be worth taking the opportunity to swap out these magic numbers
now.
There's nothing magic about
On Mon, Feb 10, 2014 at 4:53 PM, li...@roeck-us.net wrote:
Quoting Jean Delvare jdelv...@suse.de:
That being said, going with MFD in this case seems quite overkill to
me. MFD makes a lot of sense when each function has its own resources.
As this isn't the case here, a single driver
On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
On Mon, Feb 10, 2014 at 4:53 PM, li...@roeck-us.net wrote:
Quoting Jean Delvare jdelv...@suse.de:
That being said, going with MFD in this case seems quite overkill to
me. MFD makes a lot of sense when each function has its
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
I do not think you can make such a decision, and you will realize that
once you begin to think a bit out of the box and
On Mon, Feb 10, 2014 at 11:10 PM, Guenter Roeck li...@roeck-us.net wrote:
On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
I think I'll let Jean handle this one.
Guys, please be a bit more definite.
We should get over this long ping-pong game. It has been clearly
stated that either
On Tue, Feb 11, 2014 at 3:23 AM, Laszlo Papp lp...@kde.org wrote:
On Mon, Feb 10, 2014 at 11:10 PM, Guenter Roeck li...@roeck-us.net wrote:
On Mon, Feb 10, 2014 at 06:59:55PM +, Laszlo Papp wrote:
I think I'll let Jean handle this one.
Guys, please be a bit more definite.
We should get
Hi Laszlo,
On Tue, 11 Feb 2014 03:13:37 +, Laszlo Papp wrote:
On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare jdelv...@suse.de wrote:
Additionally, dashes are explicitly forbidden in hwmon
device names.
Also, where is that documented?
In Documentation/hwmon/sysfs-interface:
54 matches
Mail list logo
