Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

Hi Rafael, 2018-01-24 3:08 GMT+01:00 Rafael J. Wysocki : > On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas wrote: >> Hi Rafael, >> >>> > if (res) >>> > return res; >>> > >>> > - return device_get_mac_addr(dev, "address", addr,

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

Hi Rafael, 2018-01-24 3:08 GMT+01:00 Rafael J. Wysocki : > On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas wrote: >> Hi Rafael, >> >>> > if (res) >>> > return res; >>> > >>> > - return device_get_mac_addr(dev, "address", addr, alen); >>> > + return

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas wrote: > Hi Rafael, > >> > if (res) >> > return res; >> > >> > - return device_get_mac_addr(dev, "address", addr, alen); >> > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); >> > +}

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

On Tue, Jan 23, 2018 at 7:12 AM, Marcin Wojtas wrote: > Hi Rafael, > >> > if (res) >> > return res; >> > >> > - return device_get_mac_addr(dev, "address", addr, alen); >> > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); >> > +} >> >

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

Hi Rafael, > > if (res) > > return res; > > > > - return device_get_mac_addr(dev, "address", addr, alen); > > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); > > +} > > +EXPORT_SYMBOL(fwnode_get_mac_address); > > That should be EXPORT_SYMBOL_GPL().

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

Hi Rafael, > > if (res) > > return res; > > > > - return device_get_mac_addr(dev, "address", addr, alen); > > + return fwnode_get_mac_addr(fwnode, "address", addr, alen); > > +} > > +EXPORT_SYMBOL(fwnode_get_mac_address); > > That should be EXPORT_SYMBOL_GPL().

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

On Thu, Jan 18, 2018 at 1:31 PM, Marcin Wojtas wrote: > Until now there were two almost identical functions for > obtaining MAC address - of_get_mac_address() and, more generic, > device_get_mac_address(). However it is not uncommon, > that the network interface is represented

Re: [net-next: PATCH v4 1/7] device property: Introduce fwnode_get_mac_address()

On Thu, Jan 18, 2018 at 1:31 PM, Marcin Wojtas wrote: > Until now there were two almost identical functions for > obtaining MAC address - of_get_mac_address() and, more generic, > device_get_mac_address(). However it is not uncommon, > that the network interface is represented as a child > of the