Re: [syzbot] general protection fault in gadget_setup

2021-04-16 Thread Alan Stern
On Fri, Apr 16, 2021 at 10:35:20PM +0530, Anirudh Rayabharam wrote: > On Fri, Apr 16, 2021 at 11:27:34AM -0400, Alan Stern wrote: > > Actually, I wanted to move this emulation code into a new subroutine and > > then call that subroutine from _both_ places. Would you like to write > > Does it

Re: [syzbot] general protection fault in gadget_setup

2021-04-16 Thread Anirudh Rayabharam
On Fri, Apr 16, 2021 at 11:27:34AM -0400, Alan Stern wrote: > On Fri, Apr 16, 2021 at 11:10:35AM +0530, Anirudh Rayabharam wrote: > > On Tue, Apr 13, 2021 at 12:13:11PM -0400, Alan Stern wrote: > > > Maybe we can test this reasoning by putting a delay just before the call > > > to

Re: [syzbot] general protection fault in gadget_setup

2021-04-16 Thread Alan Stern
On Fri, Apr 16, 2021 at 09:21:12AM +0200, Dmitry Vyukov wrote: > On Thu, Apr 15, 2021 at 10:59 PM Alan Stern wrote: > > > > On Tue, Apr 13, 2021 at 07:11:11PM +0200, Dmitry Vyukov wrote: > > > Yes, this is possible: > > > http://bit.do/syzbot#syzkaller-reproducers > > > > That's not really what I

Re: [syzbot] general protection fault in gadget_setup

2021-04-16 Thread Alan Stern
On Fri, Apr 16, 2021 at 11:10:35AM +0530, Anirudh Rayabharam wrote: > On Tue, Apr 13, 2021 at 12:13:11PM -0400, Alan Stern wrote: > > Maybe we can test this reasoning by putting a delay just before the call > > to dum->driver->setup. That runs in the timer handler, so it's not a > > good place

Re: [syzbot] general protection fault in gadget_setup

2021-04-16 Thread Dmitry Vyukov
On Thu, Apr 15, 2021 at 10:59 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 07:11:11PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 13, 2021 at 6:57 PM Alan Stern > > wrote: > > > > > > On Tue, Apr 13, 2021 at 06:47:47PM +0200, Dmitry Vyukov wrote: > > > > On Tue, Apr 13, 2021 at 6:13 PM Alan

Re: [syzbot] general protection fault in gadget_setup

2021-04-15 Thread Anirudh Rayabharam
On Tue, Apr 13, 2021 at 12:13:11PM -0400, Alan Stern wrote: > On Tue, Apr 13, 2021 at 10:12:05AM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 13, 2021 at 10:08 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:0f4498ce Merge tag

Re: [syzbot] general protection fault in gadget_setup

2021-04-15 Thread Alan Stern
On Tue, Apr 13, 2021 at 07:11:11PM +0200, Dmitry Vyukov wrote: > On Tue, Apr 13, 2021 at 6:57 PM Alan Stern wrote: > > > > On Tue, Apr 13, 2021 at 06:47:47PM +0200, Dmitry Vyukov wrote: > > > On Tue, Apr 13, 2021 at 6:13 PM Alan Stern > > > wrote: > > > > Hopefully this patch will make the race

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Dmitry Vyukov
On Tue, Apr 13, 2021 at 6:57 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 06:47:47PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 13, 2021 at 6:13 PM Alan Stern > > wrote: > > > Hopefully this patch will make the race a lot more likely to occur. Is > > > there any way to tell syzkaller to

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Alan Stern
On Tue, Apr 13, 2021 at 06:47:47PM +0200, Dmitry Vyukov wrote: > On Tue, Apr 13, 2021 at 6:13 PM Alan Stern wrote: > > Hopefully this patch will make the race a lot more likely to occur. Is > > there any way to tell syzkaller to test it, despite the fact that > > syzkaller doesn't think it has a

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Dmitry Vyukov
On Tue, Apr 13, 2021 at 6:13 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 10:12:05AM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 13, 2021 at 10:08 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:0f4498ce Merge tag

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Alan Stern
On Tue, Apr 13, 2021 at 10:12:05AM +0200, Dmitry Vyukov wrote: > On Tue, Apr 13, 2021 at 10:08 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:0f4498ce Merge tag 'for-5.12/dm-fixes-2' of git://git.kern.. > > git tree: upstream > >

Re: [syzbot] general protection fault in gadget_setup

2021-04-13 Thread Dmitry Vyukov
On Tue, Apr 13, 2021 at 10:08 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:0f4498ce Merge tag 'for-5.12/dm-fixes-2' of git://git.kern.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=124adbf6d0 > kernel