Re: [tip:sched/core] sched: Push down pre_schedule() and idle_balance ()

2014-02-13 Thread Michael wang
On 02/13/2014 11:34 AM, Michael wang wrote: > On 02/12/2014 06:22 PM, Peter Zijlstra wrote: > [snip] >> >> Yes I think there might be a problem here because of how we re-arranged >> things. Let me brew of pot of tea and try to actually wake up. >> >> I suspect we might be good if we clear the need_

Re: [tip:sched/core] sched: Push down pre_schedule() and idle_balance ()

2014-02-12 Thread Michael wang
On 02/12/2014 06:22 PM, Peter Zijlstra wrote: [snip] > > Yes I think there might be a problem here because of how we re-arranged > things. Let me brew of pot of tea and try to actually wake up. > > I suspect we might be good if we clear the need_resched flags before > calling pick_next_task. Then

Re: [tip:sched/core] sched: Push down pre_schedule() and idle_balance ()

2014-02-12 Thread Peter Zijlstra
On Wed, Feb 12, 2014 at 02:26:25PM +0800, Michael wang wrote: > Hi, Peter > > On 02/11/2014 08:17 PM, tip-bot for Peter Zijlstra wrote: > [snip] > > + > > +idle: > > +#ifdef CONFIG_SMP > > + idle_enter_fair(rq); > > + /* > > +* We must set idle_stamp _before_ calling idle_balance(), such t

Re: [tip:sched/core] sched: Push down pre_schedule() and idle_balance ()

2014-02-11 Thread Michael wang
Hi, Peter On 02/11/2014 08:17 PM, tip-bot for Peter Zijlstra wrote: [snip] > + > +idle: > +#ifdef CONFIG_SMP > + idle_enter_fair(rq); > + /* > + * We must set idle_stamp _before_ calling idle_balance(), such that we > + * measure the duration of idle_balance() as idle time. > +