Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Joe Perches
On Sun, 2016-07-10 at 14:06 +0200, Borislav Petkov wrote: > On Sun, Jul 10, 2016 at 01:23:51AM -0700, Joe Perches wrote: > > > > Assuming tip is included in linux-next as of july 8, yes. > Try one which has http://git.kernel.org/tip/81c2949f7fdcf8ff681326669a > fde24962232670 That commit isn't

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Joe Perches
On Sun, 2016-07-10 at 14:06 +0200, Borislav Petkov wrote: > On Sun, Jul 10, 2016 at 01:23:51AM -0700, Joe Perches wrote: > > > > Assuming tip is included in linux-next as of july 8, yes. > Try one which has http://git.kernel.org/tip/81c2949f7fdcf8ff681326669a > fde24962232670 That commit isn't

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Borislav Petkov
On Sun, Jul 10, 2016 at 01:23:51AM -0700, Joe Perches wrote: > Assuming tip is included in linux-next as of july 8, yes. Try one which has http://git.kernel.org/tip/81c2949f7fdcf8ff681326669afde24962232670 -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Borislav Petkov
On Sun, Jul 10, 2016 at 01:23:51AM -0700, Joe Perches wrote: > Assuming tip is included in linux-next as of july 8, yes. Try one which has http://git.kernel.org/tip/81c2949f7fdcf8ff681326669afde24962232670 -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Joe Perches
On Sun, 2016-07-10 at 08:49 +0200, Borislav Petkov wrote: > On Sat, Jul 09, 2016 at 10:56:55AM -0700, Joe Perches wrote: > > > > defconfigs both with and without CONFIG_PRINTK build > > properly with the proposed change to this specific patch. > Did you try latest tip/master? Assuming tip is

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Joe Perches
On Sun, 2016-07-10 at 08:49 +0200, Borislav Petkov wrote: > On Sat, Jul 09, 2016 at 10:56:55AM -0700, Joe Perches wrote: > > > > defconfigs both with and without CONFIG_PRINTK build > > properly with the proposed change to this specific patch. > Did you try latest tip/master? Assuming tip is

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Borislav Petkov
On Sat, Jul 09, 2016 at 10:56:55AM -0700, Joe Perches wrote: > defconfigs both with and without CONFIG_PRINTK build > properly with the proposed change to this specific patch. Did you try latest tip/master? > Borislav, your delightful personality always impresses. > Never change. What goes

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-10 Thread Borislav Petkov
On Sat, Jul 09, 2016 at 10:56:55AM -0700, Joe Perches wrote: > defconfigs both with and without CONFIG_PRINTK build > properly with the proposed change to this specific patch. Did you try latest tip/master? > Borislav, your delightful personality always impresses. > Never change. What goes

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-09 Thread Joe Perches
On Sat, 2016-07-09 at 09:50 +0200, Borislav Petkov wrote: > On Fri, Jul 08, 2016 at 07:40:48PM -0700, Joe Perches wrote: > > This change isn't described in the commit message and there > > doesn't seem to be a need to change this. > How do *you* know? Did *you* actually sit down and build a kernel

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-09 Thread Joe Perches
On Sat, 2016-07-09 at 09:50 +0200, Borislav Petkov wrote: > On Fri, Jul 08, 2016 at 07:40:48PM -0700, Joe Perches wrote: > > This change isn't described in the commit message and there > > doesn't seem to be a need to change this. > How do *you* know? Did *you* actually sit down and build a kernel

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-09 Thread Borislav Petkov
On Fri, Jul 08, 2016 at 07:40:48PM -0700, Joe Perches wrote: > This change isn't described in the commit message and there > doesn't seem to be a need to change this. How do *you* know? Did *you* actually sit down and build a kernel with your proposed change before sending a reply? I'm pretty

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-09 Thread Borislav Petkov
On Fri, Jul 08, 2016 at 07:40:48PM -0700, Joe Perches wrote: > This change isn't described in the commit message and there > doesn't seem to be a need to change this. How do *you* know? Did *you* actually sit down and build a kernel with your proposed change before sending a reply? I'm pretty

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-08 Thread Joe Perches
On Fri, 2016-07-08 at 05:08 -0700, tip-bot for Borislav Petkov wrote: > printk: Make the printk*once() variants return a value [] > diff --git a/include/linux/printk.h b/include/linux/printk.h [] > @@ -108,11 +108,14 @@ struct va_format { >   * Dummy printk for disabled debugging statements to use

Re: [tip:x86/debug] printk: Make the printk*once() variants return a value

2016-07-08 Thread Joe Perches
On Fri, 2016-07-08 at 05:08 -0700, tip-bot for Borislav Petkov wrote: > printk: Make the printk*once() variants return a value [] > diff --git a/include/linux/printk.h b/include/linux/printk.h [] > @@ -108,11 +108,14 @@ struct va_format { >   * Dummy printk for disabled debugging statements to use