Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-14 Thread Fengguang Wu
Hi Andi, On Mon, Nov 13, 2017 at 10:52:27AM -0800, Andi Kleen wrote: > It's the "CONFIG_DEBUG_INFO_SPLIT" thing that makes faddr2line unable > to see the inlining information, > > Using OPTIMIZE_INLINING is fine. Good to know that! It works for me. Perhaps your binutils is too old? It was

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-14 Thread Fengguang Wu
Hi Andi, On Mon, Nov 13, 2017 at 10:52:27AM -0800, Andi Kleen wrote: > It's the "CONFIG_DEBUG_INFO_SPLIT" thing that makes faddr2line unable > to see the inlining information, > > Using OPTIMIZE_INLINING is fine. Good to know that! It works for me. Perhaps your binutils is too old? It was

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
> I wonder if there is some way to use the split format for the > intermediate files, but then for the very final link bring them all in > and make the end result be a traditional single binary. I'm not > talking the separate "dwp" package that packs multiple dwo files into > one, but to actually

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
> I wonder if there is some way to use the split format for the > intermediate files, but then for the very final link bring them all in > and make the end result be a traditional single binary. I'm not > talking the separate "dwp" package that packs multiple dwo files into > one, but to actually

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 1:41 PM, Andi Kleen wrote: > > It seems to be broken for normal programs too Ok. I wonder if there is some way to use the split format for the intermediate files, but then for the very final link bring them all in and make the end result be a

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 1:41 PM, Andi Kleen wrote: > > It seems to be broken for normal programs too Ok. I wonder if there is some way to use the split format for the intermediate files, but then for the very final link bring them all in and make the end result be a traditional single binary.

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
On Mon, Nov 13, 2017 at 12:56:31PM -0800, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: > > > > You're right. It works for line information, but strangely not for > > inlines. I assume it can be fixed. > > So I'm not 100% sure it's strictly a

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
On Mon, Nov 13, 2017 at 12:56:31PM -0800, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: > > > > You're right. It works for line information, but strangely not for > > inlines. I assume it can be fixed. > > So I'm not 100% sure it's strictly a addr2line bug. It

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: > > You're right. It works for line information, but strangely not for > inlines. I assume it can be fixed. So I'm not 100% sure it's strictly a addr2line bug. We do more than just link the vmlinux file. There's that

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: > > You're right. It works for line information, but strangely not for > inlines. I assume it can be fixed. So I'm not 100% sure it's strictly a addr2line bug. We do more than just link the vmlinux file. There's that whole complicated script

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread H.J. Lu
On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: >> Put another way: the CONFIG_DEBUG_INFO_SPLIT option is useless. Yes, >> it saves time and disk space, but does so at the expense of making all >> the debug information unavailable to basic tools. > > You're right. It

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread H.J. Lu
On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: >> Put another way: the CONFIG_DEBUG_INFO_SPLIT option is useless. Yes, >> it saves time and disk space, but does so at the expense of making all >> the debug information unavailable to basic tools. > > You're right. It works for line

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
> Put another way: the CONFIG_DEBUG_INFO_SPLIT option is useless. Yes, > it saves time and disk space, but does so at the expense of making all > the debug information unavailable to basic tools. You're right. It works for line information, but strangely not for inlines. I assume it can be fixed.

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
> Put another way: the CONFIG_DEBUG_INFO_SPLIT option is useless. Yes, > it saves time and disk space, but does so at the expense of making all > the debug information unavailable to basic tools. You're right. It works for line information, but strangely not for inlines. I assume it can be fixed.

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 10:52 AM, Andi Kleen wrote: > > It works for me. No it clearly does not. > % ./linux/scripts/faddr2line obj/vmlinux schedule+10 > schedule+10/0x80: > schedule at arch/x86/include/asm/current.h:15 That's obviously garbage and the problem. Just look

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Linus Torvalds
On Mon, Nov 13, 2017 at 10:52 AM, Andi Kleen wrote: > > It works for me. No it clearly does not. > % ./linux/scripts/faddr2line obj/vmlinux schedule+10 > schedule+10/0x80: > schedule at arch/x86/include/asm/current.h:15 That's obviously garbage and the problem. Just look at it. It claims it

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
> > It's the "CONFIG_DEBUG_INFO_SPLIT" thing that makes faddr2line unable > > to see the inlining information, > > > > Using OPTIMIZE_INLINING is fine. > > Good to know that! It works for me. Perhaps your binutils is too old? It was added at some point. Can you try upgrading? %

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-13 Thread Andi Kleen
> > It's the "CONFIG_DEBUG_INFO_SPLIT" thing that makes faddr2line unable > > to see the inlining information, > > > > Using OPTIMIZE_INLINING is fine. > > Good to know that! It works for me. Perhaps your binutils is too old? It was added at some point. Can you try upgrading? %

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Fengguang Wu
[...] > Oh - and talking about "big step forward" - does the 0day robot do > any > suspend/resume testing at all? Yes, we do. CC Rui and Aaron on power testing. yes, we have added suspend/resume test in 0day, including both functionality and suspend/resume performance. It is not widely run

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Fengguang Wu
[...] > Oh - and talking about "big step forward" - does the 0day robot do > any > suspend/resume testing at all? Yes, we do. CC Rui and Aaron on power testing. yes, we have added suspend/resume test in 0day, including both functionality and suspend/resume performance. It is not widely run

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Zhang Rui
On Mon, 2017-11-13 at 09:13 +0800, Fengguang Wu wrote: > CC Andi and more DEBUG_INFO_SPLIT people. > > On Sun, Nov 12, 2017 at 11:31:56AM -0800, Linus Torvalds wrote: > > > > On Wed, Nov 8, 2017 at 9:12 AM, Fengguang Wu > m> wrote: > > > > > > > > > OK. Here is the

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

2017-11-12 Thread Zhang Rui
On Mon, 2017-11-13 at 09:13 +0800, Fengguang Wu wrote: > CC Andi and more DEBUG_INFO_SPLIT people. > > On Sun, Nov 12, 2017 at 11:31:56AM -0800, Linus Torvalds wrote: > > > > On Wed, Nov 8, 2017 at 9:12 AM, Fengguang Wu > m> wrote: > > > > > > > > > OK. Here is the original faddr2line output: