Re: Logitech high-resolution scrolling..

2018-10-31 Thread Nestor Lopez Casado
Hi guys, I've read the discussion, I think I understand the problem and I'll get back to this thread with more information as soon as I've got some internal feedback. BTW, lovely to see so many MX Anywhere 2 users :) -nestor On Tue, Oct 30, 2018 at 6:48 PM Harry Cutts wrote: > > Thanks for

Re: Logitech high-resolution scrolling..

2018-10-31 Thread Nestor Lopez Casado
Hi guys, I've read the discussion, I think I understand the problem and I'll get back to this thread with more information as soon as I've got some internal feedback. BTW, lovely to see so many MX Anywhere 2 users :) -nestor On Tue, Oct 30, 2018 at 6:48 PM Harry Cutts wrote: > > Thanks for

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Harry Cutts
Thanks for the analysis, Peter. On Mon, 29 Oct 2018 at 23:27, Peter Hutterer wrote: > IMO this is a lost battle because you cannot know when the ratchet is > enabled or not (at least not on all mice). Users switch between ratchet and > freewheeling time and once you're out of one mode, you have

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Harry Cutts
Thanks for the analysis, Peter. On Mon, 29 Oct 2018 at 23:27, Peter Hutterer wrote: > IMO this is a lost battle because you cannot know when the ratchet is > enabled or not (at least not on all mice). Users switch between ratchet and > freewheeling time and once you're out of one mode, you have

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 11:27 PM Peter Hutterer wrote: > > Other issues I found with an MX Anywhere 2S is that on slow scroll and in > ratchet mode we get some scroll jitter. In ratchet mode we can get this > sequence if you scroll just past the notch and it snaps back: > [1, 1, 1, 1, 1, 1,

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 11:27 PM Peter Hutterer wrote: > > Other issues I found with an MX Anywhere 2S is that on slow scroll and in > ratchet mode we get some scroll jitter. In ratchet mode we can get this > sequence if you scroll just past the notch and it snaps back: > [1, 1, 1, 1, 1, 1,

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Mauro Carvalho Chehab
Em Sun, 28 Oct 2018 14:08:31 -0700 Linus Torvalds escreveu: > On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds > wrote: > > > > So the recent change to enable the high-res scrolling really seems a > > bit *too* extreme. > > > > Is there some middle ground that turns the mouse from "look at it >

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Mauro Carvalho Chehab
Em Sun, 28 Oct 2018 14:08:31 -0700 Linus Torvalds escreveu: > On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds > wrote: > > > > So the recent change to enable the high-res scrolling really seems a > > bit *too* extreme. > > > > Is there some middle ground that turns the mouse from "look at it >

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Peter Hutterer
On Mon, Oct 29, 2018 at 04:03:54PM -0700, Harry Cutts wrote: > On Mon, 29 Oct 2018 at 15:01, Linus Torvalds > wrote: > > That would work, yes. > > OK, I'll write a patch for this. (It may be next week, though, as I > have a deadline on a separate project this week.) > > > Except I think you

Re: Logitech high-resolution scrolling..

2018-10-30 Thread Peter Hutterer
On Mon, Oct 29, 2018 at 04:03:54PM -0700, Harry Cutts wrote: > On Mon, 29 Oct 2018 at 15:01, Linus Torvalds > wrote: > > That would work, yes. > > OK, I'll write a patch for this. (It may be next week, though, as I > have a deadline on a separate project this week.) > > > Except I think you

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Harry Cutts
On Mon, 29 Oct 2018 at 15:01, Linus Torvalds wrote: > That would work, yes. OK, I'll write a patch for this. (It may be next week, though, as I have a deadline on a separate project this week.) > Except I think you *do* want the "reset on direction change" logic, > because otherwise we still

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Harry Cutts
On Mon, 29 Oct 2018 at 15:01, Linus Torvalds wrote: > That would work, yes. OK, I'll write a patch for this. (It may be next week, though, as I have a deadline on a separate project this week.) > Except I think you *do* want the "reset on direction change" logic, > because otherwise we still

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 2:42 PM Harry Cutts wrote: > > Ah, I see what you mean. So, if we move the threshold to (multiplier - > 1)/multiplier (7/8) in this case, I think the equivalent scenario > would be: That would work, yes. Except I think you *do* want the "reset on direction change" logic,

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 2:42 PM Harry Cutts wrote: > > Ah, I see what you mean. So, if we move the threshold to (multiplier - > 1)/multiplier (7/8) in this case, I think the equivalent scenario > would be: That would work, yes. Except I think you *do* want the "reset on direction change" logic,

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Harry Cutts
On Mon, 29 Oct 2018 at 14:12, Linus Torvalds > So what the half-multiplier did, assuming a multiplier of 8 (which is > what my MX Anywhere 2S reports) would be: > > - remainder starts at 3 > - high-res is +1 > - now remainder is 3+1, and it triggers the >= half logic > - 4/8 is 0, but then

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Harry Cutts
On Mon, 29 Oct 2018 at 14:12, Linus Torvalds > So what the half-multiplier did, assuming a multiplier of 8 (which is > what my MX Anywhere 2S reports) would be: > > - remainder starts at 3 > - high-res is +1 > - now remainder is 3+1, and it triggers the >= half logic > - 4/8 is 0, but then

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 12:17 PM Harry Cutts wrote: > > I don't really understand why the half-multiplier thing would cause > the instability; there's still a low-res threshold every 8 high-res > units whichever way you do it No there isn't. So what the half-multiplier did, assuming a

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 12:17 PM Harry Cutts wrote: > > I don't really understand why the half-multiplier thing would cause > the instability; there's still a low-res threshold every 8 high-res > units whichever way you do it No there isn't. So what the half-multiplier did, assuming a

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Harry Cutts
As I explained in the comments, the reason for triggering at the half multiplier point and then setting a negative remainder is to cater for wheels that sometimes rest just before they complete a whole "notch" in clicky mode. On those mice, setting the threshold at a full notch means that you

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Harry Cutts
As I explained in the comments, the reason for triggering at the half multiplier point and then setting a negative remainder is to cater for wheels that sometimes rest just before they complete a whole "notch" in clicky mode. On those mice, setting the threshold at a full notch means that you

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 8:16 AM Linus Torvalds wrote: > > Patch I'm using attached. I'm inclined to just commit it, but if > somebody has a better idea, I can test alternatives too. I committed my patch, as it at least makes the scroll wheel usable. I'm more than open to further improvements,

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 8:16 AM Linus Torvalds wrote: > > Patch I'm using attached. I'm inclined to just commit it, but if > somebody has a better idea, I can test alternatives too. I committed my patch, as it at least makes the scroll wheel usable. I'm more than open to further improvements,

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 6:18 AM Jiri Kosina wrote: > > Benjamin indicated that Peter probably has found the issue in the code > (failure to properly reset on direction change) that might be causing > this. So honestly, once I looked at that hid_scroll_counter_handle_scroll() function, that's the

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 6:18 AM Jiri Kosina wrote: > > Benjamin indicated that Peter probably has found the issue in the code > (failure to properly reset on direction change) that might be causing > this. So honestly, once I looked at that hid_scroll_counter_handle_scroll() function, that's the

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Jiri Kosina
On Sun, 28 Oct 2018, Linus Torvalds wrote: > So I use a Logitech MX Anywhere 2S mouse, and really like it. I have > the scroll-wheel unlocked, because I like flicking once to scroll a > lot. > > However, the new high-res scroll code means that the scroll wheel > action is now much too sensitive.

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Jiri Kosina
On Sun, 28 Oct 2018, Linus Torvalds wrote: > So I use a Logitech MX Anywhere 2S mouse, and really like it. I have > the scroll-wheel unlocked, because I like flicking once to scroll a > lot. > > However, the new high-res scroll code means that the scroll wheel > action is now much too sensitive.

Re: Logitech high-resolution scrolling..

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds wrote: > > So the recent change to enable the high-res scrolling really seems a > bit *too* extreme. > > Is there some middle ground that turns the mouse from "look at it > sideways and it starts scrolling" to something slightly more > reasonable?

Re: Logitech high-resolution scrolling..

2018-10-28 Thread Linus Torvalds
On Sun, Oct 28, 2018 at 12:13 PM Linus Torvalds wrote: > > So the recent change to enable the high-res scrolling really seems a > bit *too* extreme. > > Is there some middle ground that turns the mouse from "look at it > sideways and it starts scrolling" to something slightly more > reasonable?