Re: relayfs question related to removing parent directory.

2013-05-08 Thread Ben Greear
On 05/08/2013 01:35 PM, Al Viro wrote: On Wed, May 08, 2013 at 01:32:06PM -0700, Ben Greear wrote: I'm seeing a crash when unloading the ath9k module. It seems relay_close() is being passed bad memory. The relay_open call uses an ath9k debugfs directory, so that may be removed before the call

Re: relayfs question related to removing parent directory.

2013-05-08 Thread Al Viro
On Wed, May 08, 2013 at 01:32:06PM -0700, Ben Greear wrote: > I'm seeing a crash when unloading the ath9k module. > > It seems relay_close() is being passed bad memory. > > The relay_open call uses an ath9k debugfs directory, so > that may be removed before the call to relay_close() > is called.

Re: relayfs question related to removing parent directory.

2013-05-08 Thread Al Viro
On Wed, May 08, 2013 at 01:32:06PM -0700, Ben Greear wrote: I'm seeing a crash when unloading the ath9k module. It seems relay_close() is being passed bad memory. The relay_open call uses an ath9k debugfs directory, so that may be removed before the call to relay_close() is called.

Re: relayfs question related to removing parent directory.

2013-05-08 Thread Ben Greear
On 05/08/2013 01:35 PM, Al Viro wrote: On Wed, May 08, 2013 at 01:32:06PM -0700, Ben Greear wrote: I'm seeing a crash when unloading the ath9k module. It seems relay_close() is being passed bad memory. The relay_open call uses an ath9k debugfs directory, so that may be removed before the call

Re: Relayfs Question: Use of relay_reset(). Potential race?

2005-04-18 Thread Kingsley Cheung
On Mon, Apr 18, 2005 at 10:56:57AM -0500, Tom Zanussi wrote: > Kingsley Cheung writes: > > On Wed, Mar 23, 2005 at 08:02:54PM +1100, [EMAIL PROTECTED] wrote: > > > Hi > > > > > > I'm using relayfs to relay data from a kernel module to user space on > > > a SuSE 2.6.5 kernel. I'm not

Re: Relayfs Question: Use of relay_reset(). Potential race?

2005-04-18 Thread Tom Zanussi
Kingsley Cheung writes: > On Wed, Mar 23, 2005 at 08:02:54PM +1100, [EMAIL PROTECTED] wrote: > > Hi > > > > I'm using relayfs to relay data from a kernel module to user space on > > a SuSE 2.6.5 kernel. I'm not absolutely sure what version of relayfs > > has been back ported to it. > >

Re: Relayfs Question: Use of relay_reset(). Potential race?

2005-04-18 Thread Tom Zanussi
Kingsley Cheung writes: On Wed, Mar 23, 2005 at 08:02:54PM +1100, [EMAIL PROTECTED] wrote: Hi I'm using relayfs to relay data from a kernel module to user space on a SuSE 2.6.5 kernel. I'm not absolutely sure what version of relayfs has been back ported to it. Hi Tom,

Re: Relayfs Question: Use of relay_reset(). Potential race?

2005-04-18 Thread Kingsley Cheung
On Mon, Apr 18, 2005 at 10:56:57AM -0500, Tom Zanussi wrote: Kingsley Cheung writes: On Wed, Mar 23, 2005 at 08:02:54PM +1100, [EMAIL PROTECTED] wrote: Hi I'm using relayfs to relay data from a kernel module to user space on a SuSE 2.6.5 kernel. I'm not absolutely sure what

Re: Relayfs question

2005-03-20 Thread Theodore Ts'o
On Sat, Mar 19, 2005 at 10:08:13PM +0100, Jan Engelhardt wrote: > > Well, what about things like urandom? It also moves "a lot" of data and does > nothing else. > If you're using urandom to move "a lot" of data, you're using it wrong. That's not what it is supposed to be for; I can't think of

Re: Relayfs question

2005-03-20 Thread Theodore Ts'o
On Sat, Mar 19, 2005 at 10:08:13PM +0100, Jan Engelhardt wrote: Well, what about things like urandom? It also moves a lot of data and does nothing else. If you're using urandom to move a lot of data, you're using it wrong. That's not what it is supposed to be for; I can't think of a valid

Re: Relayfs question

2005-03-19 Thread Karim Yaghmour
Jan Engelhardt wrote: > Well, what about things like urandom? It also moves "a lot" of data and does > nothing else. Forgive my slowness today, but I don't get the angle here: - Relayfs is not a replacement for char devices, we've never claimed it to be. - Urandom generates a lot of data, and

Re: Relayfs question

2005-03-19 Thread Jan Engelhardt
>> Ok, urandom was a bad example. I have my tty logger (ttyrpld.sf.net) which >> moves a lot of data (depends) to userspace. It uses a ring buffer [...] >[...] >Basically, all the transport code you are doing in the kernel side of >your logger would be taken care of by relayfs. And given that

Re: Relayfs question

2005-03-19 Thread Karim Yaghmour
Karim Yaghmour wrote: > What relayfs does, and does very well, is move very large amounts of > data out of the kernel and make them available to user-space with very > little overhead. In the actual case of your tty logger, I've browsed > through the code briefly, and I think that with relayfs

Re: Relayfs question

2005-03-19 Thread Karim Yaghmour
Jan Engelhardt wrote: > Ok, urandom was a bad example. I have my tty logger (ttyrpld.sf.net) which > moves a lot of data (depends) to userspace. It uses a ring buffer of "fixed" > size (set at module load time). Apart from that relayfs could use a dynamic > sized ring buffer, I would not see

Re: Relayfs question

2005-03-19 Thread Jan Engelhardt
Hi, >[...] > The current method is to just manage buffers and enable applications to mmap > the buffers to read them with some signalling on when a buffer is to be read > and when the kernel can overwrite it. > > A character device is unlikely to need such interface since you do want 16 > bytes

Re: Relayfs question

2005-03-19 Thread Baruch Even
Jan Engelhardt wrote: according to the relayfs description on opersys.com, |As the Linux kernel matures, there is an ever increasing number of facilities |and tools that need to relay large amounts of data from kernel space to user |space. Up to this point, each of these has had its own mechanism

Re: Relayfs question

2005-03-19 Thread Baruch Even
Jan Engelhardt wrote: according to the relayfs description on opersys.com, |As the Linux kernel matures, there is an ever increasing number of facilities |and tools that need to relay large amounts of data from kernel space to user |space. Up to this point, each of these has had its own mechanism

Re: Relayfs question

2005-03-19 Thread Jan Engelhardt
Hi, [...] The current method is to just manage buffers and enable applications to mmap the buffers to read them with some signalling on when a buffer is to be read and when the kernel can overwrite it. A character device is unlikely to need such interface since you do want 16 bytes of

Re: Relayfs question

2005-03-19 Thread Karim Yaghmour
Jan Engelhardt wrote: Ok, urandom was a bad example. I have my tty logger (ttyrpld.sf.net) which moves a lot of data (depends) to userspace. It uses a ring buffer of fixed size (set at module load time). Apart from that relayfs could use a dynamic sized ring buffer, I would not see any

Re: Relayfs question

2005-03-19 Thread Karim Yaghmour
Karim Yaghmour wrote: What relayfs does, and does very well, is move very large amounts of data out of the kernel and make them available to user-space with very little overhead. In the actual case of your tty logger, I've browsed through the code briefly, and I think that with relayfs you

Re: Relayfs question

2005-03-19 Thread Jan Engelhardt
Ok, urandom was a bad example. I have my tty logger (ttyrpld.sf.net) which moves a lot of data (depends) to userspace. It uses a ring buffer [...] [...] Basically, all the transport code you are doing in the kernel side of your logger would be taken care of by relayfs. And given that there are

Re: Relayfs question

2005-03-19 Thread Karim Yaghmour
Jan Engelhardt wrote: Well, what about things like urandom? It also moves a lot of data and does nothing else. Forgive my slowness today, but I don't get the angle here: - Relayfs is not a replacement for char devices, we've never claimed it to be. - Urandom generates a lot of data, and uses