Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andi Kleen
On Fri, Jul 06, 2007 at 11:33:43AM -0700, Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > >"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > > > >>For one thing, it looks like we're returning the wrong thing (EINVAL > >>rather than ENOTTY) across the board. This was unfortunately a common >

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Jeremy Fitzhardinge
H. Peter Anvin wrote: The union of things that are not typewriters and not giraffes are rather large, indeed. This is getting philosophical. I think my point is that we're rather short of good quality open source giraffe drivers. J - To unsubscribe from this list: send the line

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread H. Peter Anvin
Jeremy Fitzhardinge wrote: >> >> ENOTTY is so excessively misnamed that it is actually surprising >> anybody ever got that "right" (for very small values of right i guess) > > But it *isn't* a typewriter. Of course, it's not a giraffe either. > The union of things that are not typewriters and

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Jeremy Fitzhardinge
Andi Kleen wrote: "H. Peter Anvin" <[EMAIL PROTECTED]> writes: For one thing, it looks like we're returning the wrong thing (EINVAL rather than ENOTTY) across the board. This was unfortunately a common misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread H. Peter Anvin
Andi Kleen wrote: > "H. Peter Anvin" <[EMAIL PROTECTED]> writes: >> For one thing, it looks like we're returning the wrong thing (EINVAL >> rather than ENOTTY) across the board. This was unfortunately a common >> misunderstanding with non-tty-related ioctls in the early days of Linux. > > ENOTTY

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andi Kleen
"H. Peter Anvin" <[EMAIL PROTECTED]> writes: > > For one thing, it looks like we're returning the wrong thing (EINVAL > rather than ENOTTY) across the board. This was unfortunately a common > misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is so excessively

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread H. Peter Anvin
Geert Uytterhoeven wrote: > > Fuse-san discovered that running the umount that's part of busybox on a PS3 > with a recent kernel causes an error message to be printed on the console: > > | ioctl32(busybox:1340): Unknown cmd fd(3) cmd(4c01){t:'L';sz:0} > arg() on /dev/sda1 > > On

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Geert Uytterhoeven
On Fri, 6 Jul 2007, Andreas Schwab wrote: > Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > > > Is there anything we can do about this? > > Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Works fine, thx! I'll submit a patch. With kind regards, Geert Uytterhoeven Software Architect Sony

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andreas Schwab
Geert Uytterhoeven <[EMAIL PROTECTED]> writes: > Is there anything we can do about this? Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andreas Schwab
Geert Uytterhoeven [EMAIL PROTECTED] writes: Is there anything we can do about this? Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Geert Uytterhoeven
On Fri, 6 Jul 2007, Andreas Schwab wrote: Geert Uytterhoeven [EMAIL PROTECTED] writes: Is there anything we can do about this? Define it as IGNORE_IOCTL in fs/compat_ioctl.c? Works fine, thx! I'll submit a patch. With kind regards, Geert Uytterhoeven Software Architect Sony Network

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread H. Peter Anvin
Geert Uytterhoeven wrote: Fuse-san discovered that running the umount that's part of busybox on a PS3 with a recent kernel causes an error message to be printed on the console: | ioctl32(busybox:1340): Unknown cmd fd(3) cmd(4c01){t:'L';sz:0} arg() on /dev/sda1 On older

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andi Kleen
H. Peter Anvin [EMAIL PROTECTED] writes: For one thing, it looks like we're returning the wrong thing (EINVAL rather than ENOTTY) across the board. This was unfortunately a common misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is so excessively misnamed that

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread H. Peter Anvin
Andi Kleen wrote: H. Peter Anvin [EMAIL PROTECTED] writes: For one thing, it looks like we're returning the wrong thing (EINVAL rather than ENOTTY) across the board. This was unfortunately a common misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is so

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Jeremy Fitzhardinge
Andi Kleen wrote: H. Peter Anvin [EMAIL PROTECTED] writes: For one thing, it looks like we're returning the wrong thing (EINVAL rather than ENOTTY) across the board. This was unfortunately a common misunderstanding with non-tty-related ioctls in the early days of Linux. ENOTTY is so

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Jeremy Fitzhardinge
H. Peter Anvin wrote: The union of things that are not typewriters and not giraffes are rather large, indeed. This is getting philosophical. I think my point is that we're rather short of good quality open source giraffe drivers. J - To unsubscribe from this list: send the line

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread H. Peter Anvin
Jeremy Fitzhardinge wrote: ENOTTY is so excessively misnamed that it is actually surprising anybody ever got that right (for very small values of right i guess) But it *isn't* a typewriter. Of course, it's not a giraffe either. The union of things that are not typewriters and not

Re: Too verbose compat_ioctl messages?

2007-07-06 Thread Andi Kleen
On Fri, Jul 06, 2007 at 11:33:43AM -0700, Jeremy Fitzhardinge wrote: Andi Kleen wrote: H. Peter Anvin [EMAIL PROTECTED] writes: For one thing, it looks like we're returning the wrong thing (EINVAL rather than ENOTTY) across the board. This was unfortunately a common misunderstanding with